Closed Bug 1366415 Opened 3 years ago Closed 3 years ago

Unprefix autoGainControl and noiseSuppression constraints

Categories

(Core :: WebRTC: Audio/Video, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jib, Assigned: jib)

References

()

Details

(Keywords: dev-doc-complete, site-compat)

Attachments

(1 file)

As of https://github.com/w3c/mediacapture-main/pull/445 these are now standard.

See URL for spec (github tip).

We should remove our prefixes asap, as we should never have put moz-prefixed constraints in navigator.mediaDevices.getSupportedConstraints() to begin with.
This patch removes visibility of the moz-prefixed ones, yet still supports them on input, by converting them to the new ones, and dropping warnings in web console. This should cover most compat.
Comment on attachment 8869660 [details]
Bug 1366415: Unprefix mozAutoGainControl and mozNoiseSuppression w/deprecation warnings.

https://reviewboard.mozilla.org/r/141246/#review144850
Attachment #8869660 - Flags: review?(bugs) → review+
Comment on attachment 8869660 [details]
Bug 1366415: Unprefix mozAutoGainControl and mozNoiseSuppression w/deprecation warnings.

https://reviewboard.mozilla.org/r/141246/#review144892
Attachment #8869660 - Flags: review?(rjesup) → review+
Pushed by jbruaroey@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/c5ba9cddd390
Unprefix mozAutoGainControl and mozNoiseSuppression w/deprecation warnings. r=jesup,smaug
https://hg.mozilla.org/mozilla-central/rev/c5ba9cddd390
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.