Closed Bug 1366415 Opened 3 years ago Closed 3 years ago
Gain Control and noise Suppression constraints
59 bytes, text/x-review-board-request
As of https://github.com/w3c/mediacapture-main/pull/445 these are now standard. See URL for spec (github tip). We should remove our prefixes asap, as we should never have put moz-prefixed constraints in navigator.mediaDevices.getSupportedConstraints() to begin with.
This patch removes visibility of the moz-prefixed ones, yet still supports them on input, by converting them to the new ones, and dropping warnings in web console. This should cover most compat.
Comment on attachment 8869660 [details] Bug 1366415: Unprefix mozAutoGainControl and mozNoiseSuppression w/deprecation warnings. https://reviewboard.mozilla.org/r/141246/#review144850
Attachment #8869660 - Flags: review?(bugs) → review+
Comment on attachment 8869660 [details] Bug 1366415: Unprefix mozAutoGainControl and mozNoiseSuppression w/deprecation warnings. https://reviewboard.mozilla.org/r/141246/#review144892
Attachment #8869660 - Flags: review?(rjesup) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/c5ba9cddd390 Unprefix mozAutoGainControl and mozNoiseSuppression w/deprecation warnings. r=jesup,smaug
Posted the site compatibility note: https://www.fxsitecompat.com/en-CA/docs/2017/autogaincontrol-and-noisesuppression-media-track-constraints-have-been-unprefixed/
Pages updated on MDN: https://developer.mozilla.org/en-US/Firefox/Releases/55 https://developer.mozilla.org/en-US/docs/Web/API/MediaStreamTrack https://developer.mozilla.org/en-US/docs/Web/API/MediaTrackSupportedConstraints https://developer.mozilla.org/en-US/docs/Web/API/MediaTrackConstraints https://developer.mozilla.org/en-US/docs/Web/API/MediaTrackSettings Pages added to MDN: https://developer.mozilla.org/en-US/docs/Web/API/MediaTrackSupportedConstraints/autoGainControl https://developer.mozilla.org/en-US/docs/Web/API/MediaTrackSupportedConstraints/noiseSuppression https://developer.mozilla.org/en-US/docs/Web/API/MediaTrackConstraints/autoGainControl https://developer.mozilla.org/en-US/docs/Web/API/MediaTrackConstraints/noiseSuppression https://developer.mozilla.org/en-US/docs/Web/API/MediaTrackSettings/autoGainControl https://developer.mozilla.org/en-US/docs/Web/API/MediaTrackSettings/noiseSuppression We don't currently have a reference page at all for MediaTrackConstraints; when that gets done, these properties will be added there similarly to these that have been updated. That should be it for this bug. Let me know if there are any problems.
You need to log in before you can comment on or make changes to this bug.