1366448 - Permaorange in browser_force_process_selector.js when Gecko 55 merges to mozilla-beta on 2017-06-12

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Phil Ringnalda (:philor)]

Apparently the process described in https://hg.mozilla.org/mozilla-central/annotate/8d60d0f825110cfb646ac31dc16dc011708bcf34/dom/base/test/browser_force_process_selector.js#l17 is a nightly-only process, because when browser_force_process_selector.js hits beta in three weeks, it's going to be permaorange with an unexpected pass like https://treeherder.mozilla.org/logviewer.html#?job_id=100612603&repo=try

[Tracking Requested - why for this release]: potential merge permaorange, potential closed tree, potential delayed b1.

Comment 1

[Julien Cristau [:jcristau]]

marking as blocking 55.

Comment 2

[Blake Kaplan (:mrbkap) (inactive)]

Attachment: Bug 1366448 - Fix assumptions in this test so it works across branches.

Review commit: https://reviewboard.mozilla.org/r/142068/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142068/

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Comment on attachment 8870615 [details]
Bug 1366448 - Fix assumptions in this test so it works across branches.

https://reviewboard.mozilla.org/r/142068/#review146426

Looks okay - just two notes. Thanks!

::: commit-message-96e18:1
(Diff revision 1)
> +Bug 1366448 - Use a better method to ensure we're doing the right thing. r=mconley

I think this commit message could probably be a little clearer about:

a) Why this method is better
b) What the "right thing" is.

::: dom/base/test/browser_force_process_selector.js:8
(Diff revision 1)
> +  let processCreated = new Promise(resolve => {
> +    Services.obs.addObserver(function observer(subject, topic, data) {
> +      is(topic, CONTENT_CREATED, "got the right topic");
> +      Services.obs.removeObserver(observer, topic);
> +      resolve();
> +    }, CONTENT_CREATED)
> +  });

I believe you can use TestUtils.topicObserved for this - example:

```js

let processCreated = TestUtils.topicObserved(CONTENT_CREATED);

```

Comment 4

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8870615 [details]
Bug 1366448 - Fix assumptions in this test so it works across branches.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/142068/diff/1-2/

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 8870615 [details]
Bug 1366448 - Fix assumptions in this test so it works across branches.

https://reviewboard.mozilla.org/r/142068/#review146426

> I believe you can use TestUtils.topicObserved for this - example:
> 
> ```js
> 
> let processCreated = TestUtils.topicObserved(CONTENT_CREATED);
> 
> ```

I thought this existed somewhere but couldn't find it. Thanks!

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/43dffb5a0052
Fix assumptions in this test so it works across branches. r=mconley

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/43dffb5a0052