1366484 - Location bar and search bar don't have a border unless hover with lightweight theme applied

Status: VERIFIED FIXED

(Firefox :: Address Bar, defect, P1)

Description

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

[Tracking Requested - why for this release]: Regression

STR:
1. Install some Persona/Light Theme/Appearance
2. Hover address bar or search bar
3. See that text shifts during hovering

Comment 1

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: Firefox 54.png

Comment 2

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: Firefox 54 hovered.png

Comment 3

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: Firefox 55.png

Comment 4

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

Attachment: Firefox 55 hovered.png

Comment 5

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

"Speedy" Regression window (mozilla-central)
Good:
https://ftp.mozilla.org/pub/firefox/nightly/2017/05/2017-05-15-03-02-05-mozilla-central/

Bad:
https://ftp.mozilla.org/pub/firefox/nightly/2017/05/2017-05-16-12-20-50-mozilla-central/

Pushlog:
https://hg.mozilla.org/mozilla-central/pushloghtml?fromchange=e66dedabe582ba7b394aee4f89ed70fe389b3c46&tochange=b8e9b674033bcd1f3a4c59b9d0ee7619c1a17cc5



Probably caused by:
2d66ad57d5c0	Dale Harvey — Bug 1352366 - Implement photon location bar style changes. r=dao

Comment 6

[Dão Gottwald [:dao]]

The issue is that the border is missing by default and only added on hover. This is due to this not working as intended: http://searchfox.org/mozilla-central/source/browser/themes/windows/browser.css#661-663

This won't affect Firefox 55 as it's photon-specific.

Comment 7

[Dão Gottwald [:dao]]

I wonder if we should just get rid of --urlbar-border-color and --urlbar-border-color-hover... They don't seem to be particularly useful.

Comment 8

[Dão Gottwald [:dao]]

Attachment: Reorganize urlbar and searchbar border color rules for Photon

Comment 9

[Dale Harvey (:daleharvey)]

Comment on attachment 8869778 [details] [diff] [review]
Reorganize urlbar and searchbar border color rules for Photon

Sorry for missing, thanks

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/415c55bb940c
Reorganize urlbar and searchbar border color rules for Photon. r=dale

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed out for likely letting browser/components/resistfingerprinting/test/browser/browser_roundedWindow_newWindow.js frequently fail on Windows 7 VM:

https://hg.mozilla.org/integration/mozilla-inbound/rev/3a976d8e893b611f7b010ecc2afb9e40820531c6

A push showing the failure (much build bustage around that time): https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=c36497319158aaaf1ba7e28754e9b59b9cf3c441&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=100955257&repo=mozilla-inbound

08:53:26     INFO - TEST-PASS | browser/components/resistfingerprinting/test/browser/browser_roundedWindow_newWindow.js | The screen.width has a correct rounded value - 1000 == 1000 - 
08:53:26     INFO - Buffered messages finished
08:53:26     INFO - TEST-UNEXPECTED-FAIL | browser/components/resistfingerprinting/test/browser/browser_roundedWindow_newWindow.js | The screen.height has a correct rounded value - 800 == 900 - 
08:53:26     INFO - Stack trace:
08:53:26     INFO - resource://testing-common/content-task.js line 52 > eval:null:6
08:53:26     INFO - TEST-PASS | browser/components/resistfingerprinting/test/browser/browser_roundedWindow_newWindow.js | The window.innerWidth has a correct rounded value - 1000 == 1000 - 
08:53:26     INFO - Not taking screenshot here: see the one that was previously logged
08:53:26     INFO - TEST-UNEXPECTED-FAIL | browser/components/resistfingerprinting/test/browser/browser_roundedWindow_newWindow.js | The window.innerHeight has a correct rounded value - 800 == 900 - 
08:53:26     INFO - Stack trace:
08:53:26     INFO - resource://testing-common/content-task.js line 52 > eval:null:10

Comment 12

[Dão Gottwald [:dao]]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=4fc421da3fefe6b5ed84e91c64740246b1ab13f0

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/565fe2f6e16f
Reorganize urlbar and searchbar border color rules for Photon. r=dale

Comment 14

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/565fe2f6e16f

Comment 15

[Virtual_ManPL [:Virtual] 🇵🇱 - (please needinfo? me - so I will see your comment/reply/question/etc.)]

I'm marking this bug as VERIFIED, as issue looks fixed in Mozilla Firefox Nightly 55.0a1 (2017-05-24).

Comment 16

[Johann Hofmann [:johannh]]

Screenshots seem to confirm that this is fixed:

https://screenshots.mattn.ca/compare/?oldProject=mozilla-central&oldRev=545ffce30eac33921dcb44b5a916c78c5cb0fc95&newProject=mozilla-central&newRev=96e18bec9fc8a5ce623c16167c12756bbe190d73

The border looks slightly orange, but I think that's the automation cue UI.