Closed Bug 1366484 Opened 4 years ago Closed 4 years ago

Location bar and search bar don't have a border unless hover with lightweight theme applied

Categories

(Firefox :: Address Bar, defect, P1)

55 Branch
x86_64
Windows 7
defect

Tracking

()

VERIFIED FIXED
Firefox 55
Iteration:
55.6 - May 29
Tracking Status
firefox-esr45 --- unaffected
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 --- verified

People

(Reporter: Virtual, Assigned: dao)

References

Details

(Keywords: nightly-community, regression, Whiteboard: [photon-visual][p1])

Attachments

(5 files)

[Tracking Requested - why for this release]: Regression

STR:
1. Install some Persona/Light Theme/Appearance
2. Hover address bar or search bar
3. See that text shifts during hovering
The issue is that the border is missing by default and only added on hover. This is due to this not working as intended: http://searchfox.org/mozilla-central/source/browser/themes/windows/browser.css#661-663

This won't affect Firefox 55 as it's photon-specific.
Keywords: ux-consistency
Summary: Text in address bar and in search bar shifts on hover with Persona/Light Theme/Appearance in Mozilla Firefox Nightly 55.0a1 → Text in address bar and in search bar don't have a border unless hover with lightweight theme applied
Whiteboard: [photon-visual][p1]
I wonder if we should just get rid of --urlbar-border-color and --urlbar-border-color-hover... They don't seem to be particularly useful.
Assignee: nobody → dao+bmo
Status: NEW → ASSIGNED
Attachment #8869778 - Flags: review?(dale)
Summary: Text in address bar and in search bar don't have a border unless hover with lightweight theme applied → Location bar and search bar don't have a border unless hover with lightweight theme applied
Comment on attachment 8869778 [details] [diff] [review]
Reorganize urlbar and searchbar border color rules for Photon

Sorry for missing, thanks
Flags: needinfo?(dale)
Attachment #8869778 - Flags: review?(dale) → review+
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/415c55bb940c
Reorganize urlbar and searchbar border color rules for Photon. r=dale
Iteration: --- → 55.6 - May 29
Flags: qe-verify?
Priority: -- → P1
Flags: qe-verify? → qe-verify+
Backed out for likely letting browser/components/resistfingerprinting/test/browser/browser_roundedWindow_newWindow.js frequently fail on Windows 7 VM:

https://hg.mozilla.org/integration/mozilla-inbound/rev/3a976d8e893b611f7b010ecc2afb9e40820531c6

A push showing the failure (much build bustage around that time): https://treeherder.mozilla.org/#/jobs?repo=mozilla-inbound&revision=c36497319158aaaf1ba7e28754e9b59b9cf3c441&filter-resultStatus=testfailed&filter-resultStatus=busted&filter-resultStatus=exception&filter-resultStatus=retry&filter-resultStatus=usercancel&filter-resultStatus=runnable
Failure log: https://treeherder.mozilla.org/logviewer.html#?job_id=100955257&repo=mozilla-inbound

08:53:26     INFO - TEST-PASS | browser/components/resistfingerprinting/test/browser/browser_roundedWindow_newWindow.js | The screen.width has a correct rounded value - 1000 == 1000 - 
08:53:26     INFO - Buffered messages finished
08:53:26     INFO - TEST-UNEXPECTED-FAIL | browser/components/resistfingerprinting/test/browser/browser_roundedWindow_newWindow.js | The screen.height has a correct rounded value - 800 == 900 - 
08:53:26     INFO - Stack trace:
08:53:26     INFO - resource://testing-common/content-task.js line 52 > eval:null:6
08:53:26     INFO - TEST-PASS | browser/components/resistfingerprinting/test/browser/browser_roundedWindow_newWindow.js | The window.innerWidth has a correct rounded value - 1000 == 1000 - 
08:53:26     INFO - Not taking screenshot here: see the one that was previously logged
08:53:26     INFO - TEST-UNEXPECTED-FAIL | browser/components/resistfingerprinting/test/browser/browser_roundedWindow_newWindow.js | The window.innerHeight has a correct rounded value - 800 == 900 - 
08:53:26     INFO - Stack trace:
08:53:26     INFO - resource://testing-common/content-task.js line 52 > eval:null:10
Flags: needinfo?(dao+bmo)
QA Contact: brindusa.tot
Pushed by dgottwald@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/565fe2f6e16f
Reorganize urlbar and searchbar border color rules for Photon. r=dale
https://hg.mozilla.org/mozilla-central/rev/565fe2f6e16f
Status: ASSIGNED → RESOLVED
Closed: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
I'm marking this bug as VERIFIED, as issue looks fixed in Mozilla Firefox Nightly 55.0a1 (2017-05-24).
Status: RESOLVED → VERIFIED
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.