Closed
Bug 1366660
Opened 7 years ago
Closed 7 years ago
(photon) Transition for Search suggestion when input keyword into URL bar
Categories
(Firefox for Android Graveyard :: General, defect)
Firefox for Android Graveyard
General
Tracking
(firefox56 fixed, firefox57 verified)
VERIFIED
FIXED
Firefox 56
People
(Reporter: wesley_huang, Assigned: jwu)
References
Details
Attachments
(1 file)
No description provided.
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Assignee: nobody → topwu.tw
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8873726 [details] Bug 1366660 - [photon] Remove search suggestion animation. https://reviewboard.mozilla.org/r/145072/#review155586 ::: mobile/android/base/java/org/mozilla/gecko/home/SearchEngineRow.java:397 (Diff revision 1) > searchHistoryIterator.remove(); > } > } > > > - List<String> searchEngineSuggestions = new ArrayList<String>(); > + List<String> searchEngineSuggestions = new ArrayList<>(); maybe we can add `final` as well?
Attachment #8873726 -
Flags: review?(walkingice0204) → review+
Updated•7 years ago
|
Attachment #8873726 -
Flags: review?(max)
Comment hidden (mozreview-request) |
Assignee | ||
Comment 4•7 years ago
|
||
Try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=94bc70924915911b600b6d1e26876355f2317c2a
Keywords: checkin-needed
Comment 5•7 years ago
|
||
Autoland can't push this until it has r+ in MozReview from an eligible reviewer. http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/autoland.html#landing-commits
Keywords: checkin-needed
Comment 6•7 years ago
|
||
mozreview-review |
Comment on attachment 8873726 [details] Bug 1366660 - [photon] Remove search suggestion animation. https://reviewboard.mozilla.org/r/145072/#review156002
Assignee | ||
Updated•7 years ago
|
Attachment #8873726 -
Flags: review?(cnevinchen)
Comment 7•7 years ago
|
||
mozreview-review |
Comment on attachment 8873726 [details] Bug 1366660 - [photon] Remove search suggestion animation. https://reviewboard.mozilla.org/r/145072/#review156014
Comment 8•7 years ago
|
||
mozreview-review |
Comment on attachment 8873726 [details] Bug 1366660 - [photon] Remove search suggestion animation. https://reviewboard.mozilla.org/r/145072/#review156016
Attachment #8873726 -
Flags: review?(cnevinchen) → review+
Pushed by nechen@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/3b2732b017db [photon] Remove search suggestion animation. r=nechen,walkingice
Comment 10•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/3b2732b017db
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Comment 11•7 years ago
|
||
Verified as fixed on Nightly 56.0a1, (2017-08-10). Devices: Huawei Honor 8 (Android 6.0) Motorola Nexus 6 (Android 7.0) Prestigio Grace X5 (Android 4.4.2) Huawei Honor 8 (Android 6.0)
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•