1366660 - (photon) Transition for Search suggestion when input keyword into URL bar

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[Jing-wei Wu [:jwu]]

Attachment: Bug 1366660 - [photon] Remove search suggestion animation.

To improve user perceived performance, we decide to remove search suggestion animation.
Check trello card for more information: https://trello.com/c/mKxt7KPF/4-transition-for-search-suggestion-when-input-keyword-into-url-bar

Review commit: https://reviewboard.mozilla.org/r/145072/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145072/

Comment 2

[Julian Chu [:walkingice]]

Comment on attachment 8873726 [details]
Bug 1366660 - [photon] Remove search suggestion animation.

https://reviewboard.mozilla.org/r/145072/#review155586

::: mobile/android/base/java/org/mozilla/gecko/home/SearchEngineRow.java:397
(Diff revision 1)
>                  searchHistoryIterator.remove();
>              }
>          }
>  
>  
> -        List<String> searchEngineSuggestions = new ArrayList<String>();
> +        List<String> searchEngineSuggestions = new ArrayList<>();

maybe we can add `final` as well?

Comment 3

[Jing-wei Wu [:jwu]]

Comment on attachment 8873726 [details]
Bug 1366660 - [photon] Remove search suggestion animation.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145072/diff/1-2/

Comment 4

[Jing-wei Wu [:jwu]]

Try result: https://treeherder.mozilla.org/#/jobs?repo=try&revision=94bc70924915911b600b6d1e26876355f2317c2a

Comment 5

[Ryan VanderMeulen [:RyanVM]]

Autoland can't push this until it has r+ in MozReview from an eligible reviewer.
http://mozilla-version-control-tools.readthedocs.io/en/latest/mozreview/autoland.html#landing-commits

Comment 6

[Julian Chu [:walkingice]]

Comment on attachment 8873726 [details]
Bug 1366660 - [photon] Remove search suggestion animation.

https://reviewboard.mozilla.org/r/145072/#review156002

Comment 7

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8873726 [details]
Bug 1366660 - [photon] Remove search suggestion animation.

https://reviewboard.mozilla.org/r/145072/#review156014

Comment 8

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8873726 [details]
Bug 1366660 - [photon] Remove search suggestion animation.

https://reviewboard.mozilla.org/r/145072/#review156016

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3b2732b017db
[photon] Remove search suggestion animation. r=nechen,walkingice

Comment 10

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/3b2732b017db

Comment 11

[Oana Horvath [:ohorvath]]

Verified as fixed on Nightly 56.0a1, (2017-08-10).
Devices: 
Huawei Honor 8 (Android 6.0)
Motorola Nexus 6 (Android 7.0)
Prestigio Grace X5 (Android 4.4.2)
Huawei Honor 8 (Android 6.0)