1366671 - (photon) Update UI/Content for Empty screens and content for Android

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, enhancement)

Comment 1

[Jing-wei Wu [:jwu]]

Attachment: about:privatebrowsing

Hi Jack,

The information in `about:privatebrowsing` shows that private mode can provide both `Private browsing` and `Tracking protection`. You can check the attached file for screenshot.

But in visual spec, the empty screen in tabs tray only shows `Private browsing`, we have neither icon nor description about tracking protection. Should we also show it in our new visual design?

Furthermore, tracking protection can be enabled/disabled in Settings/Privacy/Tracking Protection. If the information shows in empty screen is what capabilities private mode can provide, maybe we should show/hide `Tracking protection` information based on user's preference.

Comment 2

[Jack Lin[:jacklin]]

I'm going to NI Carol to get this on her radar.

Thank you

Comment 3

[Carol Huang [:Carol]]

Hi Jing- wei, 
I updated the visual spec.
on the visual spec: Modified Empty screen content - p.14

And to answer to your question, whether the tracking protection is enabled or disabled, please display the same information on the empty screen as current design. Thank you!

Comment 4

[Jing-wei Wu [:jwu]]

Attachment: Bug 1366671 - Part 1: Duplicate empty screen resoueces for Photon.

Review commit: https://reviewboard.mozilla.org/r/157288/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157288/

Comment 5

[Jing-wei Wu [:jwu]]

Attachment: Bug 1366671 - Part 2: Support empty screen in private tabs panel.

Review commit: https://reviewboard.mozilla.org/r/157290/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/157290/

Comment 6

[Julian Chu [:walkingice]]

Comment on attachment 8887422 [details]
Bug 1366671 - Part 1: Duplicate empty screen resoueces for Photon.

https://reviewboard.mozilla.org/r/157288/#review164070

Comment 7

[Julian Chu [:walkingice]]

Comment on attachment 8887423 [details]
Bug 1366671 - Part 2: Support empty screen in private tabs panel.

https://reviewboard.mozilla.org/r/157290/#review164072

::: mobile/android/base/java/org/mozilla/gecko/tabs/PrivateTabsPanel.java:64
(Diff revision 1)
> +                    geckoApp.autoHideTabs();
> +                }
> +            });
> +        }
> +
> +        emptyTabsFrame.getViewTreeObserver().addOnGlobalLayoutListener(new ViewTreeObserver.OnGlobalLayoutListener() {

it is likely redundant?

Comment 8

[Jing-wei Wu [:jwu]]

Comment on attachment 8887422 [details]
Bug 1366671 - Part 1: Duplicate empty screen resoueces for Photon.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157288/diff/1-2/

Comment 9

[Jing-wei Wu [:jwu]]

Comment on attachment 8887423 [details]
Bug 1366671 - Part 2: Support empty screen in private tabs panel.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157290/diff/1-2/

Comment 10

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/5350f45b9724
Part 1: Duplicate empty screen resoueces for Photon. r=walkingice
https://hg.mozilla.org/integration/autoland/rev/2edde0aaa0f6
Part 2: Support empty screen in private tabs panel. r=walkingice

Comment 11

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/5350f45b9724
https://hg.mozilla.org/mozilla-central/rev/2edde0aaa0f6

Comment 12

[Francesco Lodolo [:flod]]

+<!ENTITY private_tab_panel_title "Private-Browsing + Tracking Protection">

I've never seen Private Browsing spelled with an hyphen. Does this come from specs? The screenshots doesn't have an hyphen

+<!ENTITY private_tab_panel_description "Firefox will prevent you from being tracked and won\'t remember any history, but download files and new bookmarks will still be saved on your devices." >

You don't want Firefox hard-coded, there's an entity for that. At this point, you'll need a new string ID to fix it
https://developer.mozilla.org/en-US/docs/Mozilla/Localization/Localization_content_best_practices#Changing_existing_strings

Comment 13

[Francesco Lodolo [:flod]]

(In reply to Francesco Lodolo [:flod] from comment #12)
> +<!ENTITY private_tab_panel_description "Firefox will prevent you from being
> tracked and won\'t remember any history, but download files and new
> bookmarks will still be saved on your devices." >

"download files" should be "downloaded files", not sure about "saved" (they were saved before, they'll be kept).

Is there a copy review process as part of the specs for Fennec?

Comment 14

[Ton [:Tonnes]]

Additionally, "on your devices" -> "to your device"? (or make changes in both so they match?)

https://transvision.mozfr.org/?recherche=files+and+new+bookmarks&repo=central&sourcelocale=en-US&locale=en-US&search_type=strings

Comment 15

[Jing-wei Wu [:jwu]]

Sorry for late reply. And after checking with the designer :carol, the strings  are copied from "about:privatebrowsing" web page, and that's why we didn't have string review before.

But some typos occurred while duplicating the strings(the hyphen and "ed" things), also the content in "about:privatebrowsing" is changed after the duplication. We would file another bug for these strings fixing.

Comment 16

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/1acc7a08d914
Backed out changeset 2edde0aaa0f6 
https://hg.mozilla.org/mozilla-central/rev/874cdf9f9c9e
Backed out changeset 5350f45b9724 on request from flod. r=backout a=backout

Comment 17

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

Backed this out as requested by :flod.

Comment 18

[Jing-wei Wu [:jwu]]

Comment on attachment 8887422 [details]
Bug 1366671 - Part 1: Duplicate empty screen resoueces for Photon.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157288/diff/2-3/

Comment 19

[Jing-wei Wu [:jwu]]

Comment on attachment 8887423 [details]
Bug 1366671 - Part 2: Support empty screen in private tabs panel.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/157290/diff/2-3/

Comment 20

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/aeb5d6a6ddd3
Part 1: Duplicate empty screen resoueces for Photon. r=walkingice
https://hg.mozilla.org/integration/autoland/rev/9cb73bdb10a7
Part 2: Support empty screen in private tabs panel. r=walkingice

Comment 21

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/aeb5d6a6ddd3
https://hg.mozilla.org/mozilla-central/rev/9cb73bdb10a7

Comment 22

[Ioana Chiorean]

Attachment: Screenshot

(In reply to Carol Huang [:Carol] from comment #3)
> Hi Jing- wei, 
> I updated the visual spec.
> on the visual spec: Modified Empty screen content - p.14

The image differs from the specs but in the meaning it is the same. Can you please confirm it is the right one? 

Pixel - Android 8.0 - Nightly 2017-08-13

Comment 23

[Carol Huang [:Carol]]

hi Ioana!
Recently we decide not to use any image for this screen. I will update the spec and reopen this bug to fix it!
Thanks!!

Comment 24

[Oana Horvath [:ohorvath]]

Verified the new private mode empty screen design matches the new specs.
Build: Nightly 57 (2017-08-23)
Devices:
Xiaomi Mi Pad 2 (Android 5.1)
Motorola Nexus 6 (Android 7.0)
HTC Desire 820 (Android 6.0.1)