1366674 - (photon) Indicator on splash screen when first time open

Status: VERIFIED FIXED

(Firefox for Android Graveyard :: General, defect)

Comment 1

[Nevin Chen(Not active on Bugzilla)]

Add some spec about Splash Screen (TBD)
1. Is only displayed when non-Java UI
2. If displayed, the minimum display time is 0.5 sec, maximum display time is 2 sec.
3. When web page render completes, splash screen will hide automatically.

Comment 2

[Nevin Chen(Not active on Bugzilla)]

Attachment: Bug 1366674 - Add Splash Screen.

Review commit: https://reviewboard.mozilla.org/r/148420/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/148420/

Comment 3

[Nevin Chen(Not active on Bugzilla)]

Hi Carol
May I know is motion also a requirement now? Or we're still investigating?

Comment 4

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8877090 [details]
Bug 1366674 - Add Splash Screen.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148420/diff/1-2/

Comment 5

[Carol Huang [:Carol]]

Hi Nevin, 
We only need to add the static logo for the screen. the prototype link is only demo on how it looks like after we add the splash screen. thank you!

Comment 6

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8877090 [details]
Bug 1366674 - Add Splash Screen.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148420/diff/2-3/

Comment 7

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8877090 [details]
Bug 1366674 - Add Splash Screen.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148420/diff/3-4/

Comment 8

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8877090 [details]
Bug 1366674 - Add Splash Screen.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148420/diff/4-5/

Comment 9

[Max Liu [:maliu]]

Comment on attachment 8877090 [details]
Bug 1366674 - Add Splash Screen.

https://reviewboard.mozilla.org/r/148420/#review156550

LGTM

::: mobile/android/base/java/org/mozilla/gecko/BrowserApp.java:2789
(Diff revision 5)
> +            // But if GeckoThread.isRunning, the will be 0 sec for web rendering.
> +            // In that case, we don't want to show the SlashScreen/
> +            if (showSplashScreen && !GeckoThread.isRunning()) {
> +
> +                final ViewGroup main = (ViewGroup) findViewById(R.id.main_layout);
> +                View splashLayout = LayoutInflater.from(this).inflate(R.layout.splash_screen, main);

nit: final

Comment 10

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8877090 [details]
Bug 1366674 - Add Splash Screen.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148420/diff/5-6/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/7c6658c33dc6
Add Splash Screen. r=maliu

Comment 12

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out for android build bustage like https://treeherder.mozilla.org/logviewer.html#?job_id=109304017&repo=autoland

https://hg.mozilla.org/integration/autoland/rev/8d9491c67cfb13ba92f15955821d5c16746fce17

Comment 13

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8877090 [details]
Bug 1366674 - Add Splash Screen.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148420/diff/6-7/

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/ccc2926a42d6
Add Splash Screen. r=maliu

Comment 15

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/8e4d3c5d8e2d
Backed out changeset ccc2926a42d6 for breaking android builds

Comment 16

[Carsten Book [:Tomcat]]

hi, had to back this out for breaking android like https://treeherder.mozilla.org/logviewer.html#?job_id=109526334&repo=autoland

Comment 17

[Nevin Chen(Not active on Bugzilla)]

Comment on attachment 8877090 [details]
Bug 1366674 - Add Splash Screen.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/148420/diff/7-8/

Comment 18

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9f1c4935f15c
Add Splash Screen. r=maliu

Comment 19

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/9f1c4935f15c

Comment 20

[Oana Horvath [:ohorvath]]

Verified as fixed on Nightly 57 (2017-08-27).
The splash screen works by the rules specified in Comment 1:
-only displayed when non-Java UI
-if displayed, the minimum display time is 0.5 sec, maximum display time is 2 sec.
-when web page render completes, splash screen will hide automatically.

Devices: 
Prestigio Grace X5 (Android 4.4.2)
Huawei Honor 5X (Android 5.1.1)
HTC Desire 820 (Android 6.0.1)
Huawei MediaPad M2 (Android 5.1.1)