(photon) Search Suggestions

VERIFIED FIXED in Firefox 56

Status

()

VERIFIED FIXED
a year ago
a year ago

People

(Reporter: wesley_huang, Assigned: jwu)

Tracking

(Blocks: 2 bugs)

Trunk
Firefox 56
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox56 fixed, firefox57 verified)

Details

User Story

Visual spec - https://drive.google.com/file/d/0B-9PIePlQZRldk9INm9TUXBkcWs/view?usp=sharing

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(3 attachments)

Comment hidden (empty)
Blocks: 1366704

Updated

a year ago
User Story: (updated)
(Assignee)

Updated

a year ago
Assignee: nobody → topwu.tw

Updated

a year ago
User Story: (updated)
The spec doesn't indicate anything about the clock icon that we currently use to differentiate between local search history and search suggestions from the user's default search engine. Do we want to do anything about that as well (see also bug 1277277)?
Flags: needinfo?(chuang)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 5

a year ago
mozreview-review
Comment on attachment 8881538 [details]
Bug 1366679 - Part 1: Support configuring FaviconView backgroud corner radius in xml.

https://reviewboard.mozilla.org/r/152692/#review157860
Attachment #8881538 - Flags: review?(cnevinchen) → review+

Comment 6

a year ago
mozreview-review
Comment on attachment 8881539 [details]
Bug 1366679 - Part 2: Duplicate search suggestion resources for Australis/Photon.

https://reviewboard.mozilla.org/r/152694/#review157866
Attachment #8881539 - Flags: review?(cnevinchen) → review+

Comment 7

a year ago
mozreview-review
Comment on attachment 8881540 [details]
Bug 1366679 - Part 3: Implement search suggestion visual refresh for Photon.

https://reviewboard.mozilla.org/r/152696/#review157870
Attachment #8881540 - Flags: review?(cnevinchen) → review+
(Assignee)

Comment 8

a year ago
(In reply to Jan Henning [:JanH] from comment #1)
> The spec doesn't indicate anything about the clock icon that we currently
> use to differentiate between local search history and search suggestions
> from the user's default search engine. Do we want to do anything about that
> as well (see also bug 1277277)?

We have another bug 1366669 focusing on icons refresh. Designers will update their visual spec in this bug and it should tell us how to update the clock icon.
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 12

a year ago
mozreview-review
Comment on attachment 8881538 [details]
Bug 1366679 - Part 1: Support configuring FaviconView backgroud corner radius in xml.

https://reviewboard.mozilla.org/r/152692/#review158056
Attachment #8881538 - Flags: review?(walkingice0204) → review+

Comment 13

a year ago
mozreview-review
Comment on attachment 8881539 [details]
Bug 1366679 - Part 2: Duplicate search suggestion resources for Australis/Photon.

https://reviewboard.mozilla.org/r/152694/#review158058
Attachment #8881539 - Flags: review?(walkingice0204) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 17

a year ago
mozreview-review
Comment on attachment 8881540 [details]
Bug 1366679 - Part 3: Implement search suggestion visual refresh for Photon.

https://reviewboard.mozilla.org/r/152696/#review158286
Attachment #8881540 - Flags: review?(walkingice0204) → review+
(Assignee)

Updated

a year ago
Keywords: checkin-needed

Comment 18

a year ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/95095d0a8c62
Part 1: Support configuring FaviconView backgroud corner radius in xml. r=nechen,walkingice
https://hg.mozilla.org/integration/autoland/rev/d9be38eb4872
Part 2: Duplicate search suggestion resources for Australis/Photon. r=nechen,walkingice
https://hg.mozilla.org/integration/autoland/rev/b42ffdd847dc
Part 3: Implement search suggestion visual refresh for Photon. r=nechen,walkingice
Keywords: checkin-needed

Comment 19

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/95095d0a8c62
https://hg.mozilla.org/mozilla-central/rev/d9be38eb4872
https://hg.mozilla.org/mozilla-central/rev/b42ffdd847dc
Status: NEW → RESOLVED
Last Resolved: a year ago
status-firefox56: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56

Updated

a year ago
Flags: needinfo?(chuang)
(Assignee)

Updated

a year ago
Blocks: 1379652

Comment 20

a year ago
Verified as fixed on Nightly 56.0a1, (2017-08-10).
Devices: 
Huawei Honor 8 (Android 6.0)
Motorola Nexus 6 (Android 7.0)
Prestigio Grace X5 (Android 4.4.2)
Huawei Honor 8 (Android 6.0)
Status: RESOLVED → VERIFIED
status-firefox57: --- → verified
You need to log in before you can comment on or make changes to this bug.