Closed Bug 1366679 Opened 8 years ago Closed 7 years ago

(photon) Search Suggestions

Categories

(Firefox for Android Graveyard :: General, enhancement)

Product:
Firefox for Android Graveyard
Component:
General
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(firefox56 fixed, firefox57 verified)

Status:
VERIFIED FIXED
Milestone:
Firefox 56
Tracking Flags:
Tracking Status
firefox56 --- fixed
firefox57 --- verified

People

(Reporter: wesley_huang, Assigned: jwu)

References

Details

User Story

Visual spec - https://drive.google.com/file/d/0B-9PIePlQZRldk9INm9TUXBkcWs/view?usp=sharing

Attachments

(3 files)

Bug 1366679 - Part 1: Support configuring FaviconView backgroud corner radius in xml.
59 bytes, text/x-review-board-request
cnevinchen
: review+
walkingice
: review+
Details
Bug 1366679 - Part 2: Duplicate search suggestion resources for Australis/Photon.
59 bytes, text/x-review-board-request
cnevinchen
: review+
walkingice
: review+
Details
Bug 1366679 - Part 3: Implement search suggestion visual refresh for Photon.
59 bytes, text/x-review-board-request
cnevinchen
: review+
walkingice
: review+
Details
No description provided.
User Story: (updated)
Assignee: nobody → topwu.tw
User Story: (updated)
The spec doesn't indicate anything about the clock icon that we currently use to differentiate between local search history and search suggestions from the user's default search engine. Do we want to do anything about that as well (see also bug 1277277)?
Flags: needinfo?(chuang)
Comment on attachment 8881538 [details] Bug 1366679 - Part 1: Support configuring FaviconView backgroud corner radius in xml. https://reviewboard.mozilla.org/r/152692/#review157860
Attachment #8881538 - Flags: review?(cnevinchen) → review+
Comment on attachment 8881539 [details] Bug 1366679 - Part 2: Duplicate search suggestion resources for Australis/Photon. https://reviewboard.mozilla.org/r/152694/#review157866
Attachment #8881539 - Flags: review?(cnevinchen) → review+
Comment on attachment 8881540 [details] Bug 1366679 - Part 3: Implement search suggestion visual refresh for Photon. https://reviewboard.mozilla.org/r/152696/#review157870
Attachment #8881540 - Flags: review?(cnevinchen) → review+
(In reply to Jan Henning [:JanH] from comment #1) > The spec doesn't indicate anything about the clock icon that we currently > use to differentiate between local search history and search suggestions > from the user's default search engine. Do we want to do anything about that > as well (see also bug 1277277)? We have another bug 1366669 focusing on icons refresh. Designers will update their visual spec in this bug and it should tell us how to update the clock icon.
Comment on attachment 8881538 [details] Bug 1366679 - Part 1: Support configuring FaviconView backgroud corner radius in xml. https://reviewboard.mozilla.org/r/152692/#review158056
Attachment #8881538 - Flags: review?(walkingice0204) → review+
Comment on attachment 8881539 [details] Bug 1366679 - Part 2: Duplicate search suggestion resources for Australis/Photon. https://reviewboard.mozilla.org/r/152694/#review158058
Attachment #8881539 - Flags: review?(walkingice0204) → review+
Comment on attachment 8881540 [details] Bug 1366679 - Part 3: Implement search suggestion visual refresh for Photon. https://reviewboard.mozilla.org/r/152696/#review158286
Attachment #8881540 - Flags: review?(walkingice0204) → review+
Keywords: checkin-needed
Pushed by ryanvm@gmail.com: https://hg.mozilla.org/integration/autoland/rev/95095d0a8c62 Part 1: Support configuring FaviconView backgroud corner radius in xml. r=nechen,walkingice https://hg.mozilla.org/integration/autoland/rev/d9be38eb4872 Part 2: Duplicate search suggestion resources for Australis/Photon. r=nechen,walkingice https://hg.mozilla.org/integration/autoland/rev/b42ffdd847dc Part 3: Implement search suggestion visual refresh for Photon. r=nechen,walkingice
Keywords: checkin-needed
Flags: needinfo?(chuang)
Blocks: 1379652
Verified as fixed on Nightly 56.0a1, (2017-08-10). Devices: Huawei Honor 8 (Android 6.0) Motorola Nexus 6 (Android 7.0) Prestigio Grace X5 (Android 4.4.2) Huawei Honor 8 (Android 6.0)
Status: RESOLVED → VERIFIED
status-firefox57: --- → verified
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: