Closed
Bug 1366681
Opened 7 years ago
Closed 7 years ago
Move Add-On to the first level menu
Categories
(Firefox for Android Graveyard :: Add-on Manager, enhancement, P2)
Firefox for Android Graveyard
Add-on Manager
Tracking
(fennec+, firefox56 verified)
VERIFIED
FIXED
Firefox 56
People
(Reporter: wesley_huang, Assigned: walkingice, NeedInfo)
References
Details
(Whiteboard: triaged)
Attachments
(2 files)
Front-end effort to move the add-on option to 1st level so that user can access it more easily
Comment 1•7 years ago
|
||
I think someone on the Taipei team was are going to take this on?
Priority: -- → P2
Whiteboard: triaged
Comment hidden (mozreview-request) |
Comment 4•7 years ago
|
||
mozreview-review |
Comment on attachment 8873318 [details]
Bug 1366681 - Try to move Add-On to the first level menu
https://reviewboard.mozilla.org/r/144780/#review148700
LGTM.
FYI: In the past we did this for history and bookmarks. Back then we moved this move behind a switchboard flag ("bookmark-history-menu") to run an A/B experiment and see how this affects usage.
Attachment #8873318 -
Flags: review?(s.kaspari) → review+
Assignee | ||
Comment 5•7 years ago
|
||
Sebastian: Thanks, Good to know! Let me ask product manager to see whether should we involve switchboard here.
Reporter | ||
Comment 6•7 years ago
|
||
according to the funnel meeting today: YES. it'll be great to use switchboard.
Comment hidden (mozreview-request) |
Comment hidden (mozreview-request) |
Assignee | ||
Comment 9•7 years ago
|
||
I updated the patch to use SwitchBoard. For a target user, to display AddOns menu item in top-level menu. Otherwise, keep the menu item is original place.
Still don't know how to clear review flag. (D'oh)
Comment 10•7 years ago
|
||
mozreview-review |
Comment on attachment 8873318 [details]
Bug 1366681 - Try to move Add-On to the first level menu
https://reviewboard.mozilla.org/r/144780/#review157698
Attachment #8873318 -
Flags: review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Comment 11•7 years ago
|
||
We're sorry, Autoland could not rebase your commits for you automatically. Please manually rebase your commits and try again.
hg error in cmd: hg rebase -s 4dc274291ee1 -d 3c6fba8e4015: rebasing 404190:4dc274291ee1 "Bug 1366681 - Try to move Add-On to the first level menu r=sebastian" (tip)
merging mobile/android/app/src/main/res/menu-large/browser_app_menu.xml and mobile/android/base/resources/menu-large/browser_app_menu.xml to mobile/android/app/src/main/res/menu-large/browser_app_menu.xml
merging mobile/android/app/src/main/res/menu-xlarge/browser_app_menu.xml and mobile/android/base/resources/menu-xlarge/browser_app_menu.xml to mobile/android/app/src/main/res/menu-xlarge/browser_app_menu.xml
merging mobile/android/app/src/main/res/menu/browser_app_menu.xml and mobile/android/base/resources/menu/browser_app_menu.xml to mobile/android/app/src/main/res/menu/browser_app_menu.xml
merging mobile/android/base/java/org/mozilla/gecko/BrowserApp.java
merging mobile/android/base/java/org/mozilla/gecko/Experiments.java
warning: conflicts while merging mobile/android/base/java/org/mozilla/gecko/Experiments.java! (edit, then use 'hg resolve --mark')
unresolved conflicts (see hg resolve, then hg rebase --continue)
Updated•7 years ago
|
Keywords: checkin-needed
Comment hidden (mozreview-request) |
Comment 14•7 years ago
|
||
Pushed by cbook@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/2b51a135ae25
Try to move Add-On to the first level menu r=sebastian
Keywords: checkin-needed
Comment 15•7 years ago
|
||
bugherder |
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox56:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 56
Comment 16•7 years ago
|
||
Do we have any kind of telemetry to see if this helped add-on usage?
Also I'm wondering .. with the move to WebExtensions in 57 - isn't there a high chance that we annoy users: We encourage them to install add-ons and them we might take them away in 57 (if they are using the legacy API).
Assignee | ||
Comment 17•7 years ago
|
||
In `BrowserApp.onOptionsItemSelected` we have telemetry to record which menu item is clicked, I think we can compare the usage between *R.id.addons* and *R.id.addons_top_level*.
yeah I am also wondering about that. We planned to do this months ago since we wanted to promote WebExtensions, and it is likely we don't have enough resource to take care of this topic anymore. Joe, do you have any idea?
Flags: needinfo?(jcheng)
Updated•7 years ago
|
QA Contact: ioana.chiorean
Comment 18•7 years ago
|
||
Add-ons options it is at 1st level access in settings
Comment 19•7 years ago
|
||
As seen in the attached screenshot in previous comment, the option is now at 1st level access.
Marking bug as verified fixed.
Status: RESOLVED → VERIFIED
Comment 20•7 years ago
|
||
I believe we have other telemetry to understand Android add-on usage
pinging AndyM
"with the move to WebExtensions in 57 - isn't there a high chance that we annoy users: We encourage them to install add-ons and them we might take them away in 57 (if they are using the legacy API)."
I'd like to hear what Add-on team thinks about this as they've been preparing for this. I believe we should have alternative WebExtentions for users if their existing add-on aren't available (at least the top ones)
Flags: needinfo?(jcheng) → needinfo?(amckay)
Comment 21•7 years ago
|
||
There is a discussion about an incompatible badge on mobile pages here: https://github.com/mozilla/addons-frontend/issues/2754. If you feel it will make a difference, feel free to delay it to 57 when everything will be WebExtensions only.
Flags: needinfo?(amckay)
Comment 22•7 years ago
|
||
Hi Joe
Do we still need this experiment?
? for triage discussion
tracking-fennec: --- → ?
Flags: needinfo?(jcheng)
Updated•7 years ago
|
tracking-fennec: ? → +
Updated•4 years ago
|
Product: Firefox for Android → Firefox for Android Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•