1366691 - nsSHEntryShared::mSHistory may not be set after AbandonBFCacheEntry.

Status: NEW

(Core :: DOM: Navigation, defect, P3)

Description

[Samael Wang [:freesamael] (away for now)]

If an entry was already added to the SHistory, and then someone called AbandonBFCacheEntry to create a new nsSHEntryShared for the SHEntry, mSHistory will never be set since there's no subsequent AddEntry / ReplaceEntry calls.

Was initially found when working on bug 1363036 by adding an assertion. Example log here:
https://treeherder.mozilla.org/logviewer.html#?job_id=100825894&repo=try&lineNumber=19946

This specific case was a history load, and then an error caused AbandonBFCacheEntry:
http://searchfox.org/mozilla-central/rev/79f625ac56d936ef5d17ebe13a123b25efee4241/docshell/base/nsDocShell.cpp#11748

Comment 1

[Hsin-Yi Tsai (she/her) [:hsinyi]]

Looks P1 for me as it blocks bug 1347823 which is already landed.
Samael, feel free to change if see fit.