1366702 - Callback for contextMenus.create is not called when a failure occurs

Status: VERIFIED FIXED

(WebExtensions :: Frontend, defect, P3)

Description

[61.1p57]

User Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:54.0) Gecko/20100101 Firefox/54.0
Build ID: 20170518105722

Steps to reproduce:

Run following code on extension console twice:

browser.contextMenus.create({
    id: '0',
    title: '0',
    contexts: ['all']
}, () => {
    console.error(browser.runtime.lastError);
});


Actual results:

1st
Returns `0`
Logs     `null`

2nd
Returns `0`
Raises   "Id already exists"  (ext-contextMenus.js:389)
            "Error: An unexpected error occurred" (unknown)
Nothing is logged


Expected results:

The callback should also be called when a failure occurs, as the document at [1] states that "It uses an optional callback to communicate success or failure"

[1]: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/API/contextMenus/create#Parameters

Comment 1

[Rob Wu [:robwu]]

Attachment: Bug 1366702 - Invoke menus.create callback if error occurs + tests

Review commit: https://reviewboard.mozilla.org/r/258466/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/258466/

Comment 2

[Shane Caraveo (:mixedpuppy)]

Comment on attachment 8993766 [details]
Bug 1366702 - Invoke menus.create callback if error occurs + tests

https://reviewboard.mozilla.org/r/258466/#review266410

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c344f123a5c6
Invoke menus.create callback if error occurs + tests r=mixedpuppy

Comment 4

[Cristian Brindusan [:cbrindusan]]

https://hg.mozilla.org/mozilla-central/rev/c344f123a5c6

Comment 5

[CosminB]

Attachment: Bug1366702.png

This issue is verified as fixed on Firefox 63.0a1 (20180729220222) under Win 7 64-bit and Mac OS X 10.13.3.

Please see the attached screenshot.