Closed Bug 1366749 Opened 7 years ago Closed 7 years ago

[Unix] Button layout on error pages

Categories

(Firefox :: Theme, defect)

Product:
Firefox
Component:
Theme
Version:
53 Branch
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED INVALID

People

(Reporter: frank.bruetting, Unassigned)

Details

User Agent: Mozilla/5.0 (X11; Fedora; Linux x86_64; rv:53.0) Gecko/20100101 Firefox/53.0
Build ID: 20170517123028



Actual results:

I've seen the Photon rework. On the error pages like [1], the preferred buttons are on the left side.

[1] https://www.soeren-hentzschel.at/wp-content/uploads/2017/05/firefox-57-content-neu-3.png


Expected results:

With the improved usage of GTK in Firefox, it would be great if the preferred buttons could be placed on the right side, according to the GTK style guideline [2] (“When a dialog includes an affirmative and a cancel button, always ensure that the cancel button appears first, before the affirmative button. In left-to-right locales, this is on the left.”). Then it would be a more consistent experience throughout the system.

[2] https://developer.gnome.org/hig/stable/dialogs.html.en
Blocks: photon-visual
Component: Untriaged → Widget: Gtk
OS: Unspecified → Linux
Product: Firefox → Core
Hardware: Unspecified → x86_64
Button ordering in in-content pages is not done by widget, moving to Fx::Theme.
Component: Widget: Gtk → Theme
Product: Core → Firefox
The buttons currently use the correct order. This bug seems to have been filed purely based a mockup rather than what's actually implemented.
Status: UNCONFIRMED → RESOLVED
Closed: 7 years ago
Resolution: --- → INVALID
No longer blocks: photon-visual
You need to log in before you can comment on or make changes to this bug.