DevTools panel icon is inverted with Light Theme

RESOLVED FIXED in Firefox 55

Status

()

Toolkit
WebExtensions: Developer Tools
P1
normal
RESOLVED FIXED
3 months ago
2 months ago

People

(Reporter: Wladimir Palant, Assigned: rpl)

Tracking

(Blocks: 2 bugs)

Trunk
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: triaged)

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Reporter)

Description

3 months ago
When devtools.panel.create() API has been implemented in bug 1300587, for some reason it was decided that inverting icon colors for the Light Theme is a good idea: https://dxr.mozilla.org/mozilla-central/rev/9851fcb0bf4d855c36729d7de19f0fa5c9f69776/browser/components/extensions/ext-devtools-panels.js#85. As a result, Adblock Plus icon appears with black text on blue background which is cute but makes it somewhat less recognizable. This flag should be removed or at least made optional.
(Reporter)

Updated

3 months ago
Blocks: 1226547

Updated

3 months ago
Assignee: nobody → lgreco
Priority: -- → P3
Whiteboard: triaged
Also seeing this with the Ember panel as well. https://github.com/emberjs/ember-inspector/issues/666#issuecomment-305604530
(Assignee)

Updated

2 months ago
Blocks: 1370525
(Assignee)

Updated

2 months ago
No longer blocks: 1211859
Comment hidden (mozreview-request)
(Assignee)

Updated

2 months ago
Status: NEW → ASSIGNED
Iteration: --- → 55.7 - Jun 12
Priority: P3 → P1
(Assignee)

Comment 3

2 months ago
I think that the most reasonable thing to do is to switch invertIconForLightTheme to false in the first place (and also test this behavior explicitly).

In a follow up we can decide how to make the icon customizable by the extension to better match a devtools theme.

Comment 4

2 months ago
mozreview-review
Comment on attachment 8875296 [details]
Bug 1366755 - devtools.panels.create should set invertIconForLightTheme to false by default.

https://reviewboard.mozilla.org/r/146708/#review150838
Attachment #8875296 - Flags: review?(aswan) → review+

Comment 5

2 months ago
Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/62c0be1d8629
devtools.panels.create should set invertIconForLightTheme to false by default. r=aswan

Comment 6

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/62c0be1d8629
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.