|Submitter||Diff||Changes||Open Issues||Last Updated|
|Error loading review requests:|
59 bytes, text/x-review-board-request
|Details | Review|
When devtools.panel.create() API has been implemented in bug 1300587, for some reason it was decided that inverting icon colors for the Light Theme is a good idea: https://dxr.mozilla.org/mozilla-central/rev/9851fcb0bf4d855c36729d7de19f0fa5c9f69776/browser/components/extensions/ext-devtools-panels.js#85. As a result, Adblock Plus icon appears with black text on blue background which is cute but makes it somewhat less recognizable. This flag should be removed or at least made optional.
Also seeing this with the Ember panel as well. https://github.com/emberjs/ember-inspector/issues/666#issuecomment-305604530
I think that the most reasonable thing to do is to switch invertIconForLightTheme to false in the first place (and also test this behavior explicitly). In a follow up we can decide how to make the icon customizable by the extension to better match a devtools theme.
Comment on attachment 8875296 [details] Bug 1366755 - devtools.panels.create should set invertIconForLightTheme to false by default. https://reviewboard.mozilla.org/r/146708/#review150838
Pushed by email@example.com: https://hg.mozilla.org/integration/autoland/rev/62c0be1d8629 devtools.panels.create should set invertIconForLightTheme to false by default. r=aswan