DevTools panel icon is inverted with Light Theme

RESOLVED FIXED in Firefox 55

Status

defect
P1
normal
RESOLVED FIXED
2 years ago
Last year

People

(Reporter: gaubugzilla, Assigned: rpl)

Tracking

(Blocks 2 bugs)

Trunk
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

(Whiteboard: triaged)

Attachments

(1 attachment)

When devtools.panel.create() API has been implemented in bug 1300587, for some reason it was decided that inverting icon colors for the Light Theme is a good idea: https://dxr.mozilla.org/mozilla-central/rev/9851fcb0bf4d855c36729d7de19f0fa5c9f69776/browser/components/extensions/ext-devtools-panels.js#85. As a result, Adblock Plus icon appears with black text on blue background which is cute but makes it somewhat less recognizable. This flag should be removed or at least made optional.
Assignee: nobody → lgreco
Priority: -- → P3
Whiteboard: triaged
Blocks: 1370525
No longer blocks: 1211859
Status: NEW → ASSIGNED
Iteration: --- → 55.7 - Jun 12
Priority: P3 → P1
I think that the most reasonable thing to do is to switch invertIconForLightTheme to false in the first place (and also test this behavior explicitly).

In a follow up we can decide how to make the icon customizable by the extension to better match a devtools theme.
Comment on attachment 8875296 [details]
Bug 1366755 - devtools.panels.create should set invertIconForLightTheme to false by default.

https://reviewboard.mozilla.org/r/146708/#review150838
Attachment #8875296 - Flags: review?(aswan) → review+
Pushed by luca.greco@alcacoop.it:
https://hg.mozilla.org/integration/autoland/rev/62c0be1d8629
devtools.panels.create should set invertIconForLightTheme to false by default. r=aswan
https://hg.mozilla.org/mozilla-central/rev/62c0be1d8629
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.