1366755 - DevTools panel icon is inverted with Light Theme

Status: RESOLVED FIXED

(WebExtensions :: Developer Tools, defect, P1)

Description

[Wladimir Palant]

When devtools.panel.create() API has been implemented in bug 1300587, for some reason it was decided that inverting icon colors for the Light Theme is a good idea: https://dxr.mozilla.org/mozilla-central/rev/9851fcb0bf4d855c36729d7de19f0fa5c9f69776/browser/components/extensions/ext-devtools-panels.js#85. As a result, Adblock Plus icon appears with black text on blue background which is cute but makes it somewhat less recognizable. This flag should be removed or at least made optional.

Comment 1

[Bryan Clark (DevTools PM) [:clarkbw]]

Also seeing this with the Ember panel as well. https://github.com/emberjs/ember-inspector/issues/666#issuecomment-305604530

Comment 2

[Luca Greco [:rpl] [:luca] [:lgreco]]

Attachment: Bug 1366755 - devtools.panels.create should set invertIconForLightTheme to false by default.

Review commit: https://reviewboard.mozilla.org/r/146708/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/146708/

Comment 3

[Luca Greco [:rpl] [:luca] [:lgreco]]

I think that the most reasonable thing to do is to switch invertIconForLightTheme to false in the first place (and also test this behavior explicitly).

In a follow up we can decide how to make the icon customizable by the extension to better match a devtools theme.

Comment 4

[Andrew Swan [:aswan]]

Comment on attachment 8875296 [details]
Bug 1366755 - devtools.panels.create should set invertIconForLightTheme to false by default.

https://reviewboard.mozilla.org/r/146708/#review150838

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/62c0be1d8629
devtools.panels.create should set invertIconForLightTheme to false by default. r=aswan

Comment 6

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/62c0be1d8629