Automate the NSPR version requirement when creating NSS release archives

RESOLVED FIXED in 3.31

Status

NSS
Build
RESOLVED FIXED
6 months ago
6 months ago

People

(Reporter: kaie, Assigned: kaie)

Tracking

3.31
3.31

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

6 months ago
We should make it easier to create correct NSS release archives.

As of today
  ./nss/automation/release/nss-release-helper.py create_nss_release_archive

requires to manually specify the minimum NSPR version that will be used when creating the combined NSS+NSPR release source archive.

In particular when creating patch releases of older NSS branches, it's easy to make an error here, unless the operator carefully examines the past release archives.

To simplify the process, I suggest the following approach:

- we add a new text file to NSS, which contains the minimum required
  version number for this NSS release.
  This file should be updated by developers, if the NSPR version requirement
  for a given NSS branch changes.

- We remove the NSPR version parameter from the create_nss_release_archive
  command, and instead read that information from the new text file
(Assignee)

Comment 1

6 months ago
Created attachment 8870025 [details] [diff] [review]
1366757-v1.patch
Attachment #8870025 - Flags: review?(franziskuskiefer)
(Assignee)

Comment 2

6 months ago
Created attachment 8870027 [details] [diff] [review]
nss-3.28-1366757-v1.patch

I'd also like to land this patch on the NSS 3.28 branch, which is our current long lived branch for Firefox ESR 52.x, and which currently uses NSPR 4.13.1

Comment 3

6 months ago
Comment on attachment 8870025 [details] [diff] [review]
1366757-v1.patch

Review of attachment 8870025 [details] [diff] [review]:
-----------------------------------------------------------------

This is a good plan.

::: automation/release/min-required-nspr-version
@@ +1,1 @@
> +4.15

I'd name this nspr-version.txt
Attachment #8870025 - Flags: feedback+
Comment on attachment 8870025 [details] [diff] [review]
1366757-v1.patch

Review of attachment 8870025 [details] [diff] [review]:
-----------------------------------------------------------------

Thanks, that's great.
A shorter/nicer name for the version file would be nice.
Attachment #8870025 - Flags: review?(franziskuskiefer) → review+
(Assignee)

Comment 5

6 months ago
renamed

trunk for 3.31:
https://hg.mozilla.org/projects/nss/rev/f5335ce235bc
Status: NEW → RESOLVED
Last Resolved: 6 months ago
Resolution: --- → FIXED
Target Milestone: --- → 3.31
(Assignee)

Comment 6

6 months ago
NSS_3_28_BRANCH:
https://hg.mozilla.org/projects/nss/rev/ce6c481bdf75
You need to log in before you can comment on or make changes to this bug.