136678 - byte range request fails if server returns anything other than a 206

Status: VERIFIED FIXED

(Core :: Networking: HTTP, defect, P1)

Description

[Darin Fisher]

i forgot a very crucial step when i wrote the patch for bug 116365.

if after issuing a byte range request, we receive anything other than a 206
response, the document load appears to stall.  in actual fact, we end up
buffering the downloaded data in preparation for appending it to the partial
cache entry.  but, since we never kick off the AsyncRead of the cache entry, we
never resume processing the downloaded data.  as a result the cache entry for
the document never closes and future requests for the document always fail (get
stuck waiting for access to the cache entry).

i noticed this problem while browsing the other day and was fortunately
capturing a HTTP log for another bug at the same time.

the fix is really trivial and IMO is an absolutely required for mozilla 1.0

Comment 1

[Darin Fisher]

Attachment: patch

Comment 2

[rpotts (gone)]

Comment on attachment 78586 [details] [diff] [review]
patch

sr=[e-mail]

Comment 3

[Asa Dotzler [:asa]]

Comment on attachment 78586 [details] [diff] [review]
patch

a=asa (on behalf of drivers) for checkin to the 1.0 branch

Comment 4

[Jaime Rodriguez, Jr.]

adt1.0.0+ (on ADT's behalf) approval for checkin to the 1.0 branch. Pls check
this into the trunk and 1.0 branch today.

Comment 5

[Darin Fisher]

fixed-on-trunk
fixed-on-branch

Comment 6

[Tom Everingham]

verified - 04/11/02 branch and trunk, all platforms

Comment 7

[Asa Dotzler [:asa]]

adding verified1.0.0 keyword (branch verification) based on bonsai checkin and
QA comments.