1366784 - After a connection loss during quit/restart Marionette has to kill Firefox

Status: RESOLVED FIXED

(Remote Protocol :: Marionette, defect)

Description

[Henrik Skupin [:whimboo][⌚️UTC+1]]

With the patch on bug 1298803 landed we hit a condition which left the test job in a hanging state. The test requested that no more new connection attempts should be made because the sendKeys command should quit Firefox. Sadly the shortcut didn't work and as such Firefox stayed open.

Given that no new connections are allowed no other test was able to connect to Firefox. As such the job got killed after 360s, but the process stayed alive.

The result of this is that test machines were left unusable. :(

Comment 1

[Henrik Skupin [:whimboo][⌚️UTC+1]]

Attachment: Bug 1366784 - Force quit the application if requested quit or restart doesn't happen.

In case a quit or restart is requested, but eg. the in_app
callback doesn't really trigger a shutdown of the application,
Marionette has to force close it after the default shutdown
timeout.

This is necessary because "acceptConnections" is set to false
and no further connection could be made to the still running
application.

Review commit: https://reviewboard.mozilla.org/r/147142/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/147142/

Comment 2

[Maja Frydrychowicz :impossibus (was :maja_zf) (needinfo me)]

Comment on attachment 8875713 [details]
Bug 1366784 - Force quit the application if requested quit or restart doesn't happen.

https://reviewboard.mozilla.org/r/147142/#review151342

Great addition. Thanks, whimboo.

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/b30457bfb195
Force quit the application if requested quit or restart doesn't happen. r=maja_zf

Comment 4

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/b30457bfb195