1366791 - browser_ext_geckoProfiler_symbolicate.js does not wait for preferences to be set

Status: RESOLVED FIXED

(Core :: Gecko Profiler, defect)

Description

[Ben Kelly [:bkelly, not reviewing]]

This test flips some prefs necessary to test the gecko profiler:

https://dxr.mozilla.org/mozilla-central/source/browser/components/extensions/test/browser/browser_ext_geckoProfiler_symbolicate.js

Unfortunately, though, it does not actually wait for the prefs to be written before proceeding.  This causes some failures with my patches in bug 1363829 since things run slightly faster.

Comment 1

[Ben Kelly [:bkelly, not reviewing]]

Attachment: Make browser_ext_geckoProfiler_symbolicate.js wait for prefs to be written. r=mstange

Please see comment 0 for a description of the problem.  Basically we just need to yield until pushPrefEnv() completes writing the preferences.

Comment 2

[Markus Stange [:mstange]]

Comment on attachment 8870055 [details] [diff] [review]
Make browser_ext_geckoProfiler_symbolicate.js wait for prefs to be written. r=mstange

Review of attachment 8870055 [details] [diff] [review]:
-----------------------------------------------------------------

thanks

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c96cb8ecabf
Make browser_ext_geckoProfiler_symbolicate.js wait for prefs to be written. r=mstange

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/1c96cb8ecabf