browser_ext_geckoProfiler_symbolicate.js does not wait for preferences to be set

RESOLVED FIXED in Firefox 55

Status

()

Core
Gecko Profiler
RESOLVED FIXED
a year ago
a year ago

People

(Reporter: bkelly, Assigned: bkelly)

Tracking

unspecified
mozilla55
Points:
---
Bug Flags:
in-testsuite +

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

(Assignee)

Description

a year ago
This test flips some prefs necessary to test the gecko profiler:

https://dxr.mozilla.org/mozilla-central/source/browser/components/extensions/test/browser/browser_ext_geckoProfiler_symbolicate.js

Unfortunately, though, it does not actually wait for the prefs to be written before proceeding.  This causes some failures with my patches in bug 1363829 since things run slightly faster.
(Assignee)

Comment 1

a year ago
Created attachment 8870055 [details] [diff] [review]
Make browser_ext_geckoProfiler_symbolicate.js wait for prefs to be written. r=mstange

Please see comment 0 for a description of the problem.  Basically we just need to yield until pushPrefEnv() completes writing the preferences.
Attachment #8870055 - Flags: review?(mstange)
Comment on attachment 8870055 [details] [diff] [review]
Make browser_ext_geckoProfiler_symbolicate.js wait for prefs to be written. r=mstange

Review of attachment 8870055 [details] [diff] [review]:
-----------------------------------------------------------------

thanks
Attachment #8870055 - Flags: review?(mstange) → review+

Comment 3

a year ago
Pushed by bkelly@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/1c96cb8ecabf
Make browser_ext_geckoProfiler_symbolicate.js wait for prefs to be written. r=mstange

Comment 4

a year ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/1c96cb8ecabf
Status: ASSIGNED → RESOLVED
Last Resolved: a year ago
status-firefox55: --- → fixed
Flags: in-testsuite+
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.