1366827 - Allow webextension experiments on release

Status: RESOLVED FIXED

(WebExtensions :: Experiments, enhancement)

Description

[Andrew Swan [:aswan]]

The main Test Pilot extension and individual Test Pilot experiments are in the process of moving away from the Add-on SDK.  The goal is to use webextension experiments, but of course they'll need those to be usable on release.

If we land this change in 55, then AMO-signed experiments could theoretically run on release in 55 and 56 but only admins can sign experiments with the AMO CA.  Beginning in 57, only experiments signed with "Mozilla Extensions" will be installable.

Comment 1

[Andrew Swan [:aswan]]

Jared, should I re-assign this one to you?

Comment 2

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Yeah! Let's do it

Comment 3

[Andrew Swan [:aswan]]

There are a few places where we just need to remove existing RELEASE_OR_BETA checks:
http://searchfox.org/mozilla-central/rev/1a0d9545b9805f50a70de703a3c04fc0d22e3839/toolkit/mozapps/extensions/internal/XPIInstall.jsm#160-162
http://searchfox.org/mozilla-central/rev/972b7a5149bbb2eaab48aafa87678c33d5f2f045/toolkit/mozapps/extensions/internal/XPIProvider.jsm#257-258
http://searchfox.org/mozilla-central/rev/972b7a5149bbb2eaab48aafa87678c33d5f2f045/toolkit/components/extensions/ExtensionParent.jsm#71-73

And then tests that we need to not skip on release/beta:
A couple of instances in toolkit/mozapps/extensions/test/xpcshell/test_webextension.js
The skip-if clauses in .ini files in toolkit/components/extensions/test/xpcshell

Comment 4

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Attachment: Bug 1366827 - Enable WebExtension experiments in Beta and Release.

Review commit: https://reviewboard.mozilla.org/r/145312/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/145312/

Comment 5

[Andrew Swan [:aswan]]

Comment on attachment 8873938 [details]
Bug 1366827 - Enable WebExtension experiments in Beta and Release.

https://reviewboard.mozilla.org/r/145312/#review149290

r=me with the comments addressed

::: toolkit/mozapps/extensions/internal/XPIInstall.jsm:160
(Diff revision 1)
>    dictionary: 64,
>    experiment: 128,
>  };
>  
> -if (!AppConstants.RELEASE_OR_BETA)
> -   TYPES.apiextension = 256;
> +TYPES.apiextension = 256;

you can now just put this in the declaration above

::: toolkit/mozapps/extensions/internal/XPIProvider.jsm:257
(Diff revision 1)
>    dictionary: 64,
>    experiment: 128,
>  };
>  
> -if (!AppConstants.RELEASE_OR_BETA)
> -  TYPES.apiextension = 256;
> +TYPES.apiextension = 256;

ditto the previous comment

Comment 6

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 8873938 [details]
Bug 1366827 - Enable WebExtension experiments in Beta and Release.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145312/diff/1-2/

Comment 7

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Comment on attachment 8873938 [details]
Bug 1366827 - Enable WebExtension experiments in Beta and Release.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/145312/diff/2-3/

Comment 8

[Jared Hirsch [:jhirsch] (he/him) (Needinfo please)]

Tests are green: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d4e30078f6e9b0193eb4d960483c40c1f08dd07e

Setting checkin-needed

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/d62f6dc68c5f
Enable WebExtension experiments in Beta and Release. r=aswan

Comment 10

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/d62f6dc68c5f