Allow webextension experiments on release

RESOLVED FIXED in Firefox 55

Status

enhancement
RESOLVED FIXED
2 years ago
11 months ago

People

(Reporter: aswan, Assigned: _6a68)

Tracking

unspecified
mozilla55

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment)

Reporter

Description

2 years ago
The main Test Pilot extension and individual Test Pilot experiments are in the process of moving away from the Add-on SDK.  The goal is to use webextension experiments, but of course they'll need those to be usable on release.

If we land this change in 55, then AMO-signed experiments could theoretically run on release in 55 and 56 but only admins can sign experiments with the AMO CA.  Beginning in 57, only experiments signed with "Mozilla Extensions" will be installable.
Reporter

Comment 1

2 years ago
Jared, should I re-assign this one to you?
Flags: needinfo?(jhirsch)
Yeah! Let's do it
Flags: needinfo?(jhirsch)
Reporter

Updated

2 years ago
Assignee: aswan → jhirsch
Reporter

Comment 3

2 years ago
There are a few places where we just need to remove existing RELEASE_OR_BETA checks:
http://searchfox.org/mozilla-central/rev/1a0d9545b9805f50a70de703a3c04fc0d22e3839/toolkit/mozapps/extensions/internal/XPIInstall.jsm#160-162
http://searchfox.org/mozilla-central/rev/972b7a5149bbb2eaab48aafa87678c33d5f2f045/toolkit/mozapps/extensions/internal/XPIProvider.jsm#257-258
http://searchfox.org/mozilla-central/rev/972b7a5149bbb2eaab48aafa87678c33d5f2f045/toolkit/components/extensions/ExtensionParent.jsm#71-73

And then tests that we need to not skip on release/beta:
A couple of instances in toolkit/mozapps/extensions/test/xpcshell/test_webextension.js
The skip-if clauses in .ini files in toolkit/components/extensions/test/xpcshell
Reporter

Comment 5

2 years ago
mozreview-review
Comment on attachment 8873938 [details]
Bug 1366827 - Enable WebExtension experiments in Beta and Release.

https://reviewboard.mozilla.org/r/145312/#review149290

r=me with the comments addressed

::: toolkit/mozapps/extensions/internal/XPIInstall.jsm:160
(Diff revision 1)
>    dictionary: 64,
>    experiment: 128,
>  };
>  
> -if (!AppConstants.RELEASE_OR_BETA)
> -   TYPES.apiextension = 256;
> +TYPES.apiextension = 256;

you can now just put this in the declaration above

::: toolkit/mozapps/extensions/internal/XPIProvider.jsm:257
(Diff revision 1)
>    dictionary: 64,
>    experiment: 128,
>  };
>  
> -if (!AppConstants.RELEASE_OR_BETA)
> -  TYPES.apiextension = 256;
> +TYPES.apiextension = 256;

ditto the previous comment
Attachment #8873938 - Flags: review?(aswan) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 9

2 years ago
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/d62f6dc68c5f
Enable WebExtension experiments in Beta and Release. r=aswan
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/d62f6dc68c5f
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55

Updated

11 months ago
Product: Toolkit → WebExtensions
You need to log in before you can comment on or make changes to this bug.