Add 64-bit minimum memory requirement check in stub installer

VERIFIED FIXED in Firefox 55

Status

()

enhancement
VERIFIED FIXED
2 years ago
2 years ago

People

(Reporter: cpeterson, Assigned: mhowell)

Tracking

(Blocks 1 bug)

unspecified
Firefox 55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox53 wontfix, firefox54 wontfix, firefox55 verified)

Details

Attachments

(1 attachment)

Reporter

Description

2 years ago
We had a stub installer check for a 64-bit minimum memory requirement before. We should resurrect that.

For now the minimum can just be 2 GB, which covers 99% of Win64 OS users (because 2 GB is Microsoft's minimum memory requirement for Win64 OS itself). If we need to add a 4 GB requirement later, it will be easier to change "2" to "4" than to uplift all the stub installer code to check memory.
Reporter

Comment 1

2 years ago
For now, we don't need a minimum memory check in the 64-bit full installer. If a user went out of their way to download the 64-bit full installer, we should probably give it to them.
Comment on attachment 8870543 [details]
Bug 1366860 - Require a minimum amount of RAM to get a 64-bit build from the stub installer.

https://reviewboard.mozilla.org/r/141998/#review145802

Looks good!
Attachment #8870543 - Flags: review?(robert.strong.bugs) → review+

Comment 4

2 years ago
Pushed by mhowell@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/615b7a5a2568
Require a minimum amount of RAM to get a 64-bit build from the stub installer. r=rstrong

Comment 5

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/615b7a5a2568
Status: NEW → RESOLVED
Last Resolved: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Blocks: 1367070
Verified as fixed. 
This bug is verified by Grover while testing "Streamlined Stub Installer".
Test runs are here:https://testrail.stage.mozaws.net/index.php?/runs/view/4419 
Needinfo me if you have feedback or questions.
Status: RESOLVED → VERIFIED
Reporter

Updated

2 years ago
Depends on: 1390253
You need to log in before you can comment on or make changes to this bug.