1366882 - Fix some resource leaks

Status: RESOLVED FIXED

(Developer Infrastructure :: Source Code Analysis, enhancement)

Comment 1

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1366882 - Fix a resource leak - CID 1402588

Review commit: https://reviewboard.mozilla.org/r/141608/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141608/

Comment 2

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1366882 - Fix a resource leak - CID 1213977 -

Review commit: https://reviewboard.mozilla.org/r/141610/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141610/

Comment 3

[Sylvestre Ledru [:Sylvestre]]

Attachment: hg logBug 1366882 - fix resource leaks CID 1401664 1401662 1401661

Review commit: https://reviewboard.mozilla.org/r/141612/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141612/

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Attachment: Bug 1366882 - Fix a resource leak - CID 221217 -

Review commit: https://reviewboard.mozilla.org/r/141618/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/141618/

Comment 5

[Nicholas Nethercote [inactive]]

Comment on attachment 8870172 [details]
hg logBug 1366882 - fix resource leaks CID 1401664 1401662 1401661

https://reviewboard.mozilla.org/r/141612/#review145286

This works, but it would be even better if you changed each |pb| to a |UniquePtr<ProfileBuffer>|, and then the explicit |delete| statements wouldn't be necessary. r=me with that. Thanks!

Comment 6

[Eric Rahm [:erahm]]

Comment on attachment 8870170 [details]
Bug 1366882 - Fix a resource leak - CID 1402588

https://reviewboard.mozilla.org/r/141608/#review145292

::: extensions/auth/nsHttpNegotiateAuth.cpp:548
(Diff revision 1)
>          //
>          nsresult rv =
>              Base64Decode(challenge, len, (char**)&inToken, &inTokenLen);
>  
>          if (NS_FAILED(rv)) {
> +            free(inToken);

In the failed case `inToken` can point to invalid memory, we don't want to free it. `Base64Decode` will only set the buffer on success [1].

[1] http://searchfox.org/mozilla-central/rev/6c2dbacbba1d58b8679cee700fd0a54189e0cf1b/xpcom/io/Base64.cpp#439

Comment 7

[Nathan Froyd [:froydnj]]

Comment on attachment 8870171 [details]
Bug 1366882 - Fix a resource leak - CID 1213977 -

https://reviewboard.mozilla.org/r/141610/#review145520

Comment 8

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8870170 [details]
Bug 1366882 - Fix a resource leak - CID 1402588

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141608/diff/1-2/

Comment 9

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8870171 [details]
Bug 1366882 - Fix a resource leak - CID 1213977 -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141610/diff/1-2/

Comment 10

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8870172 [details]
hg logBug 1366882 - fix resource leaks CID 1401664 1401662 1401661

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141612/diff/1-2/

Comment 11

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8870178 [details]
Bug 1366882 - Fix a resource leak - CID 221217 -

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/141618/diff/1-2/

Comment 12

[Eric Rahm [:erahm]]

Comment on attachment 8870170 [details]
Bug 1366882 - Fix a resource leak - CID 1402588

https://reviewboard.mozilla.org/r/141608/#review146106

Looks good.

Comment 13

[(not currently active) Ted Mielczarek]

Comment on attachment 8870178 [details]
Bug 1366882 - Fix a resource leak - CID 221217 -

https://reviewboard.mozilla.org/r/141618/#review150876

Comment 14

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/021d3649e2fc
Fix a resource leak - CID 1402588 r=erahm
https://hg.mozilla.org/integration/autoland/rev/365687db6288
Fix a resource leak - CID 1213977 - r=froydnj
https://hg.mozilla.org/integration/autoland/rev/2ec004b70daa
hg logBug 1366882 - fix resource leaks CID 1401664 1401662 1401661 r=njn
https://hg.mozilla.org/integration/autoland/rev/4b380c4484ba
Fix a resource leak - CID 221217 - r=ted

Comment 15

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2ec004b70daa

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/021d3649e2fc
https://hg.mozilla.org/mozilla-central/rev/365687db6288
https://hg.mozilla.org/mozilla-central/rev/4b380c4484ba