Closed Bug 1366932 Opened 3 years ago Closed 3 years ago

Add preference for JavaScript context heap size of PAC

Categories

(Core :: Networking, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: xeonchen, Assigned: xeonchen)

References

Details

(Whiteboard: [necko-active][proxy])

Attachments

(1 file)

We have some bugs (bug 1250776, bug 1346183) related to JavaScript context heap size, in order to let user test this more efficiently in the future, it's time to make this adjustable in about:config.
The new preference can be the heap size we want to increase, so that we can make sure user don't accidentally break it by setting the value to 0.
(In reply to Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz) from comment #1)
> The new preference can be the heap size we want to increase, so that we can
> make sure user don't accidentally break it by setting the value to 0.

We should not accept negative values here, either. \o/
Comment on attachment 8871202 [details]
Bug 1366932 - support extra JS context heap size pref for PAC;

https://reviewboard.mozilla.org/r/142692/#review146912

LGTM!
Attachment #8871202 - Flags: review?(daniel) → review+
Keywords: checkin-needed
Pushed by gachen@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/208eb19a2a1e
support extra JS context heap size pref for PAC; r=bagder
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/208eb19a2a1e
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Depends on: 1547977
You need to log in before you can comment on or make changes to this bug.