1366932 - Add preference for JavaScript context heap size of PAC

Status: RESOLVED FIXED

(Core :: Networking, enhancement)

Description

[Gary Chen [:xeonchen]]

We have some bugs (bug 1250776, bug 1346183) related to JavaScript context heap size, in order to let user test this more efficiently in the future, it's time to make this adjustable in about:config.

Comment 1

[Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz)]

The new preference can be the heap size we want to increase, so that we can make sure user don't accidentally break it by setting the value to 0.

Comment 2

[Gary Chen [:xeonchen]]

(In reply to Shih-Chiang Chien [:schien] (UTC+8) (use ni? plz) from comment #1)
> The new preference can be the heap size we want to increase, so that we can
> make sure user don't accidentally break it by setting the value to 0.

We should not accept negative values here, either. \o/

Comment 3

[Gary Chen [:xeonchen]]

Attachment: Bug 1366932 - support extra JS context heap size pref for PAC;

Review commit: https://reviewboard.mozilla.org/r/142692/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142692/

Comment 4

[Daniel Stenberg [:bagder]]

Comment on attachment 8871202 [details]
Bug 1366932 - support extra JS context heap size pref for PAC;

https://reviewboard.mozilla.org/r/142692/#review146912

LGTM!

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/208eb19a2a1e
support extra JS context heap size pref for PAC; r=bagder

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/208eb19a2a1e