1366984 - Fix image container check for background image layer

Status: RESOLVED FIXED

(Core :: Graphics: WebRender, enhancement)

Description

[Ethan Lin[:ethlin]]

There is a reftest "layout/reftests/image-rect/background-common-usage-floating-point.html" has this kind problem. There is no image container but we still try to use webrender to render it.

Comment 1

[Ethan Lin[:ethlin]]

Attachment: Fix image check

The main change is that I added GetCropRect() for checking since it will make the image container unavailable. I also changed the checks order to make them more readable.

Comment 2

[Ethan Lin[:ethlin]]

try result:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=4e079cb055d51c5e2f5739736af5502c48afa519&selectedJob=103252796

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/14a2665a64f6
Fix image container check for background image layer. r=mattwoodrow

Comment 4

[Joel Maher ( :jmaher ) (UTC -8)]

this is causing talos to be unreliable and fail often, specifically the g1 and s jobs on linux and windows.  Please look into this or back this out so we can have reliable test results.

Comment 5

[Joel Maher ( :jmaher ) (UTC -8)]

actually perma fail for g1, we should back this out.

Comment 6

[Ethan Lin[:ethlin]]

Strange. The changes should be for webrender only. I don't think the talos test will run into that function.

Comment 7

[Pulsebot]

Backout by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/118e1c11be5c
Backed out changeset 14a2665a64f6 for causing Windows Talos failures on a CLOSED TREE.

Comment 8

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/mozilla-central/rev/5ca156581096
Fix image container check for background image layer. r=mattwoodrow

Comment 9

[Ryan VanderMeulen [:RyanVM]]

Wasn't your fault after all! Re-landed.
https://hg.mozilla.org/mozilla-central/rev/5ca156581096