Closed Bug 1366984 Opened 3 years ago Closed 3 years ago
Fix image container check for background image layer
There is a reftest "layout/reftests/image-rect/background-common-usage-floating-point.html" has this kind problem. There is no image container but we still try to use webrender to render it.
The main change is that I added GetCropRect() for checking since it will make the image container unavailable. I also changed the checks order to make them more readable.
Attachment #8870340 - Flags: review?(matt.woodrow)
Attachment #8870340 - Flags: review?(matt.woodrow) → review+
Pushed by email@example.com: https://hg.mozilla.org/integration/mozilla-inbound/rev/14a2665a64f6 Fix image container check for background image layer. r=mattwoodrow
this is causing talos to be unreliable and fail often, specifically the g1 and s jobs on linux and windows. Please look into this or back this out so we can have reliable test results.
actually perma fail for g1, we should back this out.
Strange. The changes should be for webrender only. I don't think the talos test will run into that function.
Backout by firstname.lastname@example.org: https://hg.mozilla.org/integration/mozilla-inbound/rev/118e1c11be5c Backed out changeset 14a2665a64f6 for causing Windows Talos failures on a CLOSED TREE.
Pushed by email@example.com: https://hg.mozilla.org/mozilla-central/rev/5ca156581096 Fix image container check for background image layer. r=mattwoodrow
Wasn't your fault after all! Re-landed. https://hg.mozilla.org/mozilla-central/rev/5ca156581096
You need to log in before you can comment on or make changes to this bug.