Closed Bug 1367097 Opened 8 years ago Closed 8 years ago

Update overflow panel height when removing items from it

Categories

(Firefox :: Toolbars and Customization, enhancement)

Product:
Firefox
Component:
Toolbars and Customization
Version:
53 Branch
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED WORKSFORME

People

(Reporter: Gijs, Unassigned)

References

Details

In bug 1354078 Brian noticed that the panel doesn't shrink if we remove items outside of customize mode (using the context menu). This also happens in the main hamburger panel today, so it doesn't need to block that bug, but ideally we should try to fix it for Photon given that it is more noticeable in the overflow panel than it was in the hamburger panel (because quite often if you remove things, you don't necessarily create an empty row that could be collapsed to shrink the panel).
Flags: qe-verify+
Priority: -- → P2
Whiteboard: [photon-structure] → [photon-structure] [triage]
Whiteboard: [photon-structure] [triage] → [photon-structure]
(In reply to :Gijs from comment #0) > This also happens in the main hamburger panel today I think this may have been fixed for the non-Photon case by bug 1009116.
(In reply to :Paolo Amadini from comment #1) > (In reply to :Gijs from comment #0) > > This also happens in the main hamburger panel today > > I think this may have been fixed for the non-Photon case by bug 1009116. Ah, but this fixes it for the overflow panel, too, then, which means this is probably WFM? Would have to check with the patches from bug 1354078 on top of current nightly.
Doing "Remove from Toolbar" seems to work correctly while leaving the pane open. "Unpin" closes the panel.
(In reply to :Paolo Amadini from comment #3) > Doing "Remove from Toolbar" seems to work correctly while leaving the pane > open. "Unpin" closes the panel. I can't reproduce this - we close the panel if you remove the last item because there's no point keeping it open, and in fact because we remove the anchor, the popup code then moves the (now empty) panel and all kinds of crazy things happen. So instead we just force-close the panel. I suspect this is what you were seeing. In my testing, this now works correctly, so perhaps we can close as WFM? :-)
Flags: needinfo?(paolo.mozmail)
Sounds like so.
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(paolo.mozmail)
Resolution: --- → WORKSFORME
Flags: qe-verify+
Priority: P2 → --
QA Contact: gwimberly
Whiteboard: [photon-structure]
You need to log in before you can comment on or make changes to this bug.