Closed Bug 1367150 Opened 7 years ago Closed 7 years ago

PContentChild::SendPPresentationConstructor asserts during shutdown

Categories

(Core :: DOM: Core & HTML, defect)

Product:
Core
Component:
DOM: Core & HTML
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: aosmond, Assigned: aosmond)

Details

Attachments

(1 file)

Do not create PresentationChild if ContentChild is shutting down, v1
1.01 KB, patch
ehsan.akhgari
: review+
Details | Diff | Splinter Review 
See https://treeherder.mozilla.org/logviewer.html#?job_id=101234678&repo=try&lineNumber=2036.

Relevant stack trace from the log is:

[task 2017-05-23T15:31:17.202995Z] 15:31:17     INFO -  Crash reason:  SIGSEGV
[task 2017-05-23T15:31:17.203329Z] 15:31:17     INFO -  Crash address: 0x0
[task 2017-05-23T15:31:17.203380Z] 15:31:17     INFO -  Process uptime: not available
[task 2017-05-23T15:31:17.203678Z] 15:31:17     INFO -  Thread 10 (crashed)
[task 2017-05-23T15:31:17.203737Z] 15:31:17     INFO -   0  libmozglue.so!mozalloc_abort [mozalloc_abort.cpp:5946cdb548d0 : 33 + 0x8]
[task 2017-05-23T15:31:17.203817Z] 15:31:17     INFO -       r0 = 0x00000066    r1 = 0xe9bfbc6f    r2 = 0xe9bfbc6f    r3 = 0x00000000
[task 2017-05-23T15:31:17.203875Z] 15:31:17     INFO -       r4 = 0x5280d460    r5 = 0x00000003    r6 = 0x4006f1c4    r7 = 0x5280d460
[task 2017-05-23T15:31:17.203929Z] 15:31:17     INFO -       r8 = 0x5280d260    r9 = 0x55980b0c   r10 = 0x00000000   r12 = 0x00000003
[task 2017-05-23T15:31:17.204003Z] 15:31:17     INFO -       fp = 0x52a16488    sp = 0x5280d220    lr = 0x528224b1    pc = 0x5282256e
[task 2017-05-23T15:31:17.204052Z] 15:31:17     INFO -      Found by: given as instruction pointer in context
[task 2017-05-23T15:31:17.204123Z] 15:31:17     INFO -   1  libxul.so!NS_DebugBreak [nsDebugImpl.cpp:5946cdb548d0 : 451 + 0x5]
[task 2017-05-23T15:31:17.204180Z] 15:31:17     INFO -       r4 = 0x4006f11c    r5 = 0x00000003    r6 = 0x4006f1c4    r7 = 0x5280d460
[task 2017-05-23T15:31:17.204233Z] 15:31:17     INFO -       r8 = 0x5280d260    r9 = 0x55980b0c   r10 = 0x00000000    fp = 0x52a16488
[task 2017-05-23T15:31:17.204294Z] 15:31:17     INFO -       sp = 0x5280d228    pc = 0x530b76d7
[task 2017-05-23T15:31:17.204332Z] 15:31:17     INFO -      Found by: call frame info
[task 2017-05-23T15:31:17.204387Z] 15:31:17     INFO -   2  libxul.so!mozilla::ipc::FatalError [ProtocolUtils.cpp:5946cdb548d0 : 304 + 0x13]
[task 2017-05-23T15:31:17.204460Z] 15:31:17     INFO -       r4 = 0x5280d6a4    r5 = 0x00000000    r6 = 0x00000000    r7 = 0x55985c62
[task 2017-05-23T15:31:17.204518Z] 15:31:17     INFO -       r8 = 0x559baebd    r9 = 0xffffffff   r10 = 0x00000000    fp = 0x5280d7e8
[task 2017-05-23T15:31:17.204558Z] 15:31:17     INFO -       sp = 0x5280d680    pc = 0x5338c403
[task 2017-05-23T15:31:17.204613Z] 15:31:17     INFO -      Found by: call frame info
[task 2017-05-23T15:31:17.204684Z] 15:31:17     INFO -   3  libxul.so!mozilla::dom::PContentChild::SendPPresentationConstructor [PContentChild.cpp:5946cdb548d0 : 1986 + 0x5]
[task 2017-05-23T15:31:17.204759Z] 15:31:17     INFO -       r4 = 0x00000000    r5 = 0x52a2d810    r6 = 0x00000000    r7 = 0x5280d728
[task 2017-05-23T15:31:17.204817Z] 15:31:17     INFO -       r8 = 0x5280d724    r9 = 0x55f47250   r10 = 0x00000000    fp = 0x5280d7e8
[task 2017-05-23T15:31:17.204856Z] 15:31:17     INFO -       sp = 0x5280d718    pc = 0x5351caef
[task 2017-05-23T15:31:17.204910Z] 15:31:17     INFO -      Found by: call frame info
[task 2017-05-23T15:31:17.204984Z] 15:31:17     INFO -   4  libxul.so!mozilla::dom::PresentationIPCService::PresentationIPCService [PresentationIPCService.cpp:5946cdb548d0 : 43 + 0x3]
[task 2017-05-23T15:31:17.205058Z] 15:31:17     INFO -       r4 = 0x6397a680    r5 = 0x55ba6fc1    r6 = 0x630b8ac0    r7 = 0x52a2d810
[task 2017-05-23T15:31:17.205115Z] 15:31:17     INFO -       r8 = 0x5280d7a0    r9 = 0x55f47250   r10 = 0x00000000    fp = 0x5280d7e8
[task 2017-05-23T15:31:17.205154Z] 15:31:17     INFO -       sp = 0x5280d748    pc = 0x542ae7df
[task 2017-05-23T15:31:17.205189Z] 15:31:17     INFO -      Found by: call frame info
[task 2017-05-23T15:31:17.205267Z] 15:31:17     INFO -   5  libxul.so!NS_CreatePresentationService [PresentationService.cpp:5946cdb548d0 : 1180 + 0x3]
[task 2017-05-23T15:31:17.205325Z] 15:31:17     INFO -       r3 = 0x52900ac0    r4 = 0x5280d764    r5 = 0x6397a680    r6 = 0x5280d784
[task 2017-05-23T15:31:17.205378Z] 15:31:17     INFO -       r7 = 0x559040c4    r8 = 0x5280d7a0    r9 = 0x55f47250   r10 = 0x00000000
[task 2017-05-23T15:31:17.205423Z] 15:31:17     INFO -       fp = 0x5280d7e8    sp = 0x5280d760    pc = 0x542a2523
[task 2017-05-23T15:31:17.205458Z] 15:31:17     INFO -      Found by: call frame info
[task 2017-05-23T15:31:17.205537Z] 15:31:17     INFO -   6  libxul.so!nsIPresentationServiceConstructor [nsLayoutModule.cpp:5946cdb548d0 : 295 + 0x5]
[task 2017-05-23T15:31:17.205595Z] 15:31:17     INFO -       r4 = 0x530f714d    r5 = 0x5280d7e4    r6 = 0x55f47250    r7 = 0x559040c4
[task 2017-05-23T15:31:17.205712Z] 15:31:17     INFO -       r8 = 0x5280d7a0    r9 = 0x55f47250   r10 = 0x00000000    fp = 0x5280d7e8
[task 2017-05-23T15:31:17.205845Z] 15:31:17     INFO -       sp = 0x5280d780    pc = 0x5460cb2f
[task 2017-05-23T15:31:17.205989Z] 15:31:17     INFO -      Found by: call frame info
[task 2017-05-23T15:31:17.206226Z] 15:31:17     INFO -   7  libxul.so!nsComponentManagerImpl::CreateInstanceByContractID [nsComponentManager.cpp:5946cdb548d0 : 1104 + 0x9]
[task 2017-05-23T15:31:17.206415Z] 15:31:17     INFO -       r4 = 0x530f714d    r5 = 0x5280d7e4    r6 = 0x55b7add4    r7 = 0x559040c4
[task 2017-05-23T15:31:17.206649Z] 15:31:17     INFO -       r8 = 0x5280d7a0    r9 = 0x55f47250   r10 = 0x00000000    fp = 0x5280d7e8
[task 2017-05-23T15:31:17.206829Z] 15:31:17     INFO -       sp = 0x5280d798    pc = 0x530f9eaf
[task 2017-05-23T15:31:17.207033Z] 15:31:17     INFO -      Found by: call frame info
[task 2017-05-23T15:31:17.207267Z] 15:31:17     INFO -   8  libxul.so!nsComponentManagerImpl::GetServiceByContractID [nsComponentManager.cpp:5946cdb548d0 : 1461 + 0xd]
[task 2017-05-23T15:31:17.207460Z] 15:31:17     INFO -       r4 = 0x62019600    r5 = 0x5280d7e4    r6 = 0x52a1f120    r7 = 0x5280d7f4
[task 2017-05-23T15:31:17.207689Z] 15:31:17     INFO -       r8 = 0x52a16080    r9 = 0x52a1f1b0   r10 = 0x55f47250    fp = 0x5280d7e8
[task 2017-05-23T15:31:17.207870Z] 15:31:17     INFO -       sp = 0x5280d7c8    pc = 0x530fb347
[task 2017-05-23T15:31:17.208099Z] 15:31:17     INFO -      Found by: call frame info
[task 2017-05-23T15:31:17.208397Z] 15:31:17     INFO -   9  libxul.so!nsGetServiceByContractID::operator() [nsComponentManagerUtils.cpp:5946cdb548d0 : 280 + 0x5]
[task 2017-05-23T15:31:17.208598Z] 15:31:17     INFO -       r4 = 0x5280d834    r5 = 0x00000000    r6 = 0x6347e100    r7 = 0x00000000
[task 2017-05-23T15:31:17.208933Z] 15:31:17     INFO -       r8 = 0x5280d87c    r9 = 0x5280d8b8   r10 = 0x00000005    fp = 0x00000000
[task 2017-05-23T15:31:17.209197Z] 15:31:17     INFO -       sp = 0x5280d828    pc = 0x530fb5c3
[task 2017-05-23T15:31:17.209454Z] 15:31:17     INFO -      Found by: call frame info
[task 2017-05-23T15:31:17.209761Z] 15:31:17     INFO -  10  libxul.so!nsCOMPtr<nsIPresentationService>::nsCOMPtr [nsCOMPtr.h:5946cdb548d0 : 1162 + 0xd]
[task 2017-05-23T15:31:17.210074Z] 15:31:17     INFO -       r4 = 0x5280d854    r5 = 0x00000000    r6 = 0x6347e100    r7 = 0x00000000
[task 2017-05-23T15:31:17.210376Z] 15:31:17     INFO -       r8 = 0x5280d87c    r9 = 0x5280d8b8   r10 = 0x00000005    fp = 0x00000000
[task 2017-05-23T15:31:17.210562Z] 15:31:17     INFO -       sp = 0x5280d830    pc = 0x542a1725
[task 2017-05-23T15:31:17.210983Z] 15:31:17     INFO -      Found by: call frame info
[task 2017-05-23T15:31:17.211146Z] 15:31:17     INFO -  11  libxul.so!mozilla::dom::PresentationReceiver::Shutdown [PresentationReceiver.cpp:5946cdb548d0 : 76 + 0x7]
[task 2017-05-23T15:31:17.211362Z] 15:31:17     INFO -       r4 = 0x5280d854    r5 = 0x019037a5    r6 = 0x6347e100    r7 = 0x00000000
[task 2017-05-23T15:31:17.211641Z] 15:31:17     INFO -       r8 = 0x5280d87c    r9 = 0x5280d8b8   r10 = 0x00000005    fp = 0x00000000
[task 2017-05-23T15:31:17.211828Z] 15:31:17     INFO -       sp = 0x5280d848    pc = 0x542a1951
[task 2017-05-23T15:31:17.212013Z] 15:31:17     INFO -      Found by: call frame info
[task 2017-05-23T15:31:17.212256Z] 15:31:17     INFO -  12  libxul.so!mozilla::dom::PresentationReceiver::~PresentationReceiver [PresentationReceiver.cpp:5946cdb548d0 : 52 + 0x3]
[task 2017-05-23T15:31:17.212450Z] 15:31:17     INFO -       r4 = 0x6347e100    r5 = 0x5280d8b4    r6 = 0x62ff0010    r7 = 0x00000000
[task 2017-05-23T15:31:17.212686Z] 15:31:17     INFO -       r8 = 0x5280d87c    r9 = 0x5280d8b8   r10 = 0x00000005    fp = 0x00000000
[task 2017-05-23T15:31:17.212868Z] 15:31:17     INFO -       sp = 0x5280d868    pc = 0x542a284f
[task 2017-05-23T15:31:17.213053Z] 15:31:17     INFO -      Found by: call frame info
[task 2017-05-23T15:31:17.213291Z] 15:31:17     INFO -  13  libxul.so!mozilla::dom::PresentationReceiver::~PresentationReceiver [PresentationReceiver.cpp:5946cdb548d0 : 53 + 0x3]
[task 2017-05-23T15:31:17.213489Z] 15:31:17     INFO -       r4 = 0x6347e100    r5 = 0x5280d8b4    r6 = 0x62ff0010    r7 = 0x00000000
[task 2017-05-23T15:31:17.213710Z] 15:31:17     INFO -       r8 = 0x5280d87c    r9 = 0x5280d8b8   r10 = 0x00000005    fp = 0x00000000
[task 2017-05-23T15:31:17.213893Z] 15:31:17     INFO -       sp = 0x5280d870    pc = 0x542a28b1
[task 2017-05-23T15:31:17.214076Z] 15:31:17     INFO -      Found by: call frame info
[task 2017-05-23T15:31:17.214300Z] 15:31:17     INFO -  14  libxul.so!SnowWhiteKiller::~SnowWhiteKiller [nsCycleCollector.cpp:5946cdb548d0 : 2651 + 0x9]
[task 2017-05-23T15:31:17.214500Z] 15:31:17     INFO -       r4 = 0x62ff0000    r5 = 0x5280d8b4    r6 = 0x62ff0010    r7 = 0x00000000
[task 2017-05-23T15:31:17.214765Z] 15:31:17     INFO -       r8 = 0x5280d87c    r9 = 0x5280d8b8   r10 = 0x00000005    fp = 0x00000000
[task 2017-05-23T15:31:17.214953Z] 15:31:17     INFO -       sp = 0x5280d878    pc = 0x530cba15
[task 2017-05-23T15:31:17.215137Z] 15:31:17     INFO -      Found by: call frame info
[task 2017-05-23T15:31:17.215362Z] 15:31:17     INFO -  15  libxul.so!nsCycleCollector::FreeSnowWhite [nsCycleCollector.cpp:5946cdb548d0 : 2825 + 0x3]
[task 2017-05-23T15:31:17.215567Z] 15:31:17     INFO -       r4 = 0x5280d8b4    r5 = 0x52a18300    r6 = 0x00000001    r7 = 0x5280d8b1
[task 2017-05-23T15:31:17.215781Z] 15:31:17     INFO -       r8 = 0x00000000    r9 = 0x52a183a0   r10 = 0x00000001    fp = 0x00000000
[task 2017-05-23T15:31:17.215967Z] 15:31:17     INFO -       sp = 0x5280d8a8    pc = 0x530cba9b
[task 2017-05-23T15:31:17.216149Z] 15:31:17     INFO -      Found by: call frame info
[task 2017-05-23T15:31:17.216365Z] 15:31:17     INFO -  16  libxul.so!AsyncFreeSnowWhite::Run [XPCJSRuntime.cpp:5946cdb548d0 : 142 + 0x3]
[task 2017-05-23T15:31:17.216564Z] 15:31:17     INFO -       r4 = 0x6203d100    r5 = 0x5280d8f8    r6 = 0x5280d978    r7 = 0x5280d8f0
[task 2017-05-23T15:31:17.216782Z] 15:31:17     INFO -       r8 = 0x5280d964    r9 = 0x5280d9d4   r10 = 0x00000001    fp = 0x00000000
[task 2017-05-23T15:31:17.216963Z] 15:31:17     INFO -       sp = 0x5280d8e8    pc = 0x535b8159
[task 2017-05-23T15:31:17.217145Z] 15:31:17     INFO -      Found by: call frame info
[task 2017-05-23T15:31:17.217369Z] 15:31:17     INFO -  17  libxul.so!mozilla::SchedulerGroup::Runnable::Run [SchedulerGroup.cpp:5946cdb548d0 : 359 + 0x3]
[task 2017-05-23T15:31:17.217566Z] 15:31:17     INFO -       r4 = 0x6201f2b4    r5 = 0x5280d958    r6 = 0x5280d978    r7 = 0x6201f2b8
[task 2017-05-23T15:31:17.217827Z] 15:31:17     INFO -       r8 = 0x5280d964    r9 = 0x5280d9d4   r10 = 0x00000001    fp = 0x00000000
[task 2017-05-23T15:31:17.218002Z] 15:31:17     INFO -       sp = 0x5280d918    pc = 0x53101855
[task 2017-05-23T15:31:17.218182Z] 15:31:17     INFO -      Found by: call frame info
[task 2017-05-23T15:31:17.218394Z] 15:31:17     INFO -  18  libxul.so!nsThread::ProcessNextEvent [nsThread.cpp:5946cdb548d0 : 1302 + 0x3]
[task 2017-05-23T15:31:17.218614Z] 15:31:17     INFO -       r4 = 0x52a860c0    r5 = 0x5280d9f4    r6 = 0x5280da10    r7 = 0x5280d9e8
[task 2017-05-23T15:31:17.218816Z] 15:31:17     INFO -       r8 = 0x00000000    r9 = 0x5280d9d4   r10 = 0x5280da5f    fp = 0x00000001
[task 2017-05-23T15:31:17.219024Z] 15:31:17     INFO -       sp = 0x5280d9b0    pc = 0x5310f79d
[task 2017-05-23T15:31:17.219202Z] 15:31:17     INFO -      Found by: call frame info
[task 2017-05-23T15:31:17.219422Z] 15:31:17     INFO -  19  libxul.so!NS_ProcessPendingEvents [nsThreadUtils.cpp:5946cdb548d0 : 335 + 0xb]
[task 2017-05-23T15:31:17.219645Z] 15:31:17     INFO -       r4 = 0x00000000    r5 = 0x52a860c0    r6 = 0xffffffff    r7 = 0x000b7794
[task 2017-05-23T15:31:17.219844Z] 15:31:17     INFO -       r8 = 0x5280da5f    r9 = 0x00000000   r10 = 0x5280daa0    fp = 0x20000009
[task 2017-05-23T15:31:17.220026Z] 15:31:17     INFO -       sp = 0x5280da58    pc = 0x5310d567
[task 2017-05-23T15:31:17.220205Z] 15:31:17     INFO -      Found by: call frame info
[task 2017-05-23T15:31:17.220415Z] 15:31:17     INFO -  20  libxul.so!mozilla::ShutdownXPCOM [XPCOMInit.cpp:5946cdb548d0 : 886 + 0x9]
[task 2017-05-23T15:31:17.220637Z] 15:31:17     INFO -       r4 = 0x5280da90    r5 = 0x5280da8c    r6 = 0x5280daa4    r7 = 0x5280da9c
[task 2017-05-23T15:31:17.220835Z] 15:31:17     INFO -       r8 = 0x00000000    r9 = 0x00000000   r10 = 0x5280daa0    fp = 0x20000009
[task 2017-05-23T15:31:17.221013Z] 15:31:17     INFO -       sp = 0x5280da78    pc = 0x5311ddd1
[task 2017-05-23T15:31:17.221190Z] 15:31:17     INFO -      Found by: call frame info
[task 2017-05-23T15:31:17.221405Z] 15:31:17     INFO -  21  libxul.so!XRE_TermEmbedding [nsEmbedFunctions.cpp:5946cdb548d0 : 225 + 0x5]
[task 2017-05-23T15:31:17.221631Z] 15:31:17     INFO -       r4 = 0x56ed4e28    r5 = 0x0000000e    r6 = 0x5280daf8    r7 = 0x5280db24
[task 2017-05-23T15:31:17.221834Z] 15:31:17     INFO -       r8 = 0x5280db04    r9 = 0x0000030c   r10 = 0x52a2d800    fp = 0x20000009
[task 2017-05-23T15:31:17.222014Z] 15:31:17     INFO -       sp = 0x5280dad0    pc = 0x54c8d90d
[task 2017-05-23T15:31:17.222194Z] 15:31:17     INFO -      Found by: call frame info
[task 2017-05-23T15:31:17.222413Z] 15:31:17     INFO -  22  libxul.so!mozilla::ipc::ScopedXREEmbed::Stop [ScopedXREEmbed.cpp:5946cdb548d0 : 117 + 0x3]
[task 2017-05-23T15:31:17.222657Z] 15:31:17     INFO -       r4 = 0x52a2ded8    r5 = 0x0000000e    r6 = 0x5280daf8    r7 = 0x5280db24
[task 2017-05-23T15:31:17.222860Z] 15:31:17     INFO -       r8 = 0x5280db04    r9 = 0x0000030c   r10 = 0x52a2d800    fp = 0x20000009
[task 2017-05-23T15:31:17.223061Z] 15:31:17     INFO -       sp = 0x5280dae0    pc = 0x5338c73b
[task 2017-05-23T15:31:17.223243Z] 15:31:17     INFO -      Found by: call frame info
[task 2017-05-23T15:31:17.223476Z] 15:31:17     INFO -  23  libxul.so!XRE_InitChildProcess [nsEmbedFunctions.cpp:5946cdb548d0 : 713 + 0x3]
[task 2017-05-23T15:31:17.223694Z] 15:31:17     INFO -       r4 = 0x52a050b0    r5 = 0x0000000e    r6 = 0x5280daf8    r7 = 0x5280db24
[task 2017-05-23T15:31:17.223894Z] 15:31:17     INFO -       r8 = 0x5280db04    r9 = 0x0000030c   r10 = 0x52a2d800    fp = 0x20000009
[task 2017-05-23T15:31:17.224074Z] 15:31:17     INFO -       sp = 0x5280dae8    pc = 0x54c8e083

In some places we check ContentChild::IsShuttingDown before doing a send. It seems appropriate to do something similar here.

mozilla::services::Shutdown() hasn't happened yet so it still can try to create new services. When it creates the presentation service, it wants to do IPC over the ContentChild which has already been shutdown. PresentationIPCService appears to check for the child protocol object before use, so we should be able to simply not create it.
Assignee: nobody → aosmond
Status: NEW → ASSIGNED
Comment on attachment 8870503 [details] [diff] [review]
Do not create PresentationChild if ContentChild is shutting down, v1

Similar vein to bug 1331685.
Attachment #8870503 - Flags: review?(ehsan)
Attachment #8870503 - Flags: review?(ehsan) → review+
Pushed by aosmond@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/d5d06e3f87aa
Do not attempt to create PresentationChild if ContentChild is shutting down. r=ehsan
https://hg.mozilla.org/mozilla-central/rev/d5d06e3f87aa
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Component: DOM → DOM: Core & HTML
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: