1367194 - Intermittent toolkit/content/tests/widgets/test_videocontrols.html | ----- test #34 ----- - Result logged after SimpleTest.finish()

Status: RESOLVED FIXED

(Toolkit :: Video/Audio Controls, defect)

Description

[Treeherder Bug Filer]

Filed by: rvandermeulen [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=101295732&repo=mozilla-central

https://queue.taskcluster.net/v1/task/VXBlF3mDQNeJijNserXOQQ/runs/0/artifacts/public/logs/live_backing.log

Comment 1

[Ray Lin[:ralin]]

ah, I guess we need to explicitly pause the video at the end to prevent "pause" event.

Comment 2

[Ray Lin[:ralin]]

Attachment: Bug 1367194 - Explicitly pause video at the end of the test to prevent the media backend from pausing the video as the page closes and thus

Review commit: https://reviewboard.mozilla.org/r/142150/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142150/

Comment 3

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8870682 [details]
Bug 1367194 - Explicitly pause video at the end of the test to prevent the media backend from pausing the video as the page closes and thus

https://reviewboard.mozilla.org/r/142150/#review146020

::: commit-message-96e18:1
(Diff revision 1)
> +Bug 1367194 - Intermittent toolkit/content/tests/widgets/test_videocontrols.html | ----- test #34 ----- - Result logged after SimpleTest.finish(): explicitly pause video at the end. r=jaws

This commit message needs to be changed since it doesn't really explain anything about why this change is necessary.

Comment 4

[Jared Wein [:jaws] (please needinfo? me)]

Comment on attachment 8870682 [details]
Bug 1367194 - Explicitly pause video at the end of the test to prevent the media backend from pausing the video as the page closes and thus

https://reviewboard.mozilla.org/r/142150/#review146022

You could remove everything at the beginning. Maybe write:
Bug 1367194 - Explicitly pause video at the end of the test to prevent the media backend from pausing the video as the page closes and thus randomly firing a 'pause' event when the test isn't expecting it. r=jaws

r=me with that change

Comment 5

[Ray Lin[:ralin]]

Comment on attachment 8870682 [details]
Bug 1367194 - Explicitly pause video at the end of the test to prevent the media backend from pausing the video as the page closes and thus

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/142150/diff/1-2/

Comment 6

[Ray Lin[:ralin]]

I initially thought that is the naming convention of intermittent bug :P 

I've changed the commit message, thank you Jared,

Comment 7

[Ryan VanderMeulen [:RyanVM]]

Autoland can't push this until all pending issues are marked as resolved in MozReview.

Comment 8

[Ray Lin[:ralin]]

Sorry. The issue is resolved.

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/40bd5b696029
Explicitly pause video at the end of the test to prevent the media backend from pausing the video as the page closes and thus r=jaws

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/40bd5b696029

Comment 11

[Ray Lin[:ralin]]

Comment on attachment 8870682 [details]
Bug 1367194 - Explicitly pause video at the end of the test to prevent the media backend from pausing the video as the page closes and thus

Approval Request Comment
[Feature/Bug causing the regression]: Bug 1352724
[User impact if declined]: its a followup of Bug 1352724 as an intermittent fix
[Is this code covered by automated tests?]: no need
[Has the fix been verified in Nightly?]: no
[Needs manual test from QE? If yes, steps to reproduce]: no
[List of other uplifts needed for the feature/fix]: uplift this after Bug 1352724's uplift request is done
[Is the change risky?]: no
[Why is the change risky/not risky?]: fix intermittent only
[String changes made/needed]: none

Thanks :)

Comment 12

[Julien Cristau [:jcristau]]

Comment on attachment 8870682 [details]
Bug 1367194 - Explicitly pause video at the end of the test to prevent the media backend from pausing the video as the page closes and thus

see bug 1352724 comment 27.