1367232 - Clean up various ESLint global definitions in toolkit/

Status: RESOLVED FIXED

(Toolkit :: General, enhancement)

Description

[Mark Banner (:standard8)]

Partially due to the gradual roll-out of enabling no-undef, and discovering improvements to rules as we went, there's a lot of global definitions around the tree that either:

- aren't needed
- can be better served by something else (e.g. modules.json addition, eslint-env specification).

Hence, I'm looking to start getting those cleaned up before people start copying bad styles.

The patch I'll attach does most of toolkit. The extensions folders need quite a bit of work so I'll leave that for a different bug.

Comment 1

[Mark Banner (:standard8)]

Attachment: Bug 1367232 - Clean up various ESLint global definitions in toolkit/.

Review commit: https://reviewboard.mozilla.org/r/142034/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142034/

Comment 2

[Dave Townsend [:mossop]]

Comment on attachment 8870573 [details]
Bug 1367232 - Clean up various ESLint global definitions in toolkit/.

https://reviewboard.mozilla.org/r/142034/#review145690

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/3676568d6311
Clean up various ESLint global definitions in toolkit/. r=mossop

Comment 4

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/3676568d6311