Closed Bug 1367232 Opened 2 years ago Closed 2 years ago

Clean up various ESLint global definitions in toolkit/

Categories

(Toolkit :: General, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: standard8, Assigned: standard8)

References

Details

Attachments

(1 file)

Partially due to the gradual roll-out of enabling no-undef, and discovering improvements to rules as we went, there's a lot of global definitions around the tree that either:

- aren't needed
- can be better served by something else (e.g. modules.json addition, eslint-env specification).

Hence, I'm looking to start getting those cleaned up before people start copying bad styles.

The patch I'll attach does most of toolkit. The extensions folders need quite a bit of work so I'll leave that for a different bug.
Comment on attachment 8870573 [details]
Bug 1367232 - Clean up various ESLint global definitions in toolkit/.

https://reviewboard.mozilla.org/r/142034/#review145690
Attachment #8870573 - Flags: review?(dtownsend) → review+
Pushed by mbanner@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/3676568d6311
Clean up various ESLint global definitions in toolkit/. r=mossop
https://hg.mozilla.org/mozilla-central/rev/3676568d6311
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Depends on: 1372406
You need to log in before you can comment on or make changes to this bug.