[e10s-multi] e10srollout changes for GA Release

RESOLVED FIXED in Firefox 54

Status

()

Firefox
General
RESOLVED FIXED
3 months ago
3 months ago

People

(Reporter: mrbkap, Assigned: mrbkap)

Tracking

unspecified
Firefox 55
Points:
---

Firefox Tracking Flags

(firefox54 fixed, firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

3 months ago
It's looking pretty good for us to release in Firefox 54 (fingers crossed). Trying to balance optimism (and trying to get multi to the greatest number of users), a desire for data, and an overabundance of caution, we're going to stage the rollout like we did for e10s.

As I understand it, the plan is to enable 4 content processes for 80% of the eligible release users (keeping 20% on single-process e10s), disabling multi for users with any sort of add-on (webextension or not).

If the results are good, then we'll phase in extensions and the rest of the eligible users.

Erin, does that sound right?
Flags: needinfo?(elancaster)
(Assignee)

Comment 1

3 months ago
Felipe, I think it's possible for us to update the e10srollout addon without releasing a new (dot) version of Firefox, is that correct? What does the process for that look like?
Flags: needinfo?(felipc)
(In reply to Blake Kaplan (:mrbkap) from comment #0)
> It's looking pretty good for us to release in Firefox 54 (fingers crossed).
> Trying to balance optimism (and trying to get multi to the greatest number
> of users), a desire for data, and an overabundance of caution, we're going
> to stage the rollout like we did for e10s.
> 
> As I understand it, the plan is to enable 4 content processes for 80% of the
> eligible release users (keeping 20% on single-process e10s), disabling multi
> for users with any sort of add-on (webextension or not).
> 
> If the results are good, then we'll phase in extensions and the rest of the
> eligible users.
> 
> Erin, does that sound right?

 Confirmed. This is correct! Thank you!
Flags: needinfo?(elancaster)
(In reply to Blake Kaplan (:mrbkap) from comment #1)
> Felipe, I think it's possible for us to update the e10srollout addon without
> releasing a new (dot) version of Firefox, is that correct? What does the
> process for that look like?

That is correct. The process involves:
 - packaging the install.rdf+bootstrap.js file as an xpi and getting it signed
 - announce the intent to ship on release drivers
 - talk to ckprice about deploying this to staging, and asking QA to do some tests with it deployed on staging

I found this document: https://wiki.mozilla.org/Firefox/Go_Faster/System_Add-ons/Process, but I think there's a more descriptive one somewhere else. Ckprice will know.
Flags: needinfo?(felipc)
Comment hidden (mozreview-request)

Comment 5

3 months ago
mozreview-review
Comment on attachment 8871100 [details]
Bug 1367244 - Changes to release e10s multi on the Release channel.

https://reviewboard.mozilla.org/r/142610/#review146240

Do you think the next request will probably be "only go out for users of webextensions"? If so, maybe you could prepare this ahead of time by making the `addons` boolean be a list of allowed cohortPrefixes..

Up to you if you want to do this now or leave it for later.
Attachment #8871100 - Flags: review?(felipc) → review+
(Assignee)

Comment 6

3 months ago
(In reply to :Felipe Gomes (needinfo me!) from comment #5)
> Up to you if you want to do this now or leave it for later.

Felipe and I talked about this on IRC and decided to go with the patch here in the bug. We'll revisit the changes required to allow (certain) addons for the multi experiment when we get there.

Comment 7

3 months ago
Pushed by mrbkap@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/04d82da432bc
Changes to release e10s multi on the Release channel. r=Felipe

Comment 8

3 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/04d82da432bc
Status: NEW → RESOLVED
Last Resolved: 3 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
(Assignee)

Comment 9

3 months ago
Comment on attachment 8871100 [details]
Bug 1367244 - Changes to release e10s multi on the Release channel.

Approval Request Comment
[Feature/Bug causing the regression]: e10s-multi
[User impact if declined]: ...
[Is this code covered by automated tests?]: No.
[Has the fix been verified in Nightly?]: No.
[Needs manual test from QE? If yes, steps to reproduce]: No.
[List of other uplifts needed for the feature/fix]: n/a
[Is the change risky?]: It's multi!
[Why is the change risky/not risky?]: see above
[String changes made/needed]: n/a
Attachment #8871100 - Flags: approval-mozilla-beta?
Comment on attachment 8871100 [details]
Bug 1367244 - Changes to release e10s multi on the Release channel.

enable e10s-multi in release, beta54+
Attachment #8871100 - Flags: approval-mozilla-beta? → approval-mozilla-beta+

Comment 11

3 months ago
bugherderuplift
https://hg.mozilla.org/releases/mozilla-beta/rev/715d88d0bd82
status-firefox54: --- → fixed
:grover do you think you can validate that Blake's changes are good to go? please contact him with any questions. We would need your testing and sign off by June 12th. Apologies for the delay in my request. I just thought of this...
Flags: needinfo?(gwimberly)
Rares, can you look into this?
Flags: needinfo?(gwimberly) → needinfo?(rares_bologa)
(In reply to Erin Lancaster [:elan] from comment #12)
> :grover do you think you can validate that Blake's changes are good to go?
> please contact him with any questions. We would need your testing and sign
> off by June 12th. Apologies for the delay in my request. I just thought of
> this...

I think Release QA can pick this up, so redirecting this needinfo to myself. The wiki link posted by Felipe
(see Comment 3) is up to date in regards to the manual verification side of the process.

Erin/Blake, could you please file a request with the Product Integrity Channel (pi-request@mozilla.com), so 
we can properly track and plan for this?

We would need you to include a few more details in that submission though, such as:

    * is this system add-on update available on the 'release-sysaddon' channel for testing?
    * what version of the e10srollout system add-on should users be updated to?
    * would testing the following items suffice for this system add-on update?

            ** ensuring that the e10srollout system add-on is updated to the intended version (on 54.* only)
            ** ensuring that the 'dom.ipc.processCount' pref is set to 4 for eligible users
Flags: needinfo?(rares_bologa)
Flags: needinfo?(mrbkap)
Flags: needinfo?(elancaster)
Flags: needinfo?(andrei.vaida)
(Assignee)

Comment 15

3 months ago
I sent an email with the answers to Andrei's questions.
Flags: needinfo?(mrbkap)
Flags: needinfo?(elancaster)
A test report has been sent out for this request: https://public.etherpad-mozilla.org/p/1367244.

One potential issue was uncovered and is pending feedback (per Bogdan Maris): when installing an add-on that requires restart, it won't disable e10s-multi (dom.ipc.processCount.web = 4 still is displayed in about:config), a second restart is required so that e10s-multi gets disabled.
Flags: needinfo?(andrei.vaida)
You need to log in before you can comment on or make changes to this bug.