1367267 - --enable-pie doesn't work properly in some cases

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Mike Hommey [:glandium]]

So there's this weird thing where in some cases, --enable-pie fails with something like:

checking for PIE support... no
configure: error: --enable-pie requires PIE support from the linker.

and config.log contains:
/usr/bin/ld: /tmp/cc1JnNAS.o: relocation R_X86_64_32 against `.text.main' can
not be used when making a shared object; recompile with -fPIC
/tmp/cc1JnNAS.o: could not read symbols: Bad value
collect2: error: ld returned 1 exit status

And we indeed don't pass -fPIC to the compiler during the -pie test (while we do when actually building Firefox), but we actually should be, and I'm actually surprised this hasn't broken my builds on Debian in the past.

Comment 1

[Mike Hommey [:glandium]]

Attachment: Bug 1367267 - Pass -fPIC when compiling the -pie configure test.

Review commit: https://reviewboard.mozilla.org/r/142086/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/142086/

Comment 2

[Gregory Szorc [:gps]]

Comment on attachment 8870632 [details]
Bug 1367267 - Pass -fPIC when compiling the -pie configure test.

https://reviewboard.mozilla.org/r/142086/#review146118

Comment 3

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/fdb4db210119
Pass -fPIC when compiling the -pie configure test. r=gps

Comment 4

[Mike Hommey [:glandium]]

Comment on attachment 8870632 [details]
Bug 1367267 - Pass -fPIC when compiling the -pie configure test.

Approval Request Comment
[Feature/Bug causing the regression]: bug 857628
[User impact if declined]: build failure in some cases when using --enable-pie (likely related to compiler/linker versions)
[Is this code covered by automated tests?]: N/A
[Has the fix been verified in Nightly?]: N/a
[Needs manual test from QE? If yes, steps to reproduce]: N/A
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: It's a trivial `configure` change.
[String changes made/needed]: N/A

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fdb4db210119

Comment 6

[Gerry Chang [:gchang]]

Comment on attachment 8870632 [details]
Bug 1367267 - Pass -fPIC when compiling the -pie configure test.

Fix a build issue. Beta54+. Should be in 54 beta 11.

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/2b2e0bc442c7

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8870632 [details]
Bug 1367267 - Pass -fPIC when compiling the -pie configure test.

Fixes a build config setting, let's uplift to ESR52.

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-esr52/rev/4c2f4d8b693e