Closed Bug 1367267 Opened 2 years ago Closed 2 years ago

--enable-pie doesn't work properly in some cases

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(firefox-esr52 fixed, firefox54 fixed, firefox55 fixed)

RESOLVED FIXED
mozilla55
Tracking Status
firefox-esr52 --- fixed
firefox54 --- fixed
firefox55 --- fixed

People

(Reporter: glandium, Assigned: glandium)

References

Details

Attachments

(1 file)

So there's this weird thing where in some cases, --enable-pie fails with something like:

checking for PIE support... no
configure: error: --enable-pie requires PIE support from the linker.

and config.log contains:
/usr/bin/ld: /tmp/cc1JnNAS.o: relocation R_X86_64_32 against `.text.main' can
not be used when making a shared object; recompile with -fPIC
/tmp/cc1JnNAS.o: could not read symbols: Bad value
collect2: error: ld returned 1 exit status

And we indeed don't pass -fPIC to the compiler during the -pie test (while we do when actually building Firefox), but we actually should be, and I'm actually surprised this hasn't broken my builds on Debian in the past.
Comment on attachment 8870632 [details]
Bug 1367267 - Pass -fPIC when compiling the -pie configure test.

https://reviewboard.mozilla.org/r/142086/#review146118
Attachment #8870632 - Flags: review?(gps) → review+
Pushed by mh@glandium.org:
https://hg.mozilla.org/integration/autoland/rev/fdb4db210119
Pass -fPIC when compiling the -pie configure test. r=gps
Comment on attachment 8870632 [details]
Bug 1367267 - Pass -fPIC when compiling the -pie configure test.

Approval Request Comment
[Feature/Bug causing the regression]: bug 857628
[User impact if declined]: build failure in some cases when using --enable-pie (likely related to compiler/linker versions)
[Is this code covered by automated tests?]: N/A
[Has the fix been verified in Nightly?]: N/a
[Needs manual test from QE? If yes, steps to reproduce]: N/A
[List of other uplifts needed for the feature/fix]: N/A
[Is the change risky?]: No
[Why is the change risky/not risky?]: It's a trivial `configure` change.
[String changes made/needed]: N/A
Attachment #8870632 - Flags: approval-mozilla-esr52?
Attachment #8870632 - Flags: approval-mozilla-beta?
https://hg.mozilla.org/mozilla-central/rev/fdb4db210119
Status: NEW → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Comment on attachment 8870632 [details]
Bug 1367267 - Pass -fPIC when compiling the -pie configure test.

Fix a build issue. Beta54+. Should be in 54 beta 11.
Attachment #8870632 - Flags: approval-mozilla-beta? → approval-mozilla-beta+
Comment on attachment 8870632 [details]
Bug 1367267 - Pass -fPIC when compiling the -pie configure test.

Fixes a build config setting, let's uplift to ESR52.
Attachment #8870632 - Flags: approval-mozilla-esr52? → approval-mozilla-esr52+
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.