1367278 - stylo: may_have_animations() is called against wrong element

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement, P2)

Description

[Hiroyuki Ikezoe (:hiro)]

As Emilio suggested in bug 1366631 comment 17, when I added an assertion in may_have_animations() that checks the element is neither 'before' nor 'after', it revealed that we are calling may_have_animations for such pseudo elements. Initially I was trying to fix it in additional patch in bug 1366631, but I decided to handle it in a new bug.

Comment 1

[Hiroyuki Ikezoe (:hiro)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=d1d0c700e72543d750f262a9e3920a57f4e950b0

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1367278 - Call may_have_animations() for parent element in the case where the target is pseudo element.

In case of pseudo elements ElementHasAnimations is set to their parent element.

updating-animation-on-pseudo-element.html fails without this patch, succeeds
with this patch.

Review commit: https://reviewboard.mozilla.org/r/159062/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/159062/

Comment 3

[Brian Birtles (:birtles, Feb 26~ parental leave)]

Comment on attachment 8888147 [details]
Bug 1367278 - Call may_have_animations() for parent element in the case where the target is pseudo element.

https://reviewboard.mozilla.org/r/159062/#review164430

Nice! Thank you!

::: commit-message-eb1d9:3
(Diff revision 1)
> +Bug 1367278 - Call may_have_animations() for parent element in the case where the target is pseudo element. r?birtles
> +
> +In case of pseudo elements ElementHasAnimations is set to their parent element.

Nit: ... set on the parent element.

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Thank you!
https://github.com/servo/servo/pull/17793

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8888147 [details]
Bug 1367278 - Call may_have_animations() for parent element in the case where the target is pseudo element.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/159062/diff/1-2/

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/1f5cc20c3be3
Call may_have_animations() for parent element in the case where the target is pseudo element. r=birtles

Comment 7

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/1f5cc20c3be3