Note: There are a few cases of duplicates in user autocompletion which are being worked on.

stylo: may_have_animations() is called against wrong element

NEW
Assigned to

Status

()

Core
CSS Parsing and Computation
P2
normal
2 months ago
18 hours ago

People

(Reporter: hiro, Assigned: hiro)

Tracking

(Blocks: 1 bug)

Trunk
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

2 months ago
As Emilio suggested in bug 1366631 comment 17, when I added an assertion in may_have_animations() that checks the element is neither 'before' nor 'after', it revealed that we are calling may_have_animations for such pseudo elements. Initially I was trying to fix it in additional patch in bug 1366631, but I decided to handle it in a new bug.
Assignee: nobody → hikezoe
Priority: -- → P2
(Assignee)

Comment 1

2 days ago
https://treeherder.mozilla.org/#/jobs?repo=try&revision=d1d0c700e72543d750f262a9e3920a57f4e950b0
(Assignee)

Updated

2 days ago
Blocks: 1379553
Comment hidden (mozreview-request)

Comment 3

2 days ago
mozreview-review
Comment on attachment 8888147 [details]
Bug 1367278 - Call may_have_animations() for parent element in the case where the target is pseudo element.

https://reviewboard.mozilla.org/r/159062/#review164430

Nice! Thank you!

::: commit-message-eb1d9:3
(Diff revision 1)
> +Bug 1367278 - Call may_have_animations() for parent element in the case where the target is pseudo element. r?birtles
> +
> +In case of pseudo elements ElementHasAnimations is set to their parent element.

Nit: ... set on the parent element.
Attachment #8888147 - Flags: review?(bbirtles) → review+
(Assignee)

Comment 4

2 days ago
Thank you!
https://github.com/servo/servo/pull/17793
Comment hidden (mozreview-request)

Comment 6

18 hours ago
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/1f5cc20c3be3
Call may_have_animations() for parent element in the case where the target is pseudo element. r=birtles
You need to log in before you can comment on or make changes to this bug.