1367281 - Intermittent test_ext_contentscript_xrays.js | application crashed [@ `anonymous namespace'::TelemetryImpl::~TelemetryImpl] (Assertion failure: !mOwningThread (destroying a still-owned lock!), at mozilla/Mutex.h:57)

Status: RESOLVED FIXED

(Toolkit :: Telemetry, defect, P1)

Description

[Treeherder Bug Filer]

Filed by: rvandermeulen [at] mozilla.com

https://treeherder.mozilla.org/logviewer.html#?job_id=101389138&repo=autoland

https://archive.mozilla.org/pub/firefox/tinderbox-builds/autoland-win64-debug/1495578088/autoland_win8_64-debug_test-xpcshell-bm126-tests1-windows-build411.txt.gz

Comment 1

[Georg Fritzsche [:gfritzsche]]

Relevant bits:
> PROCESS-CRASH | xpcshell-remote.ini:toolkit/components/extensions/test/xpcshell/test_ext_contentscript_xrays.js | application crashed [@ `anonymous namespace'::TelemetryImpl::~TelemetryImpl]
> ...
> Assertion failure: !mOwningThread (destroying a still-owned lock!), at c:\\builds\\moz2_slave\\autoland-w64-d-000000000000000\\build\\src\\obj-firefox\\dist\\include\\mozilla/Mutex.h:57

Crash site:
https://hg.mozilla.org/integration/autoland/file/d4dc4bfab1eeb363de9202cd99f44fdf862f28ea/toolkit/components/telemetry/Telemetry.cpp#l1266

Crash stack:
> 0  xul.dll!`anonymous namespace'::TelemetryImpl::~TelemetryImpl [Telemetry.cpp:d4dc4bfab1ee : 1266 + 0x1c1]
> 1  xul.dll!`anonymous namespace'::TelemetryImpl::Release [Telemetry.cpp:d4dc4bfab1ee : 2723 + 0x52]
> 2  xul.dll!`anonymous namespace'::TelemetryImpl::ShutdownTelemetry [Telemetry.cpp:d4dc4bfab1ee : 2362 + 0x11]
> 3  xul.dll!nsComponentManagerImpl::KnownModule::`scalar deleting destructor'(unsigned int) + 0x28
> 4  xul.dll!nsTArray_Impl<nsAutoPtr<nsComponentManagerImpl::KnownModule>,nsTArrayInfallibleAllocator>::RemoveElementsAt(unsigned __int64,unsigned __int64) [nsTArray.h:d4dc4bfab1ee : 2055 + 0x20]
> 5  xul.dll!nsComponentManagerImpl::Shutdown() [nsComponentManager.cpp:d4dc4bfab1ee : 821 + 0x14]
> 6  xul.dll!mozilla::ShutdownXPCOM(nsIServiceManager *) [XPCOMInit.cpp:d4dc4bfab1ee : 1007 + 0x5]
> 7  xul.dll!XRE_TermEmbedding() [nsEmbedFunctions.cpp:d4dc4bfab1ee : 225 + 0x7]
> 8  xul.dll!mozilla::ipc::ScopedXREEmbed::Stop() [ScopedXREEmbed.cpp:d4dc4bfab1ee : 117 + 0x5]
> 9  xul.dll!XRE_InitChildProcess(int,char * * const,XREChildData const *) [nsEmbedFunctions.cpp:d4dc4bfab1ee : 713 + 0x9]
> 10  plugin-container.exe!content_process_main(mozilla::Bootstrap *,int,char * * const) [plugin-container.cpp:d4dc4bfab1ee : 64 + 0x13]

Comment 2

[Georg Fritzsche [:gfritzsche]]

Looking at the code, i see that we never wait on any of TelemetryImpls mutex members:
https://hg.mozilla.org/integration/autoland/file/d4dc4bfab1eeb363de9202cd99f44fdf862f28ea/toolkit/components/telemetry/Telemetry.cpp#l1250

Comment 3

[Georg Fritzsche [:gfritzsche]]

Attachment: Wait on member Mutexes in TelemetryImpl destructor

Comment 4

[Georg Fritzsche [:gfritzsche]]

try: https://treeherder.mozilla.org/#/jobs?repo=try&revision=df1dbbdb725b8282fce6d3be445ed3a3cd6e8f2e

Comment 5

[Chris H-C :chutten]

Comment on attachment 8870749 [details] [diff] [review]
Wait on member Mutexes in TelemetryImpl destructor

Review of attachment 8870749 [details] [diff] [review]:
-----------------------------------------------------------------

Seems legit to me.

Comment 6

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b927981cceb7
Wait on member Mutexes in TelemetryImpl destructor. r=chutten

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/b927981cceb7