Closed Bug 1367564 Opened 3 years ago Closed 3 years ago

Fix inconsistent pref name for suppressing .onion referers

Categories

(Core :: Networking, enhancement)

enhancement
Not set

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox54 - wontfix
firefox55 - fixed

People

(Reporter: arthur, Assigned: arthur)

References

Details

(Whiteboard: [necko-would-take][tor 22320])

Attachments

(1 file)

Unfortunately I accidentally introduced a mistake into my patch for bug 1305144. In some places the patch uses a pref called "network.http.referer.hideOnionSource", but in other places it calls it "network.http.referer.spoofOnionSource" (which was an earlier name I had intended to drop). So I would like to offer a patch that converts the leftover obsolete references to "network.http.referer.hideOnionSource".
I manually tested this patch in Tor Browser and confirmed that the referer is correctly blanked when leaving a .onion site, if and only if "network.http.referer.hideOnionSource" is enabled.
Assignee: nobody → arthuredelstein
Status: NEW → ASSIGNED
Attachment #8871013 - Flags: review?(mcmanus)
Whiteboard: [tor 22320] → [necko-would-take][tor 22320]
I should have noticed that. sorry. at least you didn't do referer with a variable number of r's :)
Attachment #8871013 - Flags: review?(mcmanus) → review+
you should nominate the patch for 54.
Thanks, Patrick!

[Tracking Requested - why for this release]:
Correcting a very simple mistake in a pref name.
Pushed by ryanvm@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/081035e39ef1
Use pref name 'referer.hideOnionSource' everywhere. r=mcmanus
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/081035e39ef1
Status: ASSIGNED → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Not tracking, though I'd be ok to take the patch in beta this week, please request uplift when you get a chance.
Flags: needinfo?(arthuredelstein)
Flags: needinfo?(arthuredelstein)
Attachment #8871013 - Flags: approval-mozilla-beta?
Comment on attachment 8871013 [details] [diff] [review]
0001-Bug-22320-Use-pref-name-referer.hideOnionSource-ever.patch

While this is a valid bug to fix, I am not sure if this uplift is justified so late in the beta54 cycle. I'd prefer this fix ride the 55 train to release.
Attachment #8871013 - Flags: approval-mozilla-beta? → approval-mozilla-beta-
You need to log in before you can comment on or make changes to this bug.