1367564 - Fix inconsistent pref name for suppressing .onion referers

Status: RESOLVED FIXED

(Core :: Networking, enhancement)

Description

[Arthur Edelstein [:arthur]]

Unfortunately I accidentally introduced a mistake into my patch for bug 1305144. In some places the patch uses a pref called "network.http.referer.hideOnionSource", but in other places it calls it "network.http.referer.spoofOnionSource" (which was an earlier name I had intended to drop). So I would like to offer a patch that converts the leftover obsolete references to "network.http.referer.hideOnionSource".

Comment 1

[Arthur Edelstein [:arthur]]

Attachment: 0001-Bug-22320-Use-pref-name-referer.hideOnionSource-ever.patch

I manually tested this patch in Tor Browser and confirmed that the referer is correctly blanked when leaving a .onion site, if and only if "network.http.referer.hideOnionSource" is enabled.

Comment 2

[Patrick McManus [:mcmanus]]

I should have noticed that. sorry. at least you didn't do referer with a variable number of r's :)

Comment 3

[Patrick McManus [:mcmanus]]

you should nominate the patch for 54.

Comment 4

[Arthur Edelstein [:arthur]]

Thanks, Patrick!

[Tracking Requested - why for this release]:
Correcting a very simple mistake in a pref name.

Comment 5

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/081035e39ef1
Use pref name 'referer.hideOnionSource' everywhere. r=mcmanus

Comment 6

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/081035e39ef1

Comment 7

[Julien Cristau [:jcristau]]

Not tracking, though I'd be ok to take the patch in beta this week, please request uplift when you get a chance.

Comment 8

[Ritu Kothari (:ritu) (Inactive, please n-i to RyanVM, jcristau, or pascal)]

Comment on attachment 8871013 [details] [diff] [review]
0001-Bug-22320-Use-pref-name-referer.hideOnionSource-ever.patch

While this is a valid bug to fix, I am not sure if this uplift is justified so late in the beta54 cycle. I'd prefer this fix ride the 55 train to release.