Closed Bug 1367570 Opened 3 years ago Closed 3 years ago

Vertex Attribs left in invalid state by Nvidia Linux driver

Categories

(Core :: Canvas: WebGL, enhancement, P1)

enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: svargas, Assigned: svargas)

Details

(Whiteboard: gfx-noted)

Attachments

(1 file, 1 obsolete file)

Firefox currently fails the WebGL Disabled Vertex Attrib Test and the gl calls test on 64bit Linux when using the proprietary Linux Nvidia driver.

The Linux proprietary NVidia driver leaves vertex attribs 1, 2, and 3 at invalid states (not opaque  black) causing the test to fail.

Tests: 

https://www.khronos.org/registry/webgl/conformance-suites/1.0.3/conformance/attribs/gl-disabled-vertex-attrib.html?webglVersion=1

https://www.khronos.org/registry/webgl/conformance-suites/1.0.3/conformance/state/gl-get-calls.html?webglVersion=1
Assignee: nobody → svargas
Comment on attachment 8871019 [details] [diff] [review]
0001-Bug-1367570-Explicitly-set-vertex-attribs-1-3-to-opa.patch

Review of attachment 8871019 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContext.cpp
@@ +903,5 @@
>          }
> +        // Bug 1367570. Explicitly set vertex attributes [1,3] to opaque
> +        // black because Nvidia doesn't do it for us.
> +        if (mVendor == GLVendor::NVIDIA) {
> +            for (size_t i=1; i <= 3; ++i) {

`i = 1` with spaces
Attachment #8871019 - Flags: review?(jgilbert) → review+
Keywords: checkin-needed
Priority: -- → P1
Whiteboard: gfx-noted
Pushed by jgilbert@mozilla.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c2e66552c70
Explicitly set vertex attribs [1,3] to opaque black - r=jgilbert
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/6c2e66552c70
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.