1367570 - Vertex Attribs left in invalid state by Nvidia Linux driver

Status: RESOLVED FIXED

(Core :: Graphics: CanvasWebGL, enhancement, P1)

Description

[Samuel Vargas [:svargas]]

Firefox currently fails the WebGL Disabled Vertex Attrib Test and the gl calls test on 64bit Linux when using the proprietary Linux Nvidia driver.

The Linux proprietary NVidia driver leaves vertex attribs 1, 2, and 3 at invalid states (not opaque  black) causing the test to fail.

Tests: 

https://www.khronos.org/registry/webgl/conformance-suites/1.0.3/conformance/attribs/gl-disabled-vertex-attrib.html?webglVersion=1

https://www.khronos.org/registry/webgl/conformance-suites/1.0.3/conformance/state/gl-get-calls.html?webglVersion=1

Comment 1

[Samuel Vargas [:svargas]]

Attachment: 0001-Bug-1367570-Explicitly-set-vertex-attribs-1-3-to-opa.patch

Comment 2

[Kelsey Gilbert [:jgilbert]]

Comment on attachment 8871019 [details] [diff] [review]
0001-Bug-1367570-Explicitly-set-vertex-attribs-1-3-to-opa.patch

Review of attachment 8871019 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/gl/GLContext.cpp
@@ +903,5 @@
>          }
> +        // Bug 1367570. Explicitly set vertex attributes [1,3] to opaque
> +        // black because Nvidia doesn't do it for us.
> +        if (mVendor == GLVendor::NVIDIA) {
> +            for (size_t i=1; i <= 3; ++i) {

`i = 1` with spaces

Comment 3

[Samuel Vargas [:svargas]]

Attachment: 0001-Bug-1367570-Explicitly-set-vertex-attribs-1-3-to-opa.patch

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6c2e66552c70
Explicitly set vertex attribs [1,3] to opaque black - r=jgilbert

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6c2e66552c70