Closed Bug 1367578 Opened 3 years ago Closed 3 years ago

DataChannel logging broken since Network team updated it to LazyLogging

Categories

(Core :: WebRTC: Networking, enhancement, P1)

49 Branch
enhancement

Tracking

()

RESOLVED FIXED
mozilla55
Tracking Status
firefox55 --- fixed

People

(Reporter: jesup, Assigned: jesup)

References

Details

Attachments

(1 file)

DataChannel logging (and SCTP logging) has been partially broken since the network team updated it to use LazyLog, mostly because they missed that it used PR_LogPrintf(), which doesn't work with LazyLog/MOZ_LOG.
Rank: 15
Priority: -- → P1
the info()'s might be overkill; let me know if you want me to nuke or comment them out
Attachment #8871029 - Flags: review?(drno)
Comment on attachment 8871029 [details] [diff] [review]
Don't use PR_LogPrint() for logging now that we use LazyLog

Review of attachment 8871029 [details] [diff] [review]:
-----------------------------------------------------------------

LGTM

I'm okay with leaving the info's in there for now. We can always take them out later.
Attachment #8871029 - Flags: review?(drno) → review+
Pushed by rjesup@wgate.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/064c3ee69168
Don't use PR_LogPrint() for logging now that we use LazyLog r=drno
https://hg.mozilla.org/mozilla-central/rev/064c3ee69168
Status: NEW → RESOLVED
Closed: 3 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.