Note: There are a few cases of duplicates in user autocompletion which are being worked on.

Show an overlay of grid areas in Grid Highlighter

VERIFIED FIXED in Firefox 55

Status

()

Firefox
Developer Tools: Inspector
VERIFIED FIXED
2 months ago
12 days ago

People

(Reporter: micah, Assigned: micah)

Tracking

(Blocks: 1 bug)

unspecified
Firefox 55
Points:
---

Firefox Tracking Flags

(firefox55 verified)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

2 months ago
Add a checkbox in the grid highlighter's display settings so that we can toggle showing the grid areas of a grid container.
(Assignee)

Updated

2 months ago
Assignee: nobody → tigleym
Blocks: 1347964
Status: NEW → ASSIGNED

Updated

2 months ago
Blocks: 1181227
No longer blocks: 1347964
Comment hidden (mozreview-request)

Updated

2 months ago
Flags: qe-verify+

Comment 2

2 months ago
mozreview-review
Comment on attachment 8872092 [details]
Bug 1367627 - Show an overlay of grid areas in Grid Highlighter.

https://reviewboard.mozilla.org/r/143594/#review147670
Attachment #8872092 - Flags: review?(gl)
Comment hidden (mozreview-request)

Comment 4

2 months ago
mozreview-review
Comment on attachment 8872092 [details]
Bug 1367627 - Show an overlay of grid areas in Grid Highlighter.

https://reviewboard.mozilla.org/r/143594/#review148492

::: devtools/client/inspector/grids/test/browser_grids_display-setting-show-grid-areas.js:6
(Diff revision 2)
> +/* Any copyright is dedicated to the Public Domain.
> + http://creativecommons.org/publicdomain/zero/1.0/ */
> +
> +"use strict";
> +
> +// Tests that the 'Extend grid lines infinitely' grid highlighter setting will update

'Display grid areas'

::: devtools/server/actors/highlighters/css-grid.js:1141
(Diff revision 2)
> +/**
> + * Render grid area name on the containing grid area cell.
> + *
> + * @param  {Object} fragment
> + *         The grid fragment of the grid container.
> + *

Remove this line
Attachment #8872092 - Flags: review?(gl)

Comment 5

2 months ago
mozreview-review
Comment on attachment 8872092 [details]
Bug 1367627 - Show an overlay of grid areas in Grid Highlighter.

https://reviewboard.mozilla.org/r/143594/#review148494
Attachment #8872092 - Flags: review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 8

2 months ago
Pushed by gabriel.luong@gmail.com:
https://hg.mozilla.org/integration/mozilla-inbound/rev/37a4d90166ba
Show overlay of grid areas in Grid Highlighter. r=gl

Comment 9

2 months ago
mozreview-review
Comment on attachment 8873254 [details]
Bug 1367627 - Show overlay of grid areas in Grid Highlighter.

https://reviewboard.mozilla.org/r/144708/#review148870
Attachment #8873254 - Flags: review?(gl) → review+

Updated

2 months ago
Attachment #8872092 - Attachment is obsolete: true

Comment 10

2 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/37a4d90166ba
Status: ASSIGNED → RESOLVED
Last Resolved: 2 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55

Comment 11

2 months ago
I have reproduced this bug with Nightly 55.0a1 (2017-05-24) on Windows 8.1 , 64 Bit ! 

This bug's fix is Verified with latest Nightly 55.0a1 !

Build   ID    20170602030204
User Agent    Mozilla/5.0 (Windows NT 6.3; WOW64; rv:55.0) Gecko/20100101 Firefox/55.0

[bugday-20170531]
I have reproduced this Bug with Nightly 55.0a1 (2017-05-24) on Ubuntu 16.04 LTS!

The bug's fix is verified with latest Beta!

Build ID 	20170706155135
User Agent 	Mozilla/5.0 (X11; Linux x86_64; rv:55.0) Gecko/20100101 Firefox/55.0
QA Whiteboard: [testday-20170707]

Comment 13

15 days ago
As per Comment 11 & Comment 12, I am marking this bug as verified fixed.
Status: RESOLVED → VERIFIED
status-firefox55: fixed → verified
Thanks Sajedul and Mohammad for your testing!
Flags: qe-verify+
You need to log in before you can comment on or make changes to this bug.