1367669 - [Payment Request API] Revise the way to validate a decimal monetary value

Status: RESOLVED FIXED

(Core :: DOM: Web Payments, enhancement)

Description

[Alphan Chen [:alchen]]

[definition]
A JavaScript string is a valid decimal monetary value if it consists of the following code points in the given order:    

Optionally, a single U+002D HYPHEN-MINUS (-), to indicate that the amount is negative.

One or more code points in the range U+0030 DIGIT ZERO (0) to U+0039 DIGIT NINE (9).

Optionally, a single U+002E FULL STOP (.) followed by one or more code points in the range U+0030 DIGIT ZERO (0) to U+0039 DIGIT NINE (9).

Comment 1

[Alphan Chen [:alchen]]

Attachment: Revise the way to validate a decimal monetary value

We need to revise the validate way to pass web-platform-test.

Comment 2

[Andrea Marchesini [:baku]]

Comment on attachment 8875604 [details] [diff] [review]
Revise the way to validate a decimal monetary value

Review of attachment 8875604 [details] [diff] [review]:
-----------------------------------------------------------------

We need tests for this. Submit a separate patch for tests.

Comment 3

[Alphan Chen [:alchen]]

Attachment: Mochitest for validate a decimal monetary value

Comment 4

[Alphan Chen [:alchen]]

Comment on attachment 8879788 [details] [diff] [review]
Mochitest for validate a decimal monetary value

Here is the mochitest for it.

Comment 5

[Alphan Chen [:alchen]]

Attachment: Revise the way to validate a decimal monetary value. r=baku

Comment 6

[Alphan Chen [:alchen]]

Attachment: Revise the way to validate a decimal monetary value. r=baku

Add bug number into the summary

Comment 7

[Alphan Chen [:alchen]]

Attachment: Mochitest for validate a decimal monetary value. r=baku

Comment 8

[Alphan Chen [:alchen]]

The result of try server looks fine.
https://treeherder.mozilla.org/#/jobs?repo=try&revision=a0ef7027fb26da5c3394b435561b3ae906137d4c&selectedJob=108726379

Comment 9

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/b6364d014e35
[PaymentRequest API] Revise the way to validate a decimal monetary value. r=baku
https://hg.mozilla.org/integration/mozilla-inbound/rev/c636d23314b1
[PaymentRequest API] Mochitest for validate a decimal monetary value. r=baku

Comment 10

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

https://hg.mozilla.org/mozilla-central/rev/b6364d014e35
https://hg.mozilla.org/mozilla-central/rev/c636d23314b1