Closed Bug 1367670 Opened 6 years ago Closed 6 years ago

stylo: Enable test_animations_omta.html

Categories

(Core :: CSS Parsing and Computation, enhancement, P2)

Product:
Core
Component:
CSS Parsing and Computation
Version:
53 Branch
Type:
enhancement

Tracking

()

Status:
RESOLVED FIXED
Milestone:
mozilla55
Tracking Flags:
Tracking Status
firefox55 --- fixed

People

(Reporter: xidorn, Assigned: jryans)

References

Details

Attachments

(1 file)

Bug 1367670 - Re-enable test_animations_omta.html on e10s.
59 bytes, text/x-review-board-request
hiro
: review+
Details 
Visited style? We use visited link in test_animation_omta.html.
Looks like this is not fixed: https://bugzilla.mozilla.org/show_bug.cgi?id=1341003
Maybe that. OTOH, although half-landed bug 1328509 doesn't cause build bustage, it is unknown whether there could be other problems. This might be just a symptom due to that.
Depends on: 1328509
With the Gecko side of bug 1328509, I can confirm this test completes again.  I'll revert to the previous test annotation once bug 1328509 merges to m-c.
Assignee: nobody → jryans
Status: NEW → ASSIGNED
Priority: -- → P2
Comment on attachment 8871888 [details]
Bug 1367670 - Re-enable test_animations_omta.html on e10s.

https://reviewboard.mozilla.org/r/143416/#review147172

Stealing.

Thanks for doing this!

::: layout/style/test/mochitest.ini:63
(Diff revision 1)
>  [test_animations_event_order.html]
>  [test_animations_event_handler_attribute.html]
>  [test_animations_iterationstart.html]
>  support-files = file_animations_iterationstart.html
>  [test_animations_omta.html]
> -skip-if = stylo # crashing bug 1367670, bug 1361938, bug 1361663
> +skip-if = (stylo && !e10s) # mochitest expectations are different with non-e10s, bug 1361938, bug 1361663

We can drop bug 1361663 that has been already fixed.
Attachment #8871888 - Flags: review+
Updated comment.

Tried to do a minimal try run of just the layout/style tests in the last run, but it didn't seem to work for Stylo builds.

https://treeherder.mozilla.org/#/jobs?repo=try&revision=fe64777a1cb6436d5cca42a6de0c3dbdc509ffe2
Pushed by jryans@gmail.com:
https://hg.mozilla.org/integration/autoland/rev/12875bf75bd1
Re-enable test_animations_omta.html on e10s. r=hiro
https://hg.mozilla.org/mozilla-central/rev/12875bf75bd1
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.