1367688 - ExHentai Easy 2 is not working anymore!

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P3)

Description

[bismarck369tirpitz]

Attachment: Error.png

User Agent: Mozilla/5.0 (Windows NT 6.1; Win64; x64; rv:55.0) Gecko/20100101 Firefox/55.0
Build ID: 20170524030204

Steps to reproduce:

I was trying to login to exhentai.org/login i enter my user name and password and after that i click the login button and now i see the error message : " Error: Login Failure! "

I have disabled all addons and have created a new firefox clean account with the default settings by the firefox browser itself (I have nothing changed).

I running Windows 7 Sp1 64-Bit Ultimate and all drivers and applications are up to date.


Actual results:

I have get an error message from this page exhentai.org withe the currently ExHentai Easy 2 v.0.2.9 version 

This is the error i got.
            V
Error: Login Failure!


Expected results:

It must be the new firefox version 55.0a1 (2017-05-25) (64-Bit).

Comment 1

[Loic]

Is this URL? https://exhentai.org/
If yes, the site cannot be joinded. Could you provide an URL to connect, please.

Comment 2

[bismarck369tirpitz]

(In reply to Loic from comment #1)
> Is this URL? https://exhentai.org/
> If yes, the site cannot be joinded. Could you provide an URL to connect,
> please.

This is the correct url you have posted and you know that you must install the firefox addon ExHentai Easy 2 v.0.2.9 before you can see the login site with the username window and passwort window...!

Chrome Canary 64-Bit works fine, but firefox nightly 64-Bit dosn't work.

You can try this url here : https://exhentai.org/tag/artist%3Akitsune+youkai

This is all i can tell you all and you :(

Thank you for trying to help me out Loic :)

Comment 3

[Loic]

Ok, but the remaining issue is I don't have a user account at exhentai.org to test. Everytime I enter a false login, I get the message "error failure" and therefore I can't test the main issue.

Is it possible to have a guest account? (credentials can be sent by email)

Comment 4

[bismarck369tirpitz]

(In reply to Loic from comment #3)
> Ok, but the remaining issue is I don't have a user account at exhentai.org
> to test. Everytime I enter a false login, I get the message "error failure"
> and therefore I can't test the main issue.
> 
> Is it possible to have a guest account? (credentials can be sent by email)

You need a e-hentai.org account if you will help realy me than create a free acount there and you can login to the sister page exhentai.org with non removed uncensored stuff!

Comment 5

[Loic]

I created an account on e-hentai.org (https://forums.e-hentai.org/index.php?act=Reg&CODE=00), but with FF53, I don't understand how the page https://exhentai.org/login works. With the add-on, I'm not able to connect, the page reloads and fails to connect. Should I be redirected after the login?

Any idea why?

Comment 6

[krithivelan25]

I have tested this bug with the windows 7 - 64 bit machine 

I have created an account with the following link https://forums.e-hentai.org/index.php?act=Reg&CODE=00

But the link did not respond it was reloading after entering my password with the add on ExHentai Easy 2 v.0.2.9

Comment 7

[Loic]

Sorry, but I can't help more. This add-on doesn't work at all. After creating an account at forums.e-hentai.org, the add-on doesn't allow to connect to exhentai.org with the credentials. I tested with FF50/53/55, same result.

You should request help to the add-on author, or to the support team of the website, maybe they changed something to their website.

Comment 8

[bismarck369tirpitz]

Oh Thank you so much for trying to help me thank you alot :)

Have a nice time :)

Comment 9

[Loic]

I guess the issue with the loop on the login page with a new accout is due to http://haruhichan.com/forum/showthread.php?24909-Firefox-ExHentai-Easy-v2-Get-past-sad-panda!

I did some actions on the forum, I hope my account will be get unlimited access in a few days.

Comment 10

[bismarck369tirpitz]

It must be firefox not the addon i have installed the firefox 53.0.3 (64-Bit) and uninstalled (i have done a clean install with using the ccleaner) the nightly and now it runs!

Thank you both so much :)

Comment 11

[Loic]

STR:

1) Install the add-on "ExHentai Easy 2" https://addons.mozilla.org/en-US/firefox/addon/exhentai-easy-2/
2) Open https://exhentai.org/login
3) Enter credentials:
Username: bugzilla2
Password: azerty123!
4) Check the box "Remember me" and press the button "Sign in"

AR: error message "Error: Login Failure!"

ER: the login page should blink and reload (the account has not been approved on exhentai.org so the login is reloaded, but whatever)

Regression range:
https://hg.mozilla.org/integration/mozilla-inbound/pushloghtml?fromchange=2e07ae5b0b69519a59d2943b95534bade9b68758&tochange=8cb64c677091fe3f8ae587e931a5ffe24b997972

Shawn Huang — Bug 1348390 - Sort and lowercase response's header lists for getAllResponseHeaders(), r=baku

Comment 12

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

I set pref 'dom.xhr.lowercase_header.enabled' to false. Then I sign in, I don't see error 'Login Failure', but reload the page again. So it's related to lowercased header change.

Comment 13

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

https://github.com/haruhichan/exhentai-plugins/blob/master/firefox/data/js/exhentai.js#L44
ipb_session_id = /[0-9a-f]{32}/i.exec(r.headers['Set-Cookie']);

It checks 'Set-Cookie' header name, which causes 'ipb_session_id' is null.

Comment 14

[Loic]

Is it more a Tech Evangelism bug, like fixing the JS script on the server side?

Comment 15

[Andrew Overholt [:overholt]]

For comment 14.

Comment 16

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

(In reply to Loic from comment #14)
> Is it more a Tech Evangelism bug, like fixing the JS script on the server
> side?
Like in Comment 13, ExHentai addon should use 'lowercase' response header name in exhentai.js.

I will pref-off for now, since Safari and Chrome are going to use lowercase response header name in the future. Considering compat issues are massive.

Comment 17

[Julien Cristau [:jcristau]]

Tracking bug 1370485, and there doesn't seem to be a need to track this as well.

Comment 18

[Hsin-Yi Tsai (she/her) [:hsinyi]]

As we flipped a preference which was believed caused this regression, this issue should be no longer existing now. 

Would either of you help confirm the issue has been resolved, Loic and bismarck369tirpitz? Thank you!

Comment 19

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

bug 1370485 landed, so close this bug.

Comment 20

[Loic]

It works with the addon now.

Comment 21

[bismarck369tirpitz]

(In reply to Loic from comment #20)
> It works with the addon now.

(In reply to Shawn Huang [:shawnjohnjr] from comment #19)
> bug 1370485 landed, so close this bug.

(In reply to Hsin-Yi Tsai (55 Regression Engineering support) [:hsinyi] from comment #18)
> As we flipped a preference which was believed caused this regression, this
> issue should be no longer existing now. 
> 
> Would either of you help confirm the issue has been resolved, Loic and
> bismarck369tirpitz? Thank you!

(In reply to Julien Cristau [:jcristau] from comment #17)
> Tracking bug 1370485, and there doesn't seem to be a need to track this as
> well.

(In reply to Shawn Huang [:shawnjohnjr] from comment #16)
> (In reply to Loic from comment #14)
> > Is it more a Tech Evangelism bug, like fixing the JS script on the server
> > side?
> Like in Comment 13, ExHentai addon should use 'lowercase' response header
> name in exhentai.js.
> 
> I will pref-off for now, since Safari and Chrome are going to use lowercase
> response header name in the future. Considering compat issues are massive.

(In reply to krithivelan25 from comment #6)
> I have tested this bug with the windows 7 - 64 bit machine 
> 
> I have created an account with the following link
> https://forums.e-hentai.org/index.php?act=Reg&CODE=00
> 
> But the link did not respond it was reloading after entering my password
> with the add on ExHentai Easy 2 v.0.2.9

Thank you all so much for helping me out and for keeping firefox free for all and save against the google chrome spy browser :)

Comment 22

[Shawn Huang [:shawnjohnjr][:shuang] (as a happy gecko contributor)]

I think we will eventually change this behavior. 

See:
https://github.com/whatwg/xhr/issues/146