Closed Bug 1367761 Opened 7 years ago Closed 7 years ago

Arrow for photon hamburger arrow panel doesn't blend in anymore

Categories

(Firefox :: Theme, defect, P1)

Product:
Firefox
Component:
Theme
Version:
53 Branch
Type:
defect

Tracking

()

Status:
VERIFIED FIXED
Milestone:
Firefox 55
Iteration:
55.6 - May 29
Tracking Flags:
Tracking Status
firefox-esr52 --- unaffected
firefox53 --- unaffected
firefox54 --- unaffected
firefox55 --- verified

People

(Reporter: Gijs, Assigned: Paolo)

References

(Blocks 1 open bug)

Details

(Keywords: regression, Whiteboard: [photon-structure])

Attachments

(2 files)

Screenshot
3.58 KB, image/png
Details
Bug 1367761 - Restore outer margin in the Photon panels.
59 bytes, text/x-review-board-request
Gijs
: review+
Details 
This is a regression from bug 1009116 (checked with mozregression). I see this on Windows, haven't tested other platforms.
Flags: qe-verify+
Attached image Screenshot — 

    
    

    
  
I'm confused how this regressed, because the changes weren't meant to change anything for photon, AIUI.

(I see this whenever I open the panel menu by clicking the hamburger button)
Blocks: photon-structure
Has Regression Range: --- → yes
Has STR: --- → yes

          status-firefox55:
          --- → affected

    
    

    
  
Ah, looking at this again, maybe this code:

https://hg.mozilla.org/mozilla-central/rev/2d16236446af#l3.328

needed to be conditional on non-Photon, or something? Paolo?
Flags: needinfo?(paolo.mozmail)
Priority: P1 → --
Whiteboard: [photon-structure] → [photon-structure] [triage]

    
    

    
  
(In reply to :Gijs from comment #3)
> https://hg.mozilla.org/mozilla-central/rev/2d16236446af#l3.328
> needed to be conditional on non-Photon, or something? Paolo?

The event should be only registered for non-Photon already, but it might be something else. I'll look into this.
Flags: needinfo?(paolo.mozmail)
Priority: -- → P2
Whiteboard: [photon-structure] [triage] → [photon-structure]

    
    

    
  
Ah, so the Photon arrow is supposed to be smaller on Windows? This might be a z-order issue of some sort, and the fact the arrow is the same on Mac OS X is why the issue doesn't happen there.

    
    

    
      
  


  
Assignee: nobody → paolo.mozmail
Status: NEW → ASSIGNED
Priority: P2 → P1

    
    

    
  
(In reply to :Paolo Amadini from comment #5)
> Ah, so the Photon arrow is supposed to be smaller on Windows?

Turns out this isn't the case, posted an updated patch.

    
    

    
      
  

    
    

    
  
Comment on attachment 8871321 [details]
Bug 1367761 - Restore outer margin in the Photon panels.

https://reviewboard.mozilla.org/r/142794/#review146854

        Attachment #8871321 -
        Flags: review?(gijskruitbosch+bugs) → review+

    
    

    
  
Pushed by paolo.mozmail@amadzone.org:
https://hg.mozilla.org/integration/autoland/rev/e7efc643bc07
Restore outer margin in the Photon panels. r=Gijs

    
    

    
  
https://hg.mozilla.org/mozilla-central/rev/e7efc643bc07
Status: ASSIGNED → RESOLVED
Closed: 7 years ago

          status-firefox55:
          affected → fixed
Resolution: --- → FIXED
Target Milestone: --- → Firefox 55
Iteration: --- → 55.6 - May 29

    
    

    
  
Verified on Windows, Mac, and Ubuntu.
Status: RESOLVED → VERIFIED

          status-firefox55:
          fixed → verified
Flags: qe-verify+

    
  
Blocks: 1387512

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: