1367806 - Crash in PostToPluginThread

Status: RESOLVED FIXED

(Core Graveyard :: Plug-ins, defect)

Description

[Calixte Denizet (:calixte)]

This bug was filed from the Socorro interface and is 
report bp-72b85d41-f83c-46b3-bc62-4867e0170525.
=============================================================

There are 11 crashes (from the same installation) in nightly 55 with buildid 20170525030225. In analyzing the backtrace, the regression may have been introduced by patch [1] to fix bug 1363290.

[1] https://hg.mozilla.org/mozilla-central/rev?node=1da418fade04a81632e3057adea1dfde1a57323d

Comment 1

[David Parks [:handyman]]

Attachment: Fix ref counting of tasks for remoted Win32 methods in plugin processes

Cut-and-paste manual refcount bug from patches from bug 1363290.  The issue is obvious (use-after-forget).

Simple STR:

1. Go to http://www.tinywebgallery.com/en/tfu/web_demo2.php
2. Click "Add Files"
3. Choose a small image to upload.

Expected:

Plugin shows the file in the upload queue.

Actual:

CRASH!  Plugin Process crash dialog is shown.

Comment 2

[David Parks [:handyman]]

Tests: https://treeherder.mozilla.org/#/jobs?repo=try&revision=d27e46d5b418c9f67932c9ef87893c1cd76b6b1b

Comment 3

[Nicholas Nethercote [inactive]]

This is the #4 Windows topcrash in Nightly 20170526030203.

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/fe7cead49195
Fix ref counting of tasks for remoted Win32 methods in plugin processes. r=jimm

Comment 5

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/fe7cead49195