Don't throttle playback unless the network is "fast", rather than unless we've hit "canplaythrough"

RESOLVED FIXED in Firefox 55

Status

()

Core
Audio/Video: Playback
P1
normal
RESOLVED FIXED
9 months ago
9 months ago

People

(Reporter: cpearce, Assigned: cpearce)

Tracking

unspecified
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(1 attachment)

(Assignee)

Description

9 months ago
I'm not satisfied with the work in 1364001, so I'm taking it upon myself to satisfy myself.

My concern is that people with slow connections will suffer from "buffering anxiety", and will in fact want to buffer the entire resource, irrespective of the "canplaythrough" state. i.e., they won't want the download to stop part way through once we've downloaded enough that our canplaythrough logic thinks the remaining part of the file can be played without needing to stop to buffer. Users on slow connections are more likely to want to download the entire resource, even if that may not be strictly necessary.

That is certainly what I have wanted in the past when I have had trouble with a slow connection.

So I think we should change so that we only throttle the download when we hit the readahead limit on desktop only when the connection is fast enough that the user is unlikely to have buffering anxiety. I don't think we should use the canplaythrough logic to gate throttling.

Also, we should not be changing the behaviour of Firefox for Android here; on Android the calculus is different as typically data connections are metered and battery life is also an issue. So we should revert to the old behaviour of throttling when the readahead limit is hit irrespective of the network speed/canplaythrough state on mobile.
Comment hidden (mozreview-request)

Comment 2

9 months ago
mozreview-review
Comment on attachment 8871573 [details]
Bug 1367950 - Only throttle download of src=url video if the download is 'fast' on desktop.

https://reviewboard.mozilla.org/r/143054/#review146804

It is hard to assume the user intention for best user experience. Without throttling, we will bring bug 1347174 back where user on slow connection will wait for the entire file to be buffered which however will never happen due to the limited cache size and all bandwidth in the end is wasted in downloading and discarding data (see bug 1347174 comment 10 for the detail). We need to figure out a way to solve bug 1347174 correctly.
Attachment #8871573 - Flags: review?(jwwang) → review+

Comment 3

9 months ago
Pushed by cpearce@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/b597ea8f9bb4
Only throttle download of src=url video if the download is 'fast' on desktop. r=jwwang
https://hg.mozilla.org/mozilla-central/rev/b597ea8f9bb4
Status: NEW → RESOLVED
Last Resolved: 9 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.