Drop New Tab From All Firefox Sources

VERIFIED FIXED

Status

()

VERIFIED FIXED
a year ago
8 months ago

People

(Reporter: sdaswani, Assigned: bmunar)

Tracking

unspecified
Other
iOS

Firefox Tracking Flags

(fxios8.0+, fxios-v8.3 verified)

Details

(Whiteboard: [mma] [MobileCore][b3])

Attachments

(2 attachments)

(Reporter)

Description

a year ago
The user can open a new tab from multiple places, so ensure we drop the leanplum event from all those sources.
(Reporter)

Comment 1

a year ago
See this comment for more info: https://github.com/mozilla-mobile/firefox-ios/pull/2711/files#diff-6d1fb0cf203fcd3c299d4ba3f07f21deR1336
Assignee: nobody → bmunar
Blocks: 1351446
Whiteboard: [mma]
(Reporter)

Comment 2

a year ago
For all the different sources, drop a new value:

[Leanplum track:@"Opened New Tab" withValue:"New Tab Button"];
(Assignee)

Comment 3

a year ago
Created attachment 8873577 [details] [review]
PR
Attachment #8873577 - Flags: review?(sdaswani)
(Reporter)

Updated

a year ago
Attachment #8873577 - Flags: review?(sdaswani) → review+
(Reporter)

Updated

a year ago
Whiteboard: [mma] → [mma] [MobileCore][needsuplift]
tracking-fxios: --- → 8.0+
(Reporter)

Updated

a year ago
Status: NEW → RESOLVED
Last Resolved: a year ago
Resolution: --- → FIXED
Attachment #8873577 - Flags: review?(sarentz)
(Reporter)

Comment 5

a year ago
Please address this issue: https://github.com/mozilla-mobile/firefox-ios/pull/2783#discussion_r121005973
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Whiteboard: [mma] [MobileCore][needsuplift] → [mma] [MobileCore]
Whiteboard: [mma] [MobileCore] → [mma] [MobileCore][b3]
Attachment #8877646 - Flags: review?(sarentz) → review+
New PR is merged to master and uplifted to v8.x
Status: REOPENED → RESOLVED
Last Resolved: a year agoa year ago
Resolution: --- → FIXED
Verifying as fix on beta 8.3(5817).
Status: RESOLVED → VERIFIED
status-fxios-v8.3: --- → verified

Updated

8 months ago
Attachment #8873577 - Flags: review?(sarentz)
You need to log in before you can comment on or make changes to this bug.