1367968 - Drop New Tab From All Firefox Sources

Status: VERIFIED FIXED

(Firefox for iOS :: Telemetry, enhancement)

Description

[:sdaswani]

The user can open a new tab from multiple places, so ensure we drop the leanplum event from all those sources.

Comment 1

[:sdaswani]

See this comment for more info: https://github.com/mozilla-mobile/firefox-ios/pull/2711/files#diff-6d1fb0cf203fcd3c299d4ba3f07f21deR1336

Comment 2

[:sdaswani]

For all the different sources, drop a new value:

[Leanplum track:@"Opened New Tab" withValue:"New Tab Button"];

Comment 3

[Bryan Munar (:bkmunar)]

Attachment: PR

Comment 4

[Bryan Munar (:bkmunar)]

https://github.com/mozilla-mobile/firefox-ios/pull/2783/commits/a6b601e5e5e51714a0dcdf4159e4da18ca67eec1

Comment 5

[:sdaswani]

Please address this issue: https://github.com/mozilla-mobile/firefox-ios/pull/2783#discussion_r121005973

Comment 6

[Bryan Munar (:bkmunar)]

https://github.com/mozilla-mobile/firefox-ios/pull/2803 -> new PR

Comment 7

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

Attachment: PR https://github.com/mozilla-mobile/firefox-ios/pull/2803

Comment 8

[Stefan Arentz | :st3fan | ⏰ EST | he/him]

New PR is merged to master and uplifted to v8.x

Comment 9

[Simon Basca [:SimonB]]

Verifying as fix on beta 8.3(5817).