1367970 - Weird popup effect in the Send to Device Photon menu

Status: VERIFIED FIXED

(Firefox :: Toolbars and Customization, defect, P1)

Description

[(no longer active)]

Attachment: Screencast 2017-05-26 01:41:19.mp4

See the screencast, it should be self explanatory.

Comment 1

[:Gijs (he/him)]

(In reply to :Ehsan Akhgari (needinfo please, extremely long backlog) from comment #0)
> Created attachment 8871594 [details]
> Screencast 2017-05-26 01:41:19.mp4
> 
> See the screencast, it should be self explanatory.

"Video can't be played because the file is corrupt." on both nightly and beta. So no, not really. :-(

Comment 2

[(no longer active)]

(In reply to :Gijs from comment #1)
> (In reply to :Ehsan Akhgari (needinfo please, extremely long backlog) from
> comment #0)
> > Created attachment 8871594 [details]
> > Screencast 2017-05-26 01:41:19.mp4
> > 
> > See the screencast, it should be self explanatory.
> 
> "Video can't be played because the file is corrupt." on both nightly and
> beta. So no, not really. :-(

Try downloading the file and use a desktop video player please.

Comment 3

[Mike Conley (:mconley) (:⚙️)]

Attachment: Screencast 2017-05-26 01:41:19.ogg

This one plays for me.

Comment 4

[Mike de Boer [:mikedeboer]]

Thanks for filing, Ehsan... looks interesting.

(In reply to Mike Conley (:mconley) from comment #3)
> This one plays for me.

Thanks! Ehsan's also plays on VLC as well, but this is more convenient ;-)

Comment 5

[Mike de Boer [:mikedeboer]]

Another way to reproduce this is using the back-arrow key:

1. Open a subview in the main panel and keep you mouse hovering that button position,
2. Right when the subview is visible, press back,
3. Right when the main view is visible again click the same button again (even though the pointer may not be visible at that point).

Comment 6

[Mike de Boer [:mikedeboer]]

Attachment: Bug 1367970 - when switching panels quickly, the auto-resize workaround can cause wonky animations. Clear the timeout when a new animation starts.

Review commit: https://reviewboard.mozilla.org/r/144926/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/144926/

Comment 7

[:Gijs (he/him)]

Comment on attachment 8873542 [details]
Bug 1367970 - when switching panels quickly, the auto-resize workaround can cause wonky animations. Clear the timeout when a new animation starts.

https://reviewboard.mozilla.org/r/144926/#review149168

This doesn't seem to fix the jumping I see in the library panel when opening either of the subviews (synced tabs or history).

Comment 8

[Mike de Boer [:mikedeboer]]

(In reply to :Gijs from comment #7)
> This doesn't seem to fix the jumping I see in the library panel when opening
> either of the subviews (synced tabs or history).

That's an entirely different issue, but I'll try to fix that here too then.

Comment 9

[Mike de Boer [:mikedeboer]]

Comment on attachment 8873542 [details]
Bug 1367970 - when switching panels quickly, the auto-resize workaround can cause wonky animations. Clear the timeout when a new animation starts.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/144926/diff/1-2/

Comment 10

[:Gijs (he/him)]

Comment on attachment 8873542 [details]
Bug 1367970 - when switching panels quickly, the auto-resize workaround can cause wonky animations. Clear the timeout when a new animation starts.

https://reviewboard.mozilla.org/r/144926/#review149208

::: browser/components/customizableui/content/panelUI.js:494
(Diff revision 2)
>          multiView.setAttribute("mainViewId", viewNode.id);
>          multiView.appendChild(viewNode);
>        }
>        tempPanel.appendChild(multiView);
> +      if (!gPhotonStructure) {
> -      multiView.setAttribute("mainViewIsSubView", "true");
> +        multiView.setAttribute("mainViewIsSubView", "true");

I can't find any code that cares about this, or the showingSubViewAsMainView bool that it influences...

::: browser/themes/shared/customizableui/panelUI.inc.css:265
(Diff revision 2)
> +panel[photon] > .panel-arrowcontainer > .panel-arrowcontent {
>    overflow: hidden;

I'm not sure this works. If I open the synced tab view now, in the library, inside the main hamburger panel, the subview gets a scrollbar but there's oodles of space at the bottom of the panel.

I also see odd flashes when opening the history view in the standalone library panel.

Comment 11

[Mike de Boer [:mikedeboer]]

(In reply to :Gijs from comment #10)
> I can't find any code that cares about this, or the showingSubViewAsMainView
> bool that it influences...

I can remove it. I hate dead code.

> I'm not sure this works. If I open the synced tab view now, in the library,
> inside the main hamburger panel, the subview gets a scrollbar but there's
> oodles of space at the bottom of the panel.
> 
> I also see odd flashes when opening the history view in the standalone
> library panel.


I can leave this part out... I'd like to land the bit specific to the general issue for sure, since the library panel is suffering from more than this one.

Comment 12

[:Gijs (he/him)]

(In reply to Mike de Boer [:mikedeboer] from comment #11)
> (In reply to :Gijs from comment #10)
> > I can't find any code that cares about this, or the showingSubViewAsMainView
> > bool that it influences...
> 
> I can remove it. I hate dead code.
> 
> > I'm not sure this works. If I open the synced tab view now, in the library,
> > inside the main hamburger panel, the subview gets a scrollbar but there's
> > oodles of space at the bottom of the panel.
> > 
> > I also see odd flashes when opening the history view in the standalone
> > library panel.
> 
> 
> I can leave this part out... I'd like to land the bit specific to the
> general issue for sure, since the library panel is suffering from more than
> this one.

Alright, let's go with this, then.

Comment 13

[Mike de Boer [:mikedeboer]]

Comment on attachment 8873542 [details]
Bug 1367970 - when switching panels quickly, the auto-resize workaround can cause wonky animations. Clear the timeout when a new animation starts.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/144926/diff/2-3/

Comment 14

[:Gijs (he/him)]

Comment on attachment 8873542 [details]
Bug 1367970 - when switching panels quickly, the auto-resize workaround can cause wonky animations. Clear the timeout when a new animation starts.

https://reviewboard.mozilla.org/r/144926/#review150248

So r=me in that this makes at least one part of this better. We probably need to have a followup to fix more of this.

Comment 15

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/c27161891c66
when switching panels quickly, the auto-resize workaround can cause wonky animations. Clear the timeout when a new animation starts. r=Gijs

Comment 16

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/c27161891c66

Comment 17

[u554753]

Verified on Windows, Mac, and Ubuntu.