Closed
Bug 1368038
Opened 8 years ago
Closed 8 years ago
Causes FTBFS on mips and mipsel due to undefined ABI
Categories
(NSPR :: NSPR, defect)
Tracking
(Not tracked)
RESOLVED
FIXED
4.16
People
(Reporter: bigon, Assigned: glandium)
References
Details
Attachments
(1 file)
|
638 bytes,
patch
|
KaiE
:
review+
|
Details | Diff | Splinter Review |
Hi,
On mips and mipsel on debian, nspr is causing libreswan to FTBFS
According to the bugreport:
==========
On 32-bit mips (ABIO32) _ABI64 is not defined and build fails if Wundef is used.
Problem could be resolved by including <sgidefs.h> header (which includes ABI definitions) into "_linux.cfg" file.
Another way to solve the problem could be changing "#if _MIPS_SIM == _ABI64" expression (if defined _ABI64 has value 3).
> $ gcc -dM -E -mabi=64 - < /dev/null | grep --color -s "ABI"
> #define _ABI64 3
> #define _MIPS_SIM _ABI64
==========
An other solution might be to test defined(__mips64) instead
https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=854472
|
Reporter | |
Comment 1•8 years ago
|
||
FTR, I think that this issue has been introduced in bug #1199867
|
Assignee | |
Comment 2•8 years ago
|
||
Assignee: nobody → mh+mozilla
Attachment #8878692 -
Flags: review?(kaie)
|
||
Comment 3•8 years ago
|
||
Comment on attachment 8878692 [details] [diff] [review]
Fix missing _ABI64 definition on 32-bits mips
r=kaie
Attachment #8878692 -
Flags: review?(kaie) → review+
|
|
||
Comment 4•8 years ago
|
||
Mike, please let me know if you want me to land it.
Status: UNCONFIRMED → NEW
Ever confirmed: true
Flags: needinfo?(mh+mozilla)
Keywords: checkin-needed
Target Milestone: --- → 4.16
|
|
Assignee | |
Comment 5•8 years ago
|
||
Status: NEW → RESOLVED
Closed: 8 years ago
Flags: needinfo?(mh+mozilla)
Resolution: --- → FIXED
|
||
Updated•8 years ago
|
Keywords: checkin-needed
You need to log in
before you can comment on or make changes to this bug.
Description
•