1368159 - Tweak error log line to warn or info at ice_ctx.c:710

Status: RESOLVED FIXED

(Core :: WebRTC: Networking, enhancement, P2)

Description

[Michael Froman [:mjf]]

This isn't really an error since it can happen each time PeerConnectionMedia::EnsureTransports() -> GatherIfReady() -> EnsureIceGathering_s() is called.

Comment 1

[Michael Froman [:mjf]]

Attachment: Bug 1368159 - change log statement for pre-existing local addresses from error to warning in nr_ice_set_local_addresses.

When I added this check during the modifications for Bug 1345511 (Move
nICEr stun local address discovery to an IPC call to enable future
sandbox restrictions on content process) I originally thought this was
more of an error condition, but it really isn't.  It can happen each
time the following method(s) is called:
  PeerConnectionMedia::EnsureTransports() ->
    GatherIfReady() ->
      EnsureIceGathering_s()

Review commit: https://reviewboard.mozilla.org/r/146822/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/146822/

Comment 2

[Nils Ohlmeier [:drno]]

Comment on attachment 8875388 [details]
Bug 1368159 - change log statement for pre-existing local addresses from error to warning in nr_ice_set_local_addresses.

https://reviewboard.mozilla.org/r/146822/#review151102

Comment 3

[Michael Froman [:mjf]]

Comment on attachment 8875388 [details]
Bug 1368159 - change log statement for pre-existing local addresses from error to warning in nr_ice_set_local_addresses.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/146822/diff/1-2/

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/9d487a816000
change log statement for pre-existing local addresses from error to warning in nr_ice_set_local_addresses. r=drno

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/9d487a816000