1368182 - Port non-e10s compatible parts of states/test_visibility.html

Status: RESOLVED FIXED

(Core :: Disability Access APIs, enhancement)

Description

[Eitan Isaacson [:eeejay]]

The current test opens a couple of tabs, we can't do that from mochitests with e10s turned on.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: Port non-e10s compatible parts of states/test_visibility.html to browser test. r?surkov

MozReview-Commit-ID: 7AJraBDrPJX

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: Port non-e10s compatible parts of states/test_visibility.html to browser test. r?surkov

MozReview-Commit-ID: 7AJraBDrPJX

Comment 3

[alexander :surkov (:asurkov)]

Comment on attachment 8871964 [details] [diff] [review]
Port non-e10s compatible parts of states/test_visibility.html to browser test. r?surkov

Review of attachment 8871964 [details] [diff] [review]:
-----------------------------------------------------------------

::: accessible/tests/browser/states/browser_test_visibility.js
@@ +30,5 @@
> +    // first item is scrolled off now (testcase for bug 768786)
> +    let firstLi = getAcc("li_first");
> +    testStates(firstLi, STATE_OFFSCREEN, 0, STATE_INVISIBLE);
> +
> +    let newTab = await BrowserTestUtils.openNewForegroundTab(gBrowser);

it'd be nice to move comment "// Accessibles in background tab should have offscreen state and no	
// invisible state." too

::: accessible/tests/mochitest/states/test_visibility.html
@@ -16,3 @@
>            src="../states.js"></script>
>    <script type="application/javascript"
>            src="../events.js"></script>

no event.js should be required

@@ -16,5 @@
>            src="../states.js"></script>
>    <script type="application/javascript"
>            src="../events.js"></script>
>    <script type="application/javascript"
>            src="../browser.js"></script>

and browser.js I suppose

Comment 4

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/mozilla-inbound/rev/e2cf349598c8
Port non-e10s compatible parts of states/test_visibility.html to browser test. r=surkov

Comment 5

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/e2cf349598c8