1368216 - [flake8] Python code in browser should follow flake8 convention

Status: RESOLVED WONTFIX

(Developer Infrastructure :: Source Code Analysis, enhancement)

Description

[Emin Mastizada]

Python code in browser folder needs update for pep8 style guide using flake8

Comment 1

[Emin Mastizada]

Attachment: Bug 1368216 - Python files under browser/ folder updated to match PEP8 style guide.

Review commit: https://reviewboard.mozilla.org/r/143542/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143542/

Comment 2

[Emin Mastizada]

Some python files in browser/extensions are missing, want to check if everything is done right before going further.

Also there are some errors, like missing filename variable in one function.

Also currently ignoring "__pychecker__" variables (not used warning).

Comment 3

[Emin Mastizada]

Comment on attachment 8872008 [details]
Bug 1368216 - Python files under browser/ folder updated to match PEP8 style guide.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143542/diff/1-2/

Comment 4

[Sylvestre Ledru [:Sylvestre]]

Comment on attachment 8872008 [details]
Bug 1368216 - Python files under browser/ folder updated to match PEP8 style guide.

One is enough. I kept Peter because he reviewed similar patches.

Comment 5

[Peter Van der Beken [:peterv]]

Comment on attachment 8872008 [details]
Bug 1368216 - Python files under browser/ folder updated to match PEP8 style guide.

https://reviewboard.mozilla.org/r/143542/#review172692

::: browser/extensions/mortar/ppapi/generators/generator.py:1
(Diff revision 2)
>  #!/usr/bin/env python

This is an imported file from chromium, so we shouldn't change it to avoid making updates from upstream harder.

::: browser/extensions/mortar/ppapi/generators/idl_ast.py:1
(Diff revision 2)
>  # Copyright (c) 2012 The Chromium Authors. All rights reserved.

Imported.

::: browser/extensions/mortar/ppapi/generators/idl_diff.py:1
(Diff revision 2)
>  #!/usr/bin/env python

Imported.

::: browser/extensions/mortar/ppapi/generators/idl_generator.py:1
(Diff revision 2)
>  #!/usr/bin/env python

Imported.

::: browser/extensions/mortar/ppapi/generators/idl_namespace.py:1
(Diff revision 2)
>  #!/usr/bin/env python

Imported.

::: browser/extensions/mortar/ppapi/generators/idl_node.py:24
(Diff revision 2)
>  import sys
>  
>  from idl_log import ErrOut, InfoOut, WarnOut
>  from idl_propertynode import IDLPropertyNode
>  from idl_release import IDLRelease, IDLReleaseMap
>  

Imported.

::: browser/extensions/mortar/ppapi/generators/idl_option.py:1
(Diff revision 2)
>  # Copyright (c) 2012 The Chromium Authors. All rights reserved.

Imported.

::: browser/extensions/mortar/ppapi/generators/idl_outfile.py:1
(Diff revision 2)
>  #!/usr/bin/env python

Imported.

::: browser/extensions/mortar/ppapi/generators/idl_parser.py:17
(Diff revision 2)
>  # on WebIDL.
>  #
>  # WebIDL, and WebIDL regular expressions can be found at:
>  #   http://dev.w3.org/2006/webapi/WebIDL/
>  # PLY can be found at:
>  #   http://www.dabeaz.com/ply/

Imported.

::: browser/extensions/mortar/ppapi/generators/idl_propertynode.py:1
(Diff revision 2)
>  #!/usr/bin/env python

Imported.

::: browser/extensions/mortar/ppapi/generators/idl_release.py:1
(Diff revision 2)
>  #!/usr/bin/env python

Imported.

::: browser/extensions/mortar/ppapi/generators/idl_tests.py:1
(Diff revision 2)
>  #!/usr/bin/env python

Imported.

::: browser/extensions/mortar/ppapi/generators/idl_visitor.py:1
(Diff revision 2)
>  # Copyright (c) 2012 The Chromium Authors. All rights reserved.

Imported.

Comment 6

[Sylvestre Ledru [:Sylvestre]]

No activity for a while, closing.