1368251 - Check frame's NS_FRAME_HAS_INVALID_RECT bit before looking up the InvalidationRect() property

Status: RESOLVED FIXED

(Core :: Layout, enhancement)

Description

[Jonathan Kew [:jfkthame]]

From bug 1365982 comment 14:
----------------------------
> nsIFrame::InvalidateFrameSubtree(uint32_t aDisplayItemKey)
>-  nsRect* rect = Properties().Get(InvalidationRect());
>+  nsRect* rect = GetProperty(InvalidationRect());

Hmm, shouldn't we check HasAnyStateBits(NS_FRAME_HAS_INVALID_RECT)
before doing this Get? (and assert a non-null result in that case)
----------------------------

Comment 1

[Jonathan Kew [:jfkthame]]

Attachment: Check frame state bit before looking up InvalidationRect() property

Comment 2

[Jonathan Kew [:jfkthame]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/6414aec048aea01d726832dec33e83f3d8503f0c
Bug 1368251 - Check frame state bit before looking up InvalidationRect() property. r=mats

Comment 3

[Sebastian Hengst [:aryx] (needinfo me if it's about an intermittent or backout)]

https://hg.mozilla.org/mozilla-central/rev/6414aec048ae