Closed Bug 1368376 Opened 3 years ago Closed 3 years ago
stylo: Support current
Color for fill and stroke properties
Currently we are converting current-color to rgba(0, 0, 0, 0)  https://hg.mozilla.org/mozilla-central/file/4541134e973a/servo/components/style/properties/gecko.mako.rs#l441
Gecko currently doesn't seem to support computed-value time currentcolor for fill and stroke either, so we can probably just follow Gecko's behavior here and use the value from color property here, which shouldn't be too hard I suppose.
Thank you Xidorn. I am glad that you noticed that this bug is for stylo even though the summary has no 'stylo' at all. :-)
Summary: Support currentColor for fill and stroke properties → sylo: Support currentColor for fill and stroke properties
Assignee: nobody → hikezoe
Status: NEW → ASSIGNED
There are so many different color types... Some of them have ToComputedValue in one way, some in the other way... I probably need to understand the situation first...
Comment on attachment 8872466 [details] Bug 1368376 - Support currentColor for fill and stroke. https://reviewboard.mozilla.org/r/143972/#review147744 So this changes it to use color value from the current style rather than the inherited style. This makes sense, but we probably really need a more fundamental fix for currentcolor. I guess this is fine for now as far as it fixes failures.
Attachment #8872466 - Flags: review?(xidorn+moz) → review+
Comment on attachment 8872467 [details] Bug 1368376 - Update reftest expectations. https://reviewboard.mozilla.org/r/143974/#review147746
Attachment #8872467 - Flags: review?(xidorn+moz) → review+
Thank you Xidorn, I am really glad that you will take care of interpolation for currentColor. https://github.com/servo/servo/pull/17089
Attachment #8872466 - Attachment is obsolete: true
Pushed by firstname.lastname@example.org: https://hg.mozilla.org/integration/autoland/rev/29177506860d Update reftest expectations. r=xidorn
Summary: sylo: Support currentColor for fill and stroke properties → stylo: Support currentColor for fill and stroke properties
You need to log in before you can comment on or make changes to this bug.