stylo: Support currentColor for fill and stroke properties

RESOLVED FIXED in Firefox 55

Status

()

enhancement
RESOLVED FIXED
2 years ago
2 years ago

People

(Reporter: hiro, Assigned: hiro)

Tracking

Trunk
mozilla55
Points:
---
Dependency tree / graph

Firefox Tracking Flags

(firefox55 fixed)

Details

Attachments

(1 attachment, 1 obsolete attachment)

Gecko currently doesn't seem to support computed-value time currentcolor for fill and stroke either, so we can probably just follow Gecko's behavior here and use the value from color property here, which shouldn't be too hard I suppose.
Assignee

Comment 2

2 years ago
Thank you Xidorn.  I am glad that you noticed that this bug is for stylo even though the summary has no 'stylo' at all. :-)
Summary: Support currentColor for fill and stroke properties → sylo: Support currentColor for fill and stroke properties
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
There are so many different color types... Some of them have ToComputedValue in one way, some in the other way... I probably need to understand the situation first...

Comment 7

2 years ago
mozreview-review
Comment on attachment 8872466 [details]
Bug 1368376 - Support currentColor for fill and stroke.

https://reviewboard.mozilla.org/r/143972/#review147744

So this changes it to use color value from the current style rather than the inherited style. This makes sense, but we probably really need a more fundamental fix for currentcolor. I guess this is fine for now as far as it fixes failures.
Attachment #8872466 - Flags: review?(xidorn+moz) → review+

Comment 8

2 years ago
mozreview-review
Comment on attachment 8872467 [details]
Bug 1368376 - Update reftest expectations.

https://reviewboard.mozilla.org/r/143974/#review147746
Attachment #8872467 - Flags: review?(xidorn+moz) → review+
Assignee

Comment 9

2 years ago
Thank you Xidorn, I am really glad that you will take care of interpolation for currentColor. 

https://github.com/servo/servo/pull/17089
Comment hidden (mozreview-request)
Assignee

Updated

2 years ago
Attachment #8872466 - Attachment is obsolete: true

Comment 11

2 years ago
Pushed by hikezoe@mozilla.com:
https://hg.mozilla.org/integration/autoland/rev/29177506860d
Update reftest expectations. r=xidorn

Comment 12

2 years ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/29177506860d
Status: ASSIGNED → RESOLVED
Closed: 2 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
Summary: sylo: Support currentColor for fill and stroke properties → stylo: Support currentColor for fill and stroke properties
You need to log in before you can comment on or make changes to this bug.