1368376 - stylo: Support currentColor for fill and stroke properties

Status: RESOLVED FIXED

(Core :: CSS Parsing and Computation, enhancement)

Description

[Hiroyuki Ikezoe (:hiro)]

Currently we are converting current-color to rgba(0, 0, 0, 0) [1]

https://hg.mozilla.org/mozilla-central/file/4541134e973a/servo/components/style/properties/gecko.mako.rs#l441

Comment 1

[Xidorn Quan [:xidorn] UTC+10]

Gecko currently doesn't seem to support computed-value time currentcolor for fill and stroke either, so we can probably just follow Gecko's behavior here and use the value from color property here, which shouldn't be too hard I suppose.

Comment 2

[Hiroyuki Ikezoe (:hiro)]

Thank you Xidorn.  I am glad that you noticed that this bug is for stylo even though the summary has no 'stylo' at all. :-)

Comment 3

[Hiroyuki Ikezoe (:hiro)]

https://treeherder.mozilla.org/#/jobs?repo=try&revision=5fb4665ea1517350d1872568d9b5b0e7fbb13470

Comment 4

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1368376 - Support currentColor for fill and stroke.

Review commit: https://reviewboard.mozilla.org/r/143972/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143972/

Comment 5

[Hiroyuki Ikezoe (:hiro)]

Attachment: Bug 1368376 - Update reftest expectations.

Review commit: https://reviewboard.mozilla.org/r/143974/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143974/

Comment 6

[Xidorn Quan [:xidorn] UTC+10]

There are so many different color types... Some of them have ToComputedValue in one way, some in the other way... I probably need to understand the situation first...

Comment 7

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8872466 [details]
Bug 1368376 - Support currentColor for fill and stroke.

https://reviewboard.mozilla.org/r/143972/#review147744

So this changes it to use color value from the current style rather than the inherited style. This makes sense, but we probably really need a more fundamental fix for currentcolor. I guess this is fine for now as far as it fixes failures.

Comment 8

[Xidorn Quan [:xidorn] UTC+10]

Comment on attachment 8872467 [details]
Bug 1368376 - Update reftest expectations.

https://reviewboard.mozilla.org/r/143974/#review147746

Comment 9

[Hiroyuki Ikezoe (:hiro)]

Thank you Xidorn, I am really glad that you will take care of interpolation for currentColor. 

https://github.com/servo/servo/pull/17089

Comment 10

[Hiroyuki Ikezoe (:hiro)]

Comment on attachment 8872467 [details]
Bug 1368376 - Update reftest expectations.

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143974/diff/1-2/

Comment 11

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/29177506860d
Update reftest expectations. r=xidorn

Comment 12

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/29177506860d