Capitalize all methods of Selection

RESOLVED FIXED in Firefox 55

Status

()

Core
Selection
RESOLVED FIXED
7 months ago
7 months ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

Trunk
mozilla55
Points:
---

Firefox Tracking Flags

(firefox55 fixed)

Details

MozReview Requests

()

Submitter Diff Changes Open Issues Last Updated
Loading...
Error loading review requests:

Attachments

(4 attachments)

Comment hidden (empty)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 5

7 months ago
mozreview-review
Comment on attachment 8872273 [details]
Bug 1368397 part 1 - Rename Selection::selectFrames() to Selection::SelectFrames()

https://reviewboard.mozilla.org/r/143766/#review147542
Attachment #8872273 - Flags: review?(mats) → review+

Comment 6

7 months ago
mozreview-review
Comment on attachment 8872274 [details]
Bug 1368397 part 2 - Rename Selection::getTableCellLocationFromRange() to Selection::GetTableCellLocationFromRange()

https://reviewboard.mozilla.org/r/143768/#review147544
Attachment #8872274 - Flags: review?(mats) → review+

Comment 7

7 months ago
mozreview-review
Comment on attachment 8872275 [details]
Bug 1368397 part 3 - Rename Selection::addTableCellRange() to Selection::AddTableCellRange()

https://reviewboard.mozilla.org/r/143770/#review147546
Attachment #8872275 - Flags: review?(mats) → review+

Comment 8

7 months ago
mozreview-review
Comment on attachment 8872276 [details]
Bug 1368397 part 4 - Rename Selection::setAnchorFocusRange() to Selection::SetAnchorFocusRange()

https://reviewboard.mozilla.org/r/143772/#review147552

::: layout/generic/Selection.h:343
(Diff revision 1)
> -                                            // negative value clears
> -                                            // mAnchorFocusRange
> +   * Setting mAnchorFocusRange to mRanges[aIndex] if aIndex is a valid index.
> +   * Setting mAnchorFocusRange to nullptr if aIndex is negative.
> +   * Otherwise, i.e., if aIndex is positive but out of bounds of mRanges, does
> +   * nothing. 

nits:
s/Setting/Set/ (twice)
s/does/do/
there's a trailing space after "nothing."
Attachment #8872276 - Flags: review?(mats) → review+
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)
Comment hidden (mozreview-request)

Comment 13

7 months ago
Pushed by masayuki@d-toybox.com:
https://hg.mozilla.org/integration/autoland/rev/2e878bf1e7be
part 1 - Rename Selection::selectFrames() to Selection::SelectFrames() r=mats
https://hg.mozilla.org/integration/autoland/rev/1c70ad20e58b
part 2 - Rename Selection::getTableCellLocationFromRange() to Selection::GetTableCellLocationFromRange() r=mats
https://hg.mozilla.org/integration/autoland/rev/89baf48da239
part 3 - Rename Selection::addTableCellRange() to Selection::AddTableCellRange() r=mats
https://hg.mozilla.org/integration/autoland/rev/7d2efa6434de
part 4 - Rename Selection::setAnchorFocusRange() to Selection::SetAnchorFocusRange() r=mats

Comment 14

7 months ago
bugherder
https://hg.mozilla.org/mozilla-central/rev/2e878bf1e7be
https://hg.mozilla.org/mozilla-central/rev/1c70ad20e58b
https://hg.mozilla.org/mozilla-central/rev/89baf48da239
https://hg.mozilla.org/mozilla-central/rev/7d2efa6434de
Status: ASSIGNED → RESOLVED
Last Resolved: 7 months ago
status-firefox55: --- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in before you can comment on or make changes to this bug.