1368397 - Capitalize all methods of Selection

Status: RESOLVED FIXED

(Core :: DOM: Selection, enhancement)

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1368397 part 1 - Rename Selection::selectFrames() to Selection::SelectFrames()

Review commit: https://reviewboard.mozilla.org/r/143766/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143766/

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1368397 part 2 - Rename Selection::getTableCellLocationFromRange() to Selection::GetTableCellLocationFromRange()

Review commit: https://reviewboard.mozilla.org/r/143768/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143768/

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1368397 part 3 - Rename Selection::addTableCellRange() to Selection::AddTableCellRange()

Review commit: https://reviewboard.mozilla.org/r/143770/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143770/

Comment 4

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Attachment: Bug 1368397 part 4 - Rename Selection::setAnchorFocusRange() to Selection::SetAnchorFocusRange()

Review commit: https://reviewboard.mozilla.org/r/143772/diff/#index_header
See other reviews: https://reviewboard.mozilla.org/r/143772/

Comment 5

[Mats Palmgren (inactive)]

Comment on attachment 8872273 [details]
Bug 1368397 part 1 - Rename Selection::selectFrames() to Selection::SelectFrames()

https://reviewboard.mozilla.org/r/143766/#review147542

Comment 6

[Mats Palmgren (inactive)]

Comment on attachment 8872274 [details]
Bug 1368397 part 2 - Rename Selection::getTableCellLocationFromRange() to Selection::GetTableCellLocationFromRange()

https://reviewboard.mozilla.org/r/143768/#review147544

Comment 7

[Mats Palmgren (inactive)]

Comment on attachment 8872275 [details]
Bug 1368397 part 3 - Rename Selection::addTableCellRange() to Selection::AddTableCellRange()

https://reviewboard.mozilla.org/r/143770/#review147546

Comment 8

[Mats Palmgren (inactive)]

Comment on attachment 8872276 [details]
Bug 1368397 part 4 - Rename Selection::setAnchorFocusRange() to Selection::SetAnchorFocusRange()

https://reviewboard.mozilla.org/r/143772/#review147552

::: layout/generic/Selection.h:343
(Diff revision 1)
> -                                            // negative value clears
> -                                            // mAnchorFocusRange
> +   * Setting mAnchorFocusRange to mRanges[aIndex] if aIndex is a valid index.
> +   * Setting mAnchorFocusRange to nullptr if aIndex is negative.
> +   * Otherwise, i.e., if aIndex is positive but out of bounds of mRanges, does
> +   * nothing. 

nits:
s/Setting/Set/ (twice)
s/does/do/
there's a trailing space after "nothing."

Comment 9

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8872273 [details]
Bug 1368397 part 1 - Rename Selection::selectFrames() to Selection::SelectFrames()

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143766/diff/1-2/

Comment 10

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8872274 [details]
Bug 1368397 part 2 - Rename Selection::getTableCellLocationFromRange() to Selection::GetTableCellLocationFromRange()

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143768/diff/1-2/

Comment 11

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8872275 [details]
Bug 1368397 part 3 - Rename Selection::addTableCellRange() to Selection::AddTableCellRange()

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143770/diff/1-2/

Comment 12

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 8872276 [details]
Bug 1368397 part 4 - Rename Selection::setAnchorFocusRange() to Selection::SetAnchorFocusRange()

Review request updated; see interdiff: https://reviewboard.mozilla.org/r/143772/diff/1-2/

Comment 13

[Pulsebot]

Pushed by [e-mail]:
https://hg.mozilla.org/integration/autoland/rev/2e878bf1e7be
part 1 - Rename Selection::selectFrames() to Selection::SelectFrames() r=mats
https://hg.mozilla.org/integration/autoland/rev/1c70ad20e58b
part 2 - Rename Selection::getTableCellLocationFromRange() to Selection::GetTableCellLocationFromRange() r=mats
https://hg.mozilla.org/integration/autoland/rev/89baf48da239
part 3 - Rename Selection::addTableCellRange() to Selection::AddTableCellRange() r=mats
https://hg.mozilla.org/integration/autoland/rev/7d2efa6434de
part 4 - Rename Selection::setAnchorFocusRange() to Selection::SetAnchorFocusRange() r=mats

Comment 14

[Carsten Book [:Tomcat]]

https://hg.mozilla.org/mozilla-central/rev/2e878bf1e7be
https://hg.mozilla.org/mozilla-central/rev/1c70ad20e58b
https://hg.mozilla.org/mozilla-central/rev/89baf48da239
https://hg.mozilla.org/mozilla-central/rev/7d2efa6434de