Closed
Bug 1368406
Opened 7 years ago
Closed 7 years ago
MinGW Printf Format Errors when --enable-debug is set
Categories
(Core :: JavaScript Engine: JIT, defect)
Core
JavaScript Engine: JIT
Tracking
()
RESOLVED
FIXED
mozilla55
Tracking | Status | |
---|---|---|
firefox55 | --- | fixed |
People
(Reporter: tjr, Assigned: tjr)
References
(Blocks 1 open bug)
Details
(Whiteboard: [tor])
Attachments
(1 file)
It looks like some more/new Printf errors for MinGW have popped up:
> 5:39.36 In file included from /home/tom/Documents/moz/mingw-work/just-build-4/obj-mingw/js/src/Unified_cpp_js_src17.cpp:11:0:
> 5:39.36 /home/tom/Documents/moz/mingw-work/just-build-4/js/src/jit/OptimizationTracking.cpp: In static member function ‘static bool > js::jit::IonTrackedOptimizationsRegion::WriteRun(js::jit::CompactBufferWriter&, const js::jit::NativeToTrackedOptimizations*, const > js::jit::NativeToTrackedOptimizations*, const js::jit::UniqueTrackedOptimizations&)’:
> 5:39.36 /home/tom/Documents/moz/mingw-work/just-build-4/js/src/jit/OptimizationTracking.cpp:779:66: error: unknown conversion type character ‘I’ in > format [-Werror=format=]
> 5:39.36 unique.indexOf(start->optimizations), writer.length());
> 5:39.36 ^
> 5:39.37 /home/tom/Documents/moz/mingw-work/just-build-4/js/src/jit/OptimizationTracking.cpp:779:66: error: unknown conversion type character ‘I’ in > format [-Werror=format=]
> 5:39.37 /home/tom/Documents/moz/mingw-work/just-build-4/js/src/jit/OptimizationTracking.cpp:779:66: error: unknown conversion type character ‘I’ in > format [-Werror=format=]
> 5:39.37 /home/tom/Documents/moz/mingw-work/just-build-4/js/src/jit/OptimizationTracking.cpp:779:66: error: too many arguments for format > [-Werror=format-extra-args]
> 5:39.37 /home/tom/Documents/moz/mingw-work/just-build-4/js/src/jit/OptimizationTracking.cpp:795:83: error: unknown conversion type character ‘I’ in > format [-Werror=format=]
> 5:39.37 startOffset, endOffset, startDelta, length, index, writer.length());
> 5:39.37 ^
> 5:39.37 /home/tom/Documents/moz/mingw-work/just-build-4/js/src/jit/OptimizationTracking.cpp:795:83: error: too many arguments for format > [-Werror=format-extra-args]
> 5:45.56 In file included from /home/tom/Documents/moz/mingw-work/just-build-4/obj-mingw/js/src/Unified_cpp_js_src20.cpp:20:0:
> 5:45.56 /home/tom/Documents/moz/mingw-work/just-build-4/js/src/jit/shared/CodeGenerator-shared.cpp: In member function ‘void > js::jit::CodeGeneratorShared::dumpNativeToBytecodeEntry(uint32_t)’:
> 5:45.56 /home/tom/Documents/moz/mingw-work/just-build-4/js/src/jit/shared/CodeGenerator-shared.cpp:313:54: error: unknown conversion type character ‘I’ > in format [-Werror=format=]
> 5:45.56 script->filename(), script->lineno());
> 5:45.56 ^
> 5:45.56 /home/tom/Documents/moz/mingw-work/just-build-4/js/src/jit/shared/CodeGenerator-shared.cpp:313:54: error: format ‘%ld’ expects argument of type > ‘long int’, but argument 4 has type ‘unsigned int’ [-Werror=format=]
> 5:45.56 /home/tom/Documents/moz/mingw-work/just-build-4/js/src/jit/shared/CodeGenerator-shared.cpp:313:54: error: format ‘%d’ expects argument of type > ‘int’, but argument 5 has type ‘long int’ [-Werror=format=]
> 5:45.56 /home/tom/Documents/moz/mingw-work/just-build-4/js/src/jit/shared/CodeGenerator-shared.cpp:313:54: error: format ‘%s’ expects argument of type > ‘char*’, but argument 6 has type ‘unsigned int’ [-Werror=format=]
> 5:45.56 /home/tom/Documents/moz/mingw-work/just-build-4/js/src/jit/shared/CodeGenerator-shared.cpp:313:54: error: format ‘%u’ expects argument of type > ‘unsigned int’, but argument 8 has type ‘const char*’ [-Werror=format=]
> 5:45.56 /home/tom/Documents/moz/mingw-work/just-build-4/js/src/jit/shared/CodeGenerator-shared.cpp:313:54: error: too many arguments for format > [-Werror=format-extra-args]
> 5:45.71 cc1plus: some warnings being treated as errors
> 5:46.40 /home/tom/Documents/moz/mingw-work/just-build-4/config/rules.mk:1059: recipe for target 'Unified_cpp_js_src17.o' failed
> 5:46.40 make[5]: *** [Unified_cpp_js_src17.o] Error 1
> 5:46.40 make[5]: *** Waiting for unfinished jobs....
> 5:50.00 cc1plus: some warnings being treated as errors
> 5:50.48 /home/tom/Documents/moz/mingw-work/just-build-4/config/rules.mk:1059: recipe for target 'Unified_cpp_js_src20.o' failed
> 5:50.48 make[5]: *** [Unified_cpp_js_src20.o] Error 1
> 5:52.70 In file included from /home/tom/Documents/moz/mingw-work/just-build-4/obj-mingw/js/src/Unified_cpp_js_src25.cpp:11:0:
> 5:52.70 /home/tom/Documents/moz/mingw-work/just-build-4/js/src/jsgc.cpp: In function ‘void js::gc::DumpArenaInfo()’:
> 5:52.70 /home/tom/Documents/moz/mingw-work/just-build-4/js/src/jsgc.cpp:1120:64: error: unknown conversion type character ‘I’ in format [-Werror=format=]
> 5:52.70 Arena::firstThingOffset(kind) - ArenaHeaderSize);
> 5:52.70 ^
> 5:52.70 /home/tom/Documents/moz/mingw-work/just-build-4/js/src/jsgc.cpp:1120:64: error: unknown conversion type character ‘I’ in format [-Werror=format=]
> 5:52.70 /home/tom/Documents/moz/mingw-work/just-build-4/js/src/jsgc.cpp:1120:64: error: unknown conversion type character ‘I’ in format [-Werror=format=]
> 5:52.70 /home/tom/Documents/moz/mingw-work/just-build-4/js/src/jsgc.cpp:1120:64: error: too many arguments for format [-Werror=format-extra-args]>
Comment hidden (mozreview-request) |
Assignee | ||
Updated•7 years ago
|
Attachment #8872243 -
Flags: review?(nfroyd)
![]() |
||
Comment 2•7 years ago
|
||
mozreview-review |
Comment on attachment 8872243 [details] Bug 1368406 Use non-Windows Printf Format Specifiers in MinGW https://reviewboard.mozilla.org/r/143726/#review147504
Attachment #8872243 -
Flags: review?(nfroyd) → review+
Assignee | ||
Updated•7 years ago
|
Keywords: checkin-needed
Pushed by cbook@mozilla.com: https://hg.mozilla.org/integration/autoland/rev/6909c7487def Use non-Windows Printf Format Specifiers in MinGW r=froydnj
Keywords: checkin-needed
Comment 4•7 years ago
|
||
bugherder |
https://hg.mozilla.org/mozilla-central/rev/6909c7487def
Status: NEW → RESOLVED
Closed: 7 years ago
status-firefox55:
--- → fixed
Resolution: --- → FIXED
Target Milestone: --- → mozilla55
You need to log in
before you can comment on or make changes to this bug.
Description
•